----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126158/#review88884 -----------------------------------------------------------
Ship it! Ship It! - Albert Astals Cid On nov. 24, 2015, 7:39 p.m., Oliver Sander wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126158/ > ----------------------------------------------------------- > > (Updated nov. 24, 2015, 7:39 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > The unit test 'editdrawingtooldialogtest' on the frameworks branch aborts at > run-time. Reason: it expects the dialog to have a KLineEdit member with > object name 'name'. That KLineEdit does exist in the dialog, but no object > name is set for it at all. This patch explicitly sets the object name to > 'name', which makes the editdrawingtooldialogtest pass again. > > > Diffs > ----- > > conf/editdrawingtooldialog.cpp bcd65e1 > > Diff: https://git.reviewboard.kde.org/r/126158/diff/ > > > Testing > ------- > > > Thanks, > > Oliver Sander > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
