Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review50894 --- Ok, amazing work :-) - Albert Astals Cid On Feb. 25, 2014,

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review50893 --- This review has been submitted with commit a80922d45e66605075

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/ --- (Updated Feb. 25, 2014, 10:59 p.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

> On Feb. 24, 2014, 7:46 p.m., Albert Astals Cid wrote: > > core/textpage.cpp, line 72 > > > > > > Why are these called left/right if we pass top/bottom from the > > functions below? My thought was that this met

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review50753 --- core/textpage.cpp

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

> On Feb. 15, 2014, 3:13 p.m., Albert Astals Cid wrote: > > tests/searchtest.cpp, line 64 > > > > > > please use kDebug and remove the iostream include > > Jaan Vajakas wrote: > Actually I wanted something li

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/ --- (Updated Feb. 22, 2014, 2:51 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

> On Feb. 15, 2014, 3:13 p.m., Albert Astals Cid wrote: > > tests/searchtest.cpp, line 64 > > > > > > please use kDebug and remove the iostream include > > Jaan Vajakas wrote: > Actually I wanted something li

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/ --- (Updated Feb. 22, 2014, 12:50 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

> On Feb. 15, 2014, 3:13 p.m., Albert Astals Cid wrote: > > core/textpage.cpp, line 790 > > > > > > why this change? > > Jaan Vajakas wrote: > As I wrote, the reason is that I think it is not good that layou

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

> On Feb. 15, 2014, 3:13 p.m., Albert Astals Cid wrote: > > core/textpage.cpp, line 790 > > > > > > why this change? As I wrote, the reason is that I think it is not good that layout analysis depends on the use

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review49831 --- core/textpage.cpp

[Okular-devel] Review Request 115759: Fix for Bug 326207

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/ --- Review request for Okular. Bugs: 326207 http://bugs.kde.org/show_bug.