[Active] [Bug 308240] active-documentviewer crashes by using zoom gestures

2020-06-29 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

D12884: Remove the internal file navigation from the global drawer

2018-05-17 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid

D12770: Android: Make it possible to associate with files

2018-05-11 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. Restricted Application added a subscriber: okular-devel. REPOSITORY R223 Okular BRANCH filesAndroid REVISION DETAIL https://phabricator.kde.org/D12770 To: apol, #okular, aacid, mart Cc: okular-devel, ngraham, aa

D12299: Android: include metadata for okular kirigami

2018-04-18 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for the icon, maybe a png version of https://cgit.kde.org/breeze-icons.git/tree/icons/apps/48/okular.svg which is the breeze icon REPOSITORY R223 Okular BRANCH okularkirigamiandroid REVI

D12176: Turn okularkirigami into an executable

2018-04-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12176 To: apol, #kirigami, #okular, mart Cc: plasma-devel, michaelweghorn, ngraham, apol, aacid, davidedmundson, mart, hein

Re: [Okular-devel] Review Request 121326: initial port of QML components to QtQuick2

2014-12-02 Thread Marco Martin
29c53 Diff: https://git.reviewboard.kde.org/r/121326/diff/ Testing --- files open and render from a simple qml file Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 121326: initial port of QML components to QtQuick2

2014-12-02 Thread Marco Martin
/r/121326/#review71246 --- On Dec. 2, 2014, 12:08 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

[Okular-devel] Review Request 121326: initial port of QML components to QtQuick2

2014-12-02 Thread Marco Martin
ender from a simple qml file Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115751: QML PageItem: Handle document path changes

2014-02-14 Thread Marco Martin
> On Feb. 14, 2014, 7:15 p.m., Marco Martin wrote: > > looks fine to me (would like a +1 from okular people too tough) > > Albert Astals Cid wrote: > I am wondering who sets m_page back to something other than 0, but if you > say it works, let's ship it :D whatev

Re: [Okular-devel] Review Request 115751: QML PageItem: Handle document path changes

2014-02-14 Thread Marco Martin
people too tough) - Marco Martin On Feb. 14, 2014, 7:10 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Okular-devel] [Active] [Bug 308240] active-documentviewer crashes by using zoom gestures

2013-08-09 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin changed: What|Removed |Added CC||okular-devel@kde.org --- Comment #28 from Marco

Re: [Okular-devel] okular active: rendering issues with document scrolling

2013-07-10 Thread Marco Martin
ent seems to re-render correctly when zooming -- Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built

2013-02-20 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=314981 --- Comment #3 from Marco Martin --- i added tryexec in the end so distributions can't include all that is in generators in the same package without having to worry to move out the files of active, if they want to make separate packages of

[Okular-devel] [okular] [Bug 314981] active-documentviewer desktop files are installed even if app is not built

2013-02-20 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=314981 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Marco Martin
> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Marco Martin
have it in KDE/4.10 branch - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- On Feb. 19

[Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-19 Thread Marco Martin
/diff/ Testing --- tried to install both with and without active_found Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Split active app desktop file

2012-10-22 Thread Marco Martin
n automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/#review20581 ------- On Oct. 18, 2012, 9:09 a.m., Marco Martin wrote: > > --- > This is an automatically gen

Re: [Okular-devel] Review Request: Split active app desktop file

2012-10-18 Thread Marco Martin
---- On Oct. 18, 2012, 9:09 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106930/ >

Re: [Okular-devel] Review Request: Split active app desktop file

2012-10-18 Thread Marco Martin
/106930/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request: Split active app desktop file

2012-10-17 Thread Marco Martin
generators/tiff/CMakeLists.txt 31186ea generators/tiff/active-documentviewer_tiff.desktop PRE-CREATION generators/xps/CMakeLists.txt 50eec71 generators/xps/active-documentviewer_xps.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106930/diff/ Testing --- Thanks, Marco

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-15 Thread Marco Martin
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review20324 --- On Oct. 12, 2012, 12:54 p.m., Marco Martin wrote: > > ---

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-12 Thread Marco Martin
/10/diff/ Testing --- Thanks, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-05 Thread Marco Martin
packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: > module "org.kde.plasma.extras" is not installed > import org.kde.plasma.extras 0.1 as PlasmaExtras > > > Marco Martin wrote: > with qmlviewer or with the compiled app? > the plasmaextras i

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-05 Thread Marco Martin
packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: > module "org.kde.plasma.extras" is not installed > import org.kde.plasma.extras 0.1 as PlasmaExtras > > > Marco Martin wrote: > with qmlviewer or with the compiled app? > the plasmaextras i

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-04 Thread Marco Martin
packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: > module "org.kde.plasma.extras" is not installed > import org.kde.plasma.extras 0.1 as PlasmaExtras > > > Marco Martin wrote: > with qmlviewer or with the compiled app? > the plasmaextras i

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-04 Thread Marco Martin
ports filename.qml - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review19864 --- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: >

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Marco Martin
> On Oct. 1, 2012, 7:54 p.m., Albert Astals Cid wrote: > > You seem to be missing a Message.sh file > > Marco Martin wrote: > i added a couple of messages.sh and catalogs. > org.kde.active.documentviewer.pot for the app, both qml and c++ parts > org.kd

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-03 Thread Marco Martin
/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Marco Martin
-CREATION active/components/thumbnailitem.h PRE-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin

Re: [Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-02 Thread Marco Martin
> > should not be that bad i guess > > > > Wait, you copied the code? That's a no go, i don't want to fix bugs > > twice in that huge file that was in the "maybe i'll have to move this on aother repo" category ;) i changed it now to

Re: [Okular-devel] merging the mart/okularActive branch into master

2012-10-01 Thread Marco Martin
ar), but then yeah, we can move it elsewhere ;) > - You are the other one that has done coding on the active branch and you > want it merged in master > > So so let's see the patch in reviewboard to merge this into master and > discuss over hard facts :-) here ;) https://git.reviewboard.kde.org/r/10/ Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request: QML components and touch optimized okular version

2012-10-01 Thread Marco Martin
-CREATION active/components/thumbnailitem.cpp PRE-CREATION active/components/tocmodel.h PRE-CREATION active/components/tocmodel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/10/diff/ Testing --- Thanks, Marco Martin

Re: [Okular-devel] merging the mart/okularActive branch into master

2012-09-29 Thread Marco Martin
, having a single repo for all mobile versions of applications doesn't scale (for many application won't be even possible) having separate repos one for each mobile application becomes pretty quickly a mess. (besides, i hope in some futur

Re: [Okular-devel] Okular active

2012-05-15 Thread Marco Martin
On Tuesday 15 May 2012, Albert Astals Cid wrote: > El Dilluns, 14 de maig de 2012, a les 21:04:49, Marco Martin va escriure: > > Hi all, > > Hi > > > (please maintain CC: since not everybody is subscribed to both lists) > > > > Looking at the current status o

[Okular-devel] Okular active

2012-05-14 Thread Marco Martin
, table of contents and support for hyperlinks (maybe the api will have to be changed a bit to have that) Cheers, Marco Martin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel