> On Oct. 3, 2012, 10:41 p.m., Albert Astals Cid wrote: > > Little summary since the other block is getting huge :D > > > > * Messages.sh tweaking after merge > > * .desktop for format support tweaking after merge > > * Bookmark viewport vs page number > > * Pagepainter API to disable AA > > > > I think we can leave the pagepainter change for after the merge too, not > > sure about the bookmark thing since it's "public qml API" related, not that > > we have to promise API stability on the QML side either... > > > > So what do you say, you want to me to merge now or finish the fixup these > > things? > > Albert Astals Cid wrote: > Ah, there's also the issue that i get this on running > > file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: > module "org.kde.plasma.extras" is not installed > import org.kde.plasma.extras 0.1 as PlasmaExtras > > > Marco Martin wrote: > with qmlviewer or with the compiled app? > the plasmaextras import exists since 4.9, so it should work > > if it's with qmlviewer it's known, because it doesn't know where the > import folder is (we can't use the global hardcoded /usr/imports since we > have to respect the install prefix) > > so qml files using any import from org.kde.* needs qmlviewer -I > prefix/lib/kde4/imports filename.qml > > Marco Martin wrote: > something that i would like to do before merge still is the bookmark > management (since may require quite some changes in the qml part as well, > still not sure how much invasive). > > how do you think it should be done? ie, how would you expose the > bookmarks in qml? > i still don't have clear exactly what a bookmark url represents, so i > need a more informed idea ;) > > Albert Astals Cid wrote: > Fixed the import thing, was a PEBKAC. > > About the bookmarks, well, a bookmarl url represents the url to the > document and the viewport to move to the document. DocumentViewport knows how > to handle that you shouldn't need to know more, just feed it to the document > and that's it. > > Also there is the binding loop we talked about on IRC that would be good > if was fixed before merging. > > Marco Martin wrote: > I am starting to make use of DocumentViewport to have more info about the > bookmarks (pushed in branch). > > one thing i still wish to have is to avoid the bookmark urls to be > exposed, but have a model with document, page, position roles
for how bookmarkmanager works doesn't seem possible to map directly when a new bookmark is inserted or removed, but you know only when something changed, so would be necessary to do a complete model reset every time? maybe this would be too expensive? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106666/#review19864 ----------------------------------------------------------- On Oct. 3, 2012, 10:17 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106666/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 10:17 a.m.) > > > Review request for Okular. > > > Description > ------- > > This patch provides some QML imports org.kde.okular.* to use some features of > okularcore directly from qml (basically, components for documents and page > rendering) > > Then there is a small application, mostly QML, that use those components to > build a document reader optimized for touch devices, used on Plasma Active > > > Diffs > ----- > > CMakeLists.txt a057e82 > active/CMakeLists.txt PRE-CREATION > active/app/CMakeLists.txt PRE-CREATION > active/app/Messages.sh PRE-CREATION > active/app/active-documentviewer.desktop PRE-CREATION > active/app/package/contents/ui/Bookmarks.qml PRE-CREATION > active/app/package/contents/ui/Browser.qml PRE-CREATION > active/app/package/contents/ui/FullScreenDelegate.qml PRE-CREATION > active/app/package/contents/ui/TableOfContents.qml PRE-CREATION > active/app/package/contents/ui/Thumbnails.qml PRE-CREATION > active/app/package/contents/ui/ThumbnailsBase.qml PRE-CREATION > active/app/package/contents/ui/TreeDelegate.qml PRE-CREATION > active/app/package/contents/ui/bookmark.png PRE-CREATION > active/app/package/contents/ui/bookmark.svgz PRE-CREATION > active/app/package/contents/ui/main.qml PRE-CREATION > active/app/package/metadata.desktop PRE-CREATION > active/app/src/CMakeLists.txt PRE-CREATION > active/app/src/main.cpp PRE-CREATION > active/components/CMakeLists.txt PRE-CREATION > active/components/Messages.sh PRE-CREATION > active/components/documentitem.h PRE-CREATION > active/components/documentitem.cpp PRE-CREATION > active/components/okularplugin.h PRE-CREATION > active/components/okularplugin.cpp PRE-CREATION > active/components/pageitem.h PRE-CREATION > active/components/pageitem.cpp PRE-CREATION > active/components/qmldir PRE-CREATION > active/components/thumbnailitem.h PRE-CREATION > active/components/thumbnailitem.cpp PRE-CREATION > active/components/tocmodel.h PRE-CREATION > active/components/tocmodel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106666/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
