> On Oct. 17, 2012, 9:56 p.m., Albert Astals Cid wrote: > > generators/xps/CMakeLists.txt, line 22 > > <http://git.reviewboard.kde.org/r/106930/diff/1/?file=90978#file90978line22> > > > > Why the active-documentviewer_xps in both install lines?
whops, that's was just forgotten, corrected also a similar issue in the dvi one - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106930/#review20528 ----------------------------------------------------------- On Oct. 18, 2012, 9:09 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106930/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2012, 9:09 a.m.) > > > Review request for Okular. > > > Description > ------- > > splits the desktop file of the active app per mimetype, as is done for the > desktop version and for the part, so only the ones that were actually built > will be supported > > > Diffs > ----- > > active/app/active-documentviewer.desktop 66c751e > generators/chm/CMakeLists.txt 3f28603 > generators/chm/active-documentviewer_chm.desktop PRE-CREATION > generators/comicbook/CMakeLists.txt 067a07a > generators/comicbook/active-documentviewer_comicbook.desktop PRE-CREATION > generators/djvu/CMakeLists.txt dc9b998 > generators/djvu/active-documentviewer_djvu.desktop PRE-CREATION > generators/dvi/CMakeLists.txt d517b42 > generators/dvi/active-documentviewer_dvi.desktop PRE-CREATION > generators/epub/CMakeLists.txt f05bf38 > generators/epub/active-documentviewer_epub.desktop PRE-CREATION > generators/fax/CMakeLists.txt 79e7faa > generators/fax/active-documentviewer_fax.desktop PRE-CREATION > generators/fictionbook/CMakeLists.txt 821cdbf > generators/fictionbook/active-documentviewer_fb.desktop PRE-CREATION > generators/kimgio/CMakeLists.txt 07d9f0c > generators/ooo/CMakeLists.txt 2496fbb > generators/ooo/active-documentviewer_ooo.desktop PRE-CREATION > generators/plucker/CMakeLists.txt c79d59a > generators/plucker/active-documentviewer_plucker.desktop PRE-CREATION > generators/poppler/CMakeLists.txt 78885fc > generators/poppler/active-documentviewer_pdf.desktop PRE-CREATION > generators/spectre/CMakeLists.txt d3d6f80 > generators/spectre/active-documentviewer_ghostview.desktop PRE-CREATION > generators/tiff/CMakeLists.txt 31186ea > generators/tiff/active-documentviewer_tiff.desktop PRE-CREATION > generators/xps/CMakeLists.txt 50eec71 > generators/xps/active-documentviewer_xps.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106930/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel