/textdocumentgenerator.cpp f370ded
Diff: https://git.reviewboard.kde.org/r/109364/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
discarded.
Review request for Okular and Albert Astals Cid.
Description
---
Seems than poppler used it.
And compilation error occurs.
Diffs
-
generators/poppler/annots.cpp 3694188
Diff: http://git.reviewboard.kde.org/r/110480/diff/
Testing
---
Compiling is ok
Thanks,
Azat
otten to check
> > when I reviewed the other patch :)
You are welcome.
So I just close this issue.
- Azat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110480/#review
/diff/
Testing
---
Compiling is ok
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
r/annots.cpp 3694188
generators/txt/CMakeLists.txt 473ea12
generators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
---
Seems than poppler used it.
And compilation error occurs.
Diffs
-
generators/poppler/annots.cpp 3694188
Diff: http://git.reviewboard.kde.org/r/110480/diff/
Testing
---
Compiling is ok
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
t/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
Okular-d
.cpp 59cf514
shell/okular.desktop d654cfa
tests/modifyannotationpropertiestest.cpp 16d9f9b
ui/pagepainter.cpp 2890b56
ui/pageviewannotator.cpp 035c1f3
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
------
On May 16, 2013, 10:02 p.m., Azat Khuzhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109021/
> ---
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote:
> > core/textdocumentgenerator.h, line 217
> > <http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217>
> >
> > This should ideally be a function of the private class
>
&
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote:
> > core/textdocumentgenerator.h, line 217
> > <http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217>
> >
> > This should ideally be a function of the private class
>
&
ktop 328ae26
generators/txt/CMakeLists.txt 5a126b7
generators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote:
> > core/textdocumentgenerator.h, line 217
> > <http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217>
> >
> > This should ideally be a function of the private class
>
&
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote:
> > core/textdocumentgenerator.h, line 217
> > <http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217>
> >
> > This should ideally be a function of the private class
>
&
nerators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
nerators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
> > use it. This means you need to add it to the install list somewhere in the
> > CMakeLists.txt and that you should add a d-pointer so it's possible to keep
> > Binary Compatibility when we need to add more fields, etc. Also some
> > documentation at least menti
> On May 13, 2013, 10:48 p.m., Albert Astals Cid wrote:
> > core/textdocumentgenerator.h, line 217
> > <http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217>
> >
> > This should ideally be a function of the private class
>
&
> > use it. This means you need to add it to the install list somewhere in the
> > CMakeLists.txt and that you should add a d-pointer so it's possible to keep
> > Binary Compatibility when we need to add more fields, etc. Also some
> > documentation at least menti
erator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
Okular-devel mailing
xplain why you think so?
- Azat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review32466
---
On May 12, 201
i think it'd make more sense for the skeleton parent to be "this"
> > and not "parent", otherwise you are parenting it to the grandfather
>
> Azat Khuzhin wrote:
> About TextDocumentSettings, it's an interesting question.
>
> I can del
> > use it. This means you need to add it to the install list somewhere in the
> > CMakeLists.txt and that you should add a d-pointer so it's possible to keep
> > Binary Compatibility when we need to add more fields, etc. Also some
> > documentation at least menti
ator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde
> > use it. This means you need to add it to the install list somewhere in the
> > CMakeLists.txt and that you should add a d-pointer so it's possible to keep
> > Binary Compatibility when we need to add more fields, etc. Also some
> > documentation at least menti
> > use it. This means you need to add it to the install list somewhere in the
> > CMakeLists.txt and that you should add a d-pointer so it's possible to keep
> > Binary Compatibility when we need to add more fields, etc. Also some
> > documentation at least menti
/CMakeLists.txt 5a126b7
generators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat Khuzhin
-
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review32266
---
On May 8, 2013, 4:13 a.m., Azat Khuzhin wrote:
>
>
;
>> > may be
>> >
>> > > > > > changing one line.
>> > > > > >
>> > > > > > What would be GSoC worthy would be a "Improve Okular for EPub
>> >
>> > viewing"
>> >
>> > > > and
>> > > >
>
mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review32266
-------
On May 8, 2013, 4:13 a.m., Azat Khuzhin wrote:
>
> ---
> This is an automatically gener
328ae26
generators/txt/CMakeLists.txt 5a126b7
generators/txt/generator_txt.h 5c15ec4
generators/txt/generator_txt.cpp 93ca4aa
generators/txt/libokularGenerator_txt.desktop 235e23d
Diff: http://git.reviewboard.kde.org/r/109021/diff/
Testing
---
Tested manually
Thanks,
Azat
(updated)
---
Just drop unused libraries from generators/txt/CMakeLists.txt
Diffs (updated)
-
generators/txt/CMakeLists.txt 5a126b7
Diff: http://git.reviewboard.kde.org/r/110263/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular
target_link_libraries() from CMakeLists
Diffs
-
generators/txt/CMakeLists.txt 5a126b7
Diff: http://git.reviewboard.kde.org/r/110263/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote:
> > Azat you still interested in working on this?
>
> Azat Khuzhin wrote:
> Yes, I will try to look at this weekend.
> I don't have enough time for this at weekdays.
>
> Azat Khuzhin wrote:
>
> On April 4, 2013, 6:19 p.m., Albert Astals Cid wrote:
> > Azat you still interested in working on this?
>
> Azat Khuzhin wrote:
> Yes, I will try to look at this weekend.
> I don't have enough time for this at weekdays.
Sorry for such a long delay, I have th
automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review30393
---
On Feb. 23, 2013, 11:56 a.m., Azat Khuzhin wrote:
>
> ---
> This is an au
/show_bug.cgi?id=306572
Diffs
-
core/textdocumentgenerator.cpp f370ded
Diff: http://git.reviewboard.kde.org/r/109364/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman
On Mon, Apr 1, 2013 at 10:38 PM, Jaydeep Solanki wrote:
>
>
> On Mon, Apr 1, 2013 at 11:55 PM, Azat Khuzhin wrote:
>>
>> Hi
>>
>> Respectfully
>> Azat Khuzhin.
>> From phone.
>>
>>
>> On Apr 1, 2013 12:22 PM, "Jaydeep Solanki&qu
Hi
Respectfully
Azat Khuzhin.
>From phone.
On Apr 1, 2013 12:22 PM, "Jaydeep Solanki" wrote:
>
> Hello,
> I remember Albert, telling me about css being ignored in epub documents,
so I had a look into it.
> I'm not sure if we are adding the stylesheet from externa
round to be white, wonder why we
> > are not getting it white then :S
> >
> > Do yo have time to investigate why this is happening? Because it we commit
> > this patch directly i feel it would be going from one bug to another, and
> > not sure it makes much sense
round to be white, wonder why we
> > are not getting it white then :S
> >
> > Do yo have time to investigate why this is happening? Because it we commit
> > this patch directly i feel it would be going from one bug to another, and
> > not sure it makes much sense
> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?
>
> Jaydeep Solanki wrote:
> Yes, because it prevents "asdfhttp://www.google.com"; from getting
> detected.
>
> Azat Khuzh
round to be white, wonder why we
> > are not getting it white then :S
> >
> > Do yo have time to investigate why this is happening? Because it we commit
> > this patch directly i feel it would be going from one bug to another, and
> > not sure it makes much sense
still needed?
- Azat Khuzhin
On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?
>
> Jaydeep Solanki wrote:
> Yes, because it prevents "asdfhttp://www.google.com"; from getting
> detected.
I think that for th
I'll upload the patch.
- Azat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review28843
---
On March 8, 2013, 11
,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
com/ф"; -> "http://google.com/";
- Azat Khuzhin
On March 5, 2013, 1:26 p.m., Jaydeep Solanki wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
uot; and validate URL using qt/kde method? (I
think qt/kde must have such)
But if there is no such, here is a good example of regexp for URL's -
http://stackoverflow.com/a/190405
Also see note about "u" modifier.
> On March 3, 2013, 4:47 p.m., Albert Astals Cid wrote:
> > This is still detecting "http://google.com)" as something you can call open
> > link on. I'm not sure if "http://google.com)" is valid or not, but when you
> > click on the "Go got 'http://google.com)'" I am getting a "Malformed URL"
ced it is
> > faster? Otherwise maybe there is no really need to change the existing code
> > if it works as well?
>
> Azat Khuzhin wrote:
> Yes it is only speed-wise improvement, as I already told.
> > Description:
> > Don't to extra job, when encoding i
still needs to be good, not sure i can think of one now.
> > Anyone has ideas?
>
> Azat Khuzhin wrote:
> Yes we could write "Defines font for text based documents." or something
> like this.
>
> As for addPages() in which window it adds options?
&g
omatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109119/#review28231
-------
On Feb. 25, 2013, 8:15 p.m., Azat Khuzhin wrote:
>
> ---
> This is an au
> On Feb. 23, 2013, 6:51 p.m., Azat Khuzhin wrote:
> > generators/txt/document.cpp, line 69
> > <http://git.reviewboard.kde.org/r/109119/diff/1/?file=115130#file115130line69>
> >
> > Maybe we must use `array.left( i )` here?
> > And increment i += c
Diffs (updated)
-
generators/txt/document.h 08babea
generators/txt/document.cpp badb647
Diff: http://git.reviewboard.kde.org/r/109119/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
still needs to be good, not sure i can think of one now.
> > Anyone has ideas?
>
> Azat Khuzhin wrote:
> Yes we could write "Defines font for text based documents." or something
> like this.
>
> As for addPages() in which window it adds options?
&g
g/r/109119/#comment20938>
Maybe we must use `array.left( i )` here?
And increment i += chunkSize before.
- Azat Khuzhin
On Feb. 23, 2013, 6:49 p.m., Azat Khuzhin wrote:
>
> ---
> This is an automatically generated e
when encoding is detected just return encoding.
Diffs
-
generators/txt/document.cpp badb647
generators/txt/document.h 08babea
Diff: http://git.reviewboard.kde.org/r/109119/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel ma
, because the text also can be extracted from PDF
and use the same font for rendering. No?
- Azat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109021/#review27753
-----
still needs to be good, not sure i can think of one now.
> > Anyone has ideas?
>
> Azat Khuzhin wrote:
> Yes we could write "Defines font for text based documents." or something
> like this.
>
> As for addPages() in which window it adds options?
&g
On Mon, Feb 18, 2013 at 3:36 AM, Albert Astals Cid wrote:
> El Dilluns, 18 de febrer de 2013, a les 03:27:25, Azat Khuzhin va escriure:
>> On Feb 18, 2013 2:45 AM, "Albert Astals Cid" wrote:
>> > El Divendres, 15 de febrer de 2013, a les 00:45:10, Azat Khuzhin va
&g
On Mon, Feb 18, 2013 at 2:54 AM, Albert Astals Cid wrote:
> El Diumenge, 17 de febrer de 2013, a les 15:33:01, Azat Khuzhin va escriure:
>> I improve font selector, now user don't need to reopen document
>> manually to change font, it will be done automatically.
>>
>
rning -> debug
> > empty space at the end of line
Fixed in patch r2.
- Azat
-------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27676
--
ttp://git.reviewboard.kde.org/r/109009/diff/
Testing
---
Tested manually.
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
g/r/109009/#comment20737>
No, if encoding is empty is return "" - empty string, see above
- Azat Khuzhin
On Feb. 18, 2013, 5:03 p.m., Azat Khuzhin wrote:
>
> ---
> This is an automatically generated e-mail
/txt/document.h PRE-CREATION
generators/txt/document.cpp PRE-CREATION
generators/txt/generator_txt.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109009/diff/
Testing
---
Tested manually.
Thanks,
Azat Khuzhin
___
Okular-devel mailing
iff: http://git.reviewboard.kde.org/r/109009/diff/
Testing
---
Tested manually.
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
On Feb 18, 2013 2:45 AM, "Albert Astals Cid" wrote:
>
> El Divendres, 15 de febrer de 2013, a les 00:45:10, Azat Khuzhin va
escriure:
> > Here is simple version of font selector for plain text formats.
> > (Formats based on TextDocumentGenerator.)
> >
> >
On Feb 18, 2013 2:43 AM, "Albert Astals Cid" wrote:
>
> El Dijous, 14 de febrer de 2013, a les 10:41:24, Azat Khuzhin va escriure:
> > Hi Albert,
> >
> > Thanks, I forgot about that places.
> > Fixed.
> >
> > Maybe I need to push this patch
otkey)
In
https://github.com/azat/okular/commit/0d3817ddcc1b0862072a2a74535edde89b6ad35d
Can anybody tell, why this happened?
On Fri, Feb 15, 2013 at 12:45 AM, Azat Khuzhin wrote:
> Here is simple version of font selector for plain text formats.
> (Formats based on TextDocumentGenerator.)
git.reviewboard.kde.org if this will be
more comfortable.
On Thu, Feb 14, 2013 at 10:41 AM, Azat Khuzhin wrote:
> Hi Albert,
>
> Thanks, I forgot about that places.
> Fixed.
>
> Maybe I need to push this patch to git.reviewboard.kde.org ?
>
> On Thu, Feb 14, 2013 at 3:08 AM,
Hi Albert,
Thanks, I forgot about that places.
Fixed.
Maybe I need to push this patch to git.reviewboard.kde.org ?
On Thu, Feb 14, 2013 at 3:08 AM, Albert Astals Cid wrote:
> El Dijous, 14 de febrer de 2013, a les 01:15:39, Azat Khuzhin va escriure:
>> Hi all,
>>
&g
/compare/master...add-txt-support
New screenshot available here:
http://i.imgur.com/YZEmlg0.png
Any wishes?
On Wed, Feb 13, 2013 at 8:48 AM, Azat Khuzhin wrote:
> On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid wrote:
>> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat K
On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid wrote:
> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat Khuzhin va escriure:
>> On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid wrote:
>> > El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat Khuzhin va
> e
On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid wrote:
> El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat Khuzhin va escriure:
>> Hi all,
>
> Hi
>
>> I write simple plain text backend for okular.
>> https://github.com/azat/okular/tree/add-txt-support
>
https://github.com/azat/okular/compare/master...add-txt-support.patch
Graphic view available here
https://github.com/azat/okular/compare/master...add-txt-support
P.S. I will gladly except you help with development.
--
Azat Khuzhin
Primary email: a3at.m...@gmai
77 matches
Mail list logo
