----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review28482 -----------------------------------------------------------
"http://google.com)" is not a valid URL. Because host/port can't contain ")" and path must start from "/" see http://www.ietf.org/rfc/rfc3986.txt Also I have a question, why you are using regular expression for this, I don't think that it is easy to write such regexp. Why you don't just split by "[\t\n ]" and validate URL using qt/kde method? (I think qt/kde must have such) But if there is no such, here is a good example of regexp for URL's - http://stackoverflow.com/a/190405 Also see note about "u" modifier. - Azat Khuzhin On March 2, 2013, 10:39 p.m., Jaydeep Solanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108614/ > ----------------------------------------------------------- > > (Updated March 2, 2013, 10:39 p.m.) > > > Review request for Okular. > > > Description > ------- > > When selected text is right clicked, it checks for a url, if found, a QAction > is added to open the url in the default browser. > > pdf with links update : http://goo.gl/wBM6p > > > This addresses bug 281027. > http://bugs.kde.org/show_bug.cgi?id=281027 > > > Diffs > ----- > > ui/pageview.cpp b018dfe > > Diff: http://git.reviewboard.kde.org/r/108614/diff/ > > > Testing > ------- > > just check if the icon appears properly, because I have an issue with the > icon. > > > Thanks, > > Jaydeep Solanki > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
