> On Feb. 19, 2013, 9:51 p.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 300 > > <http://git.reviewboard.kde.org/r/109021/diff/1/?file=114383#file114383line300> > > > > This is not strictly true, it also applies for epub, fictiobook, > > mobipocket and any other future backend that uses TextDocumentGenerator. > > > > I think it may make more sense if you add it in the "backend specific" > > configuration pages in addPages() like the spectre backend does. > > > > The naming still needs to be good, not sure i can think of one now. > > Anyone has ideas? > > Azat Khuzhin wrote: > Yes we could write "Defines font for text based documents." or something > like this. > > As for addPages() in which window it adds options? > > Also I'm not sure about this, because the text also can be extracted from > PDF and use the same font for rendering. No?
Sorry for the delay, forgot to publish - Azat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109021/#review27753 ----------------------------------------------------------- On Feb. 19, 2013, 9:41 p.m., Azat Khuzhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109021/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 9:41 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Description > ------- > > Development history: > https://github.com/azat/okular/compare/master...font-selector-for-plain-text-formats > > Link to thread from mailing list: > http://comments.gmane.org/gmane.comp.kde.devel.okular/13279 > > > Diffs > ----- > > conf/dlggeneralbase.ui f2c9efd > conf/okular_core.kcfg 054b5c1 > core/textdocumentgenerator.h dd75c5c > core/textdocumentgenerator.cpp f370ded > core/textdocumentgenerator_p.h 749d6f2 > > Diff: http://git.reviewboard.kde.org/r/109021/diff/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Azat Khuzhin > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
