core/document.cpp (line 4029)
<https://git.reviewboard.kde.org/r/128507/#comment65858>
This won't work with remote URLs, I think
`KIO::upUrl(d->m_url).resolved(url)` should do the same as the kdelibs4 code
- Alex Richardson
On July 2
should just remove
the strict mode, I have no idea why I added that.
- Alex Richardson
On Feb. 11, 2016, 7:50 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit 1b2de0d1d074769005db01b8de47e26c7e310057 by Albert Astals
Cid on behalf of Alex Richardson to branch frameworks.
Repository: okular
Description
---
---
Try fixing mainshelltest
. (And having the test
passing on the CI)
- Alex Richardson
On Jan. 4, 2016, 3:18 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
minimum
Qt version?
- Alex Richardson
On Jan. 22, 2016, 12:31 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
sting
---
mainshelltest now passes and documents are opened where I last viewed them
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 2f9246ae42ce6276002641ac02d9c6b880bcf7a3 by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
Two commits:
---
Port to new JSON plugin loading system
This means Okular can now
/7153/
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review89570
---
On Dec. 14, 2015, 11:59 a.m., Alex R
g/r/126378/#comment61352>
`#if HAVE_KACTIVITIES` would be nicer and then KActivities could just be
turned into an optional dependency which wouldn't be found on Windows?
I prefer having ifdefs based on available features rather than hardcoded on
the OS
- Alex Richardson
tSaveFileUrl() and use KIO instead of QFile to save it?
- Alex Richardson
On Dec. 16, 2015, 12:41 a.m., Patrick Spendrin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
last viewed them
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
pened where I last viewed them
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
he offending calls to
> > setActiveTab are fixed instead of just workarounding them
Seems like it has been fixed by my other changes.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.revi
works
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review89466
---
On Dec. 14, 2015, 11:46 a.m., Alex Richardson wrote:
>
> ---
3a3a86848a9b147c5b1f31beb15e120d622a4ea0
ui/videowidget.h 64fc6d76ee71d10bbabe58d847d72d13d89468e0
ui/videowidget.cpp e095a33c5b08144c67c1312650e15688f59bb85e
Diff: https://git.reviewboard.kde.org/r/126193/diff/
Testing
---
unit tests still pass, opening files works
Thanks,
Alex Richardson
're
> > losing functionality and it's not a required change, no?
>
> Alex Richardson wrote:
> They are no longer used in KF5 (K_EXPORT_PLUGIN is a noop) and the
> information there is in the JSON file now
>
> Albert Astals Cid wrote:
> Where losing th
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88977
-------
On Nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated
https://git.reviewboard.kde.org/r/126192/diff/
Testing
---
mainshelltest now passes and documents are opened where I last viewed them
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/o
reply, visit:
https://git.reviewboard.kde.org/r/126193/#review88927
---
On Nov. 28, 2015, 7:28 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-ma
generators/chm/CMakeLists.txt e54affca31ba18e0a0be894897a7c490a0d093c3
generators/chm/generator_chm.cpp fbdcea8e9dbf7a21a72ad6b5c9d2f7724f7c6330
Diff: https://git.reviewboard.kde.org/r/126193/diff/
Testing
---
unit tests still pass, opening files works
Thanks,
Alex Richardson
n.cpp fdee69458baa0b111be9613e844834b7069fca00
Diff: https://git.reviewboard.kde.org/r/126192/diff/
Testing
---
mainshelltest now passes and documents are opened where I last viewed them
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
ine20>
> >
> > s/requestion/requested/
I copied the documentation from FindWayland.cmake, fixed it there too.
On Nov. 27, 2015, 9:47 p.m., Alex Richardson wrote:
> > If you could give us the Okular diff as Albert requested, that would be
> > good, too.
Patch to ok
es in the okular CMakeLists.txt
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
marked as submitted.
Review request for Okular, Albert Astals Cid and Laurent Montel.
Changes
---
Submitted with commit ab700b245355a2d42f7fcea1e62923fb2e65b880 by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
This fixes shelltest
Diffs
------
On Aug. 26, 2015, 8:09 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124738/
> ---
those are the desired
semantics?
- Alex Richardson
On Aug. 14, 2015, 4:56 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
https://git.reviewboard.kde.org/r/124731/diff/
Testing
---
kimageiotest passes again with qt 5.4.1
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
---
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
hanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit ed352a06fb918f778e022e6c17d919921f204707 by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
---
Install Okular5Config.cmake instead of
ard.kde.org/r/124381/#review82622
---
On July 18, 2015, 4:34 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
Diff: https://git.reviewboard.kde.org/r/124381/diff/
Testing
---
Patched Kile to use find_package(Okular5), everything seems to work
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/o
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit c2fc0199b8f7cf1f0a4bfee0568fa68ec8d1d6ab by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
This seems to be required with KPluginFactory and Qt5 since
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit c2fc0199b8f7cf1f0a4bfee0568fa68ec8d1d6ab by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
This seems to be required with KPluginFactory and Qt5 since
y, visit:
https://git.reviewboard.kde.org/r/123466/#review79822
---
On April 22, 2015, 2:09 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail.
af8d3373afc2aa8d4d6bd407ab0f3b5b94e07bf6
Diff: https://git.reviewboard.kde.org/r/123466/diff/
Testing
---
Loading didn't work before, does not. Requires a full rebuild.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/ma
---
Loading didn't work before, does not. Requires a full rebuild.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit dcf4d93abb79b3f8c38f32a4d1e32e672e2dff4c by Alex
Richardson to branch frameworks.
Repository: okular
Description
---
Fix the export header not being found in interfaces/*.h
Diffs
at "if it worked before it
> > should work now" without any change.
>
> Alex Richardson wrote:
> I think this is all related to the use of generate_export_header() and
> the fact that previously consumers would
> `include_directories(${INCLUDE_DIR}/okular/core
&g
at "if it worked before it
> > should work now" without any change.
>
> Alex Richardson wrote:
> I think this is all related to the use of generate_export_header() and
> the fact that previously consumers would
> `include_directories(${INCLUDE_DIR}/okular/core
&g
it:
https://git.reviewboard.kde.org/r/123363/#review79148
---
On April 16, 2015, 12:55 a.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e
://git.reviewboard.kde.org/r/123363/diff/
Testing (updated)
---
Kile compiles now.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
--
On April 14, 2015, 8:33 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123363/
> ---
> On April 14, 2015, 9:34 p.m., Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
>
> Eugene Shalygin wrote:
> I can't. My changes to test Kile are the following:
> http://pastebin.com/HMv9Ziku. And GCC says:
>
>
ip it
- Alex Richardson
On April 14, 2015, 8:48 p.m., Andreas Cord-Landwehr wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
460d33eb4e25e09e89a11bbbd126a5d610472f7d
interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6
interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44
Diff: https://git.reviewboard.kde.org/r/123363/diff/
Testing
---
Thanks,
Alex Richardson
gt; > you seen its INTERFACE_LINK_LIBRARIES property?
> > KF5::Archive;KF5::JS;KF5::JSApi;KF5::KDELibs4Support;KF5::KIOCore;KF5::ThreadWeaver;KF5::Wallet;Phonon::phonon4qt5;m;/usr/lib64/libz.so.
> > Are all of them indeed needed just to link with Okular?
> >
> > So, wh
cy(KF5Config @KF5_REQUIRED_VERSION@)
find_dependency(KF5XmlGui @KF5_REQUIRED_VERSION@)
```
- Alex Richardson
On April 10, 2015, 5:14 p.m., Andreas Cord-Landwehr wrote:
>
> ---
> This is an automatically generated e-mail. To
.kde.org/r/123314/
> ---
>
> (Updated April 10, 2015, 5:14 p.m.)
>
>
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene
> Shalygin.
>
>
> Repository: okular
>
>
> Descri
@?
You might have to pass `PATH_VARS CMAKE_INSTALL_LIBDIR` to
`ecm_configure_package_config_file`.
I'm not 100% sure that works but I think that's what I did when I had a similar
problem
- Alex Richardson
On March 29, 2015, 2:40 p.m., Andreas Cord-Land
51 matches
Mail list logo
