----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123314/#review78939 -----------------------------------------------------------
Ship it! With this I can build Kile, so I'd say Ship it - Alex Richardson On April 14, 2015, 8:48 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123314/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 8:48 p.m.) > > > Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene > Shalygin. > > > Repository: okular > > > Description > ------- > > Replace both the package version file by a generated file, as well as > OkularConfig.cmake package configuration file. > Note that with this change the compatibility CMake variable OKULAR_FOUND is > not set anymore, use Okular_FOUND instead. > > This patch (should) fix the regression on eg. Gentoo systems introduced by RR > #123176 > > > Diffs > ----- > > CMakeLists.txt 56c9976 > OkularConfig.cmake 171b845 > OkularConfig.cmake.in PRE-CREATION > core/version.h 855df95 > > Diff: https://git.reviewboard.kde.org/r/123314/diff/ > > > Testing > ------- > > Manual testing on a Debian system > > @Eugene: does it fix the regression for you? > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
