----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/ -----------------------------------------------------------
Review request for Extra Cmake Modules, Okular, Albert Astals Cid, and Tobias Koenig. Repository: extra-cmake-modules Description ------- At least Okular and KBibTex include a FindPoppler.cmake module but this one uses the new ECMFindModuleHelpers and has imported targets. --- To make FindPoppler.cmake work without pkg-config it also includes this commit: Use PATH_SUFFIXES in ecm_find_package_handle_library_components() This is required to find poppler without package config as all the headers are installed in a poppler subdirectory of the include directory Diffs ----- find-modules/FindPoppler.cmake PRE-CREATION modules/ECMFindModuleHelpers.cmake 2044efe1ccf679b738f68aec9b3fb007c449717c Diff: https://git.reviewboard.kde.org/r/126183/diff/ Testing ------- Okular can be built using this find module with minor changes. As it doesn't set various HAVE_POPPLER_0_36 etc. variables that the find module in okular did, I set those variables in the okular CMakeLists.txt Thanks, Alex Richardson
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
