Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Saheb Preet Singh
> On Jan. 12, 2014, 5:28 p.m., Albert Astals Cid wrote: > > Ok, this looks good, i'll commit it. Note the spacing is totally wrong and > > i'll fix it before committing, please in the future make sure that patches > > conform to the spacing styling used in the file you are editing. ok i will t

[Okular-devel] Please test the pdf inverse/foward search with the new DPI patch

2014-01-12 Thread Albert Astals Cid
Please if some of the people that know how to use the inverse/foward search for PDF and latex could try the new patch we just commited to master (you'll need to have libkscreen installed) could make sure it still works that would be great. >From looking at the code "it should still work", but y

[Okular-devel] Jenkins build is back to stable : okular_master #384

2014-01-12 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build is still unstable: okular_master #383

2014-01-12 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 268757] [Patch] Constant DPI in PDF backend results in incorrect size of pages on screen

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=268757 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In|

[Okular-devel] Jenkins build became unstable: okular_master #382

2014-01-12 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2014-01-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/#review47283 --- I did some small changes on my own so we did not have to go ba

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2014-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/#review47282 --- This review has been submitted with commit ed3559462759bf9b94

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2014-01-12 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111829/ --- (Updated Jan. 13, 2014, 12:39 a.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/ --- (Updated Jan. 13, 2014, 12:24 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 111829: Use DPI of current screen for PDF rendering

2014-01-12 Thread Albert Astals Cid
> On Oct. 1, 2013, 9:37 p.m., Albert Astals Cid wrote: > > core/utils.cpp, line 116 > > > > > > Hmmm, my libkscreen does not have sizeMm, what libkscreen version are > > you using? > > Eugene Shalygin wrote: >

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Albert Astals Cid
> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Jonathan Doman
> On Jan. 12, 2014, 9:57 p.m., Albert Astals Cid wrote: > > shell/shell.cpp, line 181 > > > > > > This check seems a bit weird, i don't even think you need it, but if > > you want one check there shouldn't you b

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review47271 --- shell/shell.cpp

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling "pdftocairo"

2014-01-12 Thread Albert Astals Cid
> On Oct. 14, 2013, 10:33 p.m., Albert Astals Cid wrote: > > generators/poppler/generator_pdf.cpp, line 1538 > > > > > > This needs to be made async, this will potentiall freeze the UI for a > > while depending

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling "pdftocairo"

2014-01-12 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111410/ --- (Updated Jan. 12, 2014, 10:46 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 111410: Selection tool: copy/extract as vector graphic by calling "pdftocairo"

2014-01-12 Thread Thomas Fischer
> On Oct. 15, 2013, 12:33 a.m., Albert Astals Cid wrote: > > generators/poppler/generator_pdf.cpp, line 1538 > > > > > > This needs to be made async, this will potentiall freeze the UI for a > > while depending

[Okular-devel] [okular] [Bug 329880] Previous/Next Page buttons on Page Number toolbar action do not have correct icon sizes

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329880 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In|

[Okular-devel] [okular] [Bug 329881] Okular crashed opening the print dialogue

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329881 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

[Okular-devel] [okular] [Bug 329807] text selection gets confused in two columns document that has graphics

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329807 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 329881] Okular crashed opening the print dialogue

2014-01-12 Thread idoitprone
https://bugs.kde.org/show_bug.cgi?id=329881 --- Comment #1 from idoitprone --- The print dialogue seems to freeze konqueror too. It kinda crash but it froze so it didnt print out a stack trace. Strangely enough, gimp and firefox print dialogue works fine -- You are receiving this mail becaus

[Okular-devel] [okular] [Bug 329807] text selection gets confused in two columns document that has graphics

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329807 Albert Astals Cid changed: What|Removed |Added Summary|two-column highlighting |text selection gets |

[Okular-devel] [okular] [Bug 329562] Okular crashed when printing custom size

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329562 Albert Astals Cid changed: What|Removed |Added Latest Commit|http://commits.kde.org/okul |http://commits.kde.org/okul

[Okular-devel] [okular] [Bug 329562] Okular crashed when printing custom size

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329562 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Okular-devel] [okular] [Bug 329881] New: Okular crashed opening the print dialogue

2014-01-12 Thread idoitprone
https://bugs.kde.org/show_bug.cgi?id=329881 Bug ID: 329881 Summary: Okular crashed opening the print dialogue Classification: Unclassified Product: okular Version: 0.17.5 Platform: Fedora RPMs OS: Linux Status:

[Okular-devel] Jenkins build is back to stable : okular_master #377

2014-01-12 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build became unstable: okular_master #376

2014-01-12 Thread KDE CI System
See ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review47261 --- This review has been submitted with commit c80c59b0618d4257d0

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 5:29 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review47260 --- Ok, this looks good, i'll commit it. Note the spacing is total

[Okular-devel] [okular] [Bug 329880] New: Previous/Next Page buttons on Page Number toolbar action do not have correct icon sizes

2014-01-12 Thread Franz Berger
https://bugs.kde.org/show_bug.cgi?id=329880 Bug ID: 329880 Summary: Previous/Next Page buttons on Page Number toolbar action do not have correct icon sizes Classification: Unclassified Product: okular Version: 0.18.0 Pl

[Okular-devel] [okular] [Bug 329863] Untranslatable string when I use 'Save as...' to save a PDF file with annotations

2014-01-12 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=329863 Yuri Chornoivan changed: What|Removed |Added Latest Commit|http://commits.kde.org/okul |http://commits.kde.org/okul

[Okular-devel] [okular] [Bug 329863] Untranslatable string when I use 'Save as...' to save a PDF file with annotations

2014-01-12 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=329863 Yuri Chornoivan changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[Okular-devel] [okular] [Bug 329863] Untranslatable string when I use 'Save as...' to save a PDF file with annotations

2014-01-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=329863 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

[Okular-devel] [okular] [Bug 329562] Okular crashed when printing custom size

2014-01-12 Thread mnd999
https://bugs.kde.org/show_bug.cgi?id=329562 --- Comment #5 from mnd...@gmail.com --- Sent PDF to Albert Astals Cid On 4 January 2014 21:56, Albert Astals Cid wrote: > https://bugs.kde.org/show_bug.cgi?id=329562 > > Albert Astals Cid changed: > >What|Removed

[Okular-devel] [okular] [Bug 329807] two-column highlighting

2014-01-12 Thread roberto.bernetti
https://bugs.kde.org/show_bug.cgi?id=329807 --- Comment #7 from roberto.berne...@poste.it --- What I mean is that if you would to highlight some rows on the left column only (one sentence for example) and you drag the tool for more than one row you get selected the rows but on both columns, the

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Saheb Preet Singh
> On Jan. 11, 2014, 3:03 p.m., Albert Astals Cid wrote: > > ui/searchlineedit.cpp, line 194 > > > > > > I was wondering if we should use == here instead of &, i.e. should > > Ctrol+Shift+Enter do a prev or next

Re: [Okular-devel] Review Request 114754: implemented a shortcut for searching the previous word using a key event listener

2014-01-12 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/ --- (Updated Jan. 12, 2014, 12:30 p.m.) Review request for Okular, Albert Ast

[Okular-devel] [okular] [Bug 329863] Untranslatable string when I use 'Save as...' to save a PDF file with annotations

2014-01-12 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=329863 --- Comment #1 from Yuri Chornoivan --- Created attachment 84593 --> https://bugs.kde.org/attachment.cgi?id=84593&action=edit A patch to add i18n() call in git/master -- You are receiving this mail because: You are the assignee for the bug.