> On Jan. 12, 2014, 5:28 p.m., Albert Astals Cid wrote: > > Ok, this looks good, i'll commit it. Note the spacing is totally wrong and > > i'll fix it before committing, please in the future make sure that patches > > conform to the spacing styling used in the file you are editing.
ok i will take care of the spacing in future. Thanks for guiding me - Saheb ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114754/#review47260 ----------------------------------------------------------- On Jan. 12, 2014, 5:29 p.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114754/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2014, 5:29 p.m.) > > > Review request for Okular, Albert Astals Cid and Kevin Funk. > > > Bugs: 328576 > http://bugs.kde.org/show_bug.cgi?id=328576 > > > Repository: okular > > > Description > ------- > > > okular do not have a shortcut for searching previous word using shift + enter > > > Added a key event listener to the SearchLineEdit class for shift+return. > > > Diffs > ----- > > ui/searchlineedit.cpp 31be8fb > > Diff: https://git.reviewboard.kde.org/r/114754/diff/ > > > Testing > ------- > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
