----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111410/ -----------------------------------------------------------
(Updated Jan. 12, 2014, 10:46 p.m.) Review request for Okular. Changes ------- New patch, addresses the comments up to the introduction of KJob as a return value for exportPageRangeTo and exportSinglePageRegionTo. The code compiles, but linking fails with some cryptic vtable error. Repository: okular Description ------- This patch implements the feature request of bug 321350: if a PDF file is viewed, the selection tool offers the new extraction method "vector" which allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is performed by calling "pdftocairo" with matching arguments. The resulting file contains the original PDF file's content without rendering it to a pixmap. I am not sure if calling an external program is an acceptable solution for this problem. However, it is tested if the program is available before showing the new option. Alternatively, the code of pdftocairo (as part of poppler) would had to be copied and integrated into Okular increasing the solution's complexity. I am not aware of a similar solution available using poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an alternative, but again this seemed to be too complex. Diffs (updated) ----- core/document.h fe296e0 core/document.cpp fa6345f core/generator.h 3cf40c2 core/generator.cpp 41beb92 generators/poppler/generator_pdf.h 5d5853a generators/poppler/generator_pdf.cpp 839a324 ui/minibar.h 5654ad8 ui/minibar.cpp 6a501b8 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/111410/diff/ Testing ------- Thanks, Thomas Fischer
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
