Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Tvrtko Ursulin
On 22/04/2025 15:52, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 04:16:48PM +0200, Philipp Stanner wrote: On Tue, 2025-04-22 at 16:08 +0200, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 02:39:21PM +0100, Tvrtko Ursulin wrote: Sorry I don't see the argument for the claim it is relyin

Announcement: 2025 X.Org Foundation Election Candidates

2025-04-23 Thread Mark Filion
To all X.Org Foundation Members: The election for the X.Org Foundation Board of Directors will begin on 30 April 2025. We have five candidates who are running for four seats. They are (in alphabetical order): * Andres Gomez * Arkadiusz Hiler * Megan Knight * Lyude Paul * Harry Wentland Atta

Re: [PATCH 0/6] Additional documentation for nova-core

2025-04-23 Thread Alexandre Courbot
Thanks a lot for doing this, this was severely missing from the WPR2 patchset. Due to the strong focus on documentation, and in order to ease merging, I think it makes sense to keep this separate from the WPR2 patchset and merge it on top of it. Danilo, would that work for you? On Thu Apr 24, 202

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Tvrtko Ursulin
On 23/04/2025 09:48, Danilo Krummrich wrote: On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: IMO it is better to leave it. Regardless of whether it was added because some driver is actually operating like that, it does describe a _currently_ workable option to avoid memory lea

Re: [PATCH 09/16] gpu: nova-core: register sysmem flush page

2025-04-23 Thread Alexandre Courbot
On Tue Apr 22, 2025 at 8:45 PM JST, Danilo Krummrich wrote: > On Sun, Apr 20, 2025 at 09:19:41PM +0900, Alexandre Courbot wrote: >> A page of system memory is reserved so sysmembar can perform a read on >> it if a system write occurred since the last flush. Do this early as it >> can be required to

Re: [PATCH v2 1/2] drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill()

2025-04-23 Thread Danilo Krummrich
On Tue, Apr 15, 2025 at 02:19:00PM +0200, Philipp Stanner wrote: > Nouveau is mostly designed in a way that it's expected that fences only > ever get signaled through nouveau_fence_signal(). However, in at least > one other place, nouveau_fence_done(), can signal fences, too. If that > happens (rac

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 11:10:51AM +0100, Tvrtko Ursulin wrote: > > On 23/04/2025 09:48, Danilo Krummrich wrote: > > On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > > > > > IMO it is better to leave it. Regardless of whether it was added because > > > some driver is actually o

Re: [PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations

2025-04-23 Thread Danilo Krummrich
On Tue, Apr 15, 2025 at 02:19:01PM +0200, Philipp Stanner wrote: > nouveau_fence.c iterates over lists in a non-canonical way. Since the > operations done are just basic for-each-loops, they should be written in > the standard form. > > Use for_each_safe() instead of the custom loop iterations. P

Re: [PATCH v2][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 16, 2025 at 12:00:42PM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions > of a flexible structure where the size of the f

Re: [PATCH][next] drm/nouveau: disp: Use __member_size() helper

2025-04-23 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 09:44:56AM -0600, Gustavo A. R. Silva wrote: > Use __member_size() to get the size of the flex-array member at compile > time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` > > Signed-off-by: Gustavo A. R. Silva Applied to drm-misc-next, thanks!

Re: [PATCH][next] drm/nouveau: outp: Use __member_size() helper

2025-04-23 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 09:45:39AM -0600, Gustavo A. R. Silva wrote: > Use __member_size() to get the size of the flex-array member at compile > time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` > > Signed-off-by: Gustavo A. R. Silva Applied to drm-misc-next, thanks!

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > Hello, Danilo, > Thanks for all the feedback. Due to the volume of feedback, I will respond > incrementally in multiple emails so we can discuss as we go - hope that's Ok > but > let me know if that is annoying. That's perfectly fi

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-23 Thread Danilo Krummrich
On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote: > From: Joel Fernandes > > Add support for navigating and setting up vBIOS ucode data required for > GSP to boot. The main data extracted from the vBIOS is the FWSEC-FRTS > firmware which runs on the GSP processor. This firmware r

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > IMO it is better to leave it. Regardless of whether it was added because > some driver is actually operating like that, it does describe a _currently_ > workable option to avoid memory leaks. Once a better method is there, ie. > F

Re: [PATCH 5/6] gpu: nova-core: Clarify fields in FalconAppifHdrV1

2025-04-23 Thread Alexandre Courbot
Since this just renames fields, would you be ok if I squashed this one into the relevant patch of my series, alongside a [joelagn...@nvidia.com: give better names to FalconAppifHdrV1's fields] ? On Thu Apr 24, 2025 at 7:54 AM JST, Joel Fernandes wrote: > Signed-off-by: Joel Fernandes > --- > d

Re: [PATCH 3/6] nova-core: docs: Document vbios layout

2025-04-23 Thread Timur Tabi
On Wed, 2025-04-23 at 18:53 -0400, Joel Fernandes wrote: > +This document describes the layout of the VBIOS image which is a series of > concatenated > +images in the ROM of the GPU. The VBIOS is mirrored onto the BAR 0 space and > is read > +by both Boot ROM firmware (also known as IFR or init-f