Thanks a lot for doing this, this was severely missing from the WPR2 patchset.
Due to the strong focus on documentation, and in order to ease merging, I think it makes sense to keep this separate from the WPR2 patchset and merge it on top of it. Danilo, would that work for you? On Thu Apr 24, 2025 at 7:53 AM JST, Joel Fernandes wrote: > Hello, > Please find in this series, several clarifications, diagrams and code comments > for various things in the nova-core driver. These are essential to develop an > understanding how nova-core's boot initialization works and aid in > development. > > These patches are on top of Alex's last posting for GSP WPR2 [1] > > [1] > https://lore.kernel.org/all/20250420-nova-frts-v1-0-ecd1cca23...@nvidia.com/ > > Joel Fernandes (6): > nova-core: doc: Add code comments related to devinit > nova-core: doc: Clarify sysmembar operations > nova-core: docs: Document vbios layout > nova-core: docs: Document fwsec operation and layout > gpu: nova-core: Clarify fields in FalconAppifHdrV1 > nova-core: docs: Document devinit process > > Documentation/gpu/nova/core/devinit.rst | 54 ++++++++ > Documentation/gpu/nova/core/fwsec.rst | 173 ++++++++++++++++++++++++ > Documentation/gpu/nova/core/vbios.rst | 155 +++++++++++++++++++++ > Documentation/gpu/nova/index.rst | 2 + > drivers/gpu/nova-core/devinit.rs | 36 ++++- > drivers/gpu/nova-core/firmware/fwsec.rs | 17 ++- > drivers/gpu/nova-core/gpu.rs | 11 +- > drivers/gpu/nova-core/regs.rs | 17 ++- > 8 files changed, 452 insertions(+), 13 deletions(-) > create mode 100644 Documentation/gpu/nova/core/devinit.rst > create mode 100644 Documentation/gpu/nova/core/fwsec.rst > create mode 100644 Documentation/gpu/nova/core/vbios.rst
