On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > IMO it is better to leave it. Regardless of whether it was added because > some driver is actually operating like that, it does describe a _currently_ > workable option to avoid memory leaks. Once a better method is there, ie. > FIXME is addressed, then it can be removed or replaced.
I'm not willing to sign off on encouraging drivers to rely on scheduler internals -- also not in this case, sorry. Our primary goal with the scheduler is to *remove* such broken contracts where drivers rely on scheduler internal implementation details, mess with scheduler internal data structures etc. This is clearly a step back. And AFAICT, as by now drivers either do a) or simply nothing (with the exception of the mock scheduler). Drivers can do a) in the meantime, there's no reason at all to additionally offer b).
