[PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin opened a new pull request, #1027: URL: https://github.com/apache/incubator-pekko/pull/1027 Motivation: There is an additional `new AtomicReference[Option[T]](None)` usage, by introduce a `PekkoManagedBlocker` , this reduced it. -- This is an automated message from the Apache Git

Re: [PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #1027: URL: https://github.com/apache/incubator-pekko/pull/1027#discussion_r1462935547 ## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ## @@ -173,19 +173,23 @@ object MonitorableThreadFactory { val doNothing: Thread.Un

Re: [PR] [pekko-streams] feat: add Sink.forall [incubator-pekko]

2024-01-23 Thread via GitHub
laglangyue commented on PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#issuecomment-1905614739 This PR has been delayed for a week, and my father passed away due to cancer. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] add advice on how to run tests [incubator-pekko-connectors]

2024-01-23 Thread via GitHub
pjfanning merged PR #322: URL: https://github.com/apache/incubator-pekko-connectors/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] pekko-http2-support is part of pekko-http-core [incubator-pekko-http]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #437: URL: https://github.com/apache/incubator-pekko-http/pull/437 In older versions of Akka, there was a separate jar. This comment makes no sense in Pekko. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] fix bug in http2 config names [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #7: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/7 see #6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Fix wrong config in example [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning commented on issue #6: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/issues/6#issuecomment-1905660418 thanks - I've raised https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/7 -- This is an automated message from the Apache Git Ser

Re: [D] enable http2 support by default in pekko-http 1.1.0? [incubator-pekko-http]

2024-01-23 Thread via GitHub
GitHub user pjfanning edited a discussion: enable http2 support by default in pekko-http 1.1.0? currently disabled by default - see https://github.com/apache/incubator-pekko-http/blob/e11260fa02120247016fe385d1e898677e4f3432/http-core/src/main/resources/reference.conf#L31 GitHub link: https:/

Re: [PR] chore: clarify the JMH Readme [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #1025: URL: https://github.com/apache/incubator-pekko/pull/1025#discussion_r1463007866 ## bench-jmh/README.md: ## @@ -4,12 +4,22 @@ This subproject contains some microbenchmarks excercising key parts of Apache Pe own jmh module) -You can run

Re: [D] enable http2 support by default in pekko-http 1.1.0? [incubator-pekko-http]

2024-01-23 Thread via GitHub
GitHub user jrudolph added a comment to the discussion: enable http2 support by default in pekko-http 1.1.0? It's not "preview" or "experimental" any more, but enabling it changes the runtime behavior significantly and people might not want to accidentally use it in usual deployments. There'

Re: [PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning commented on code in PR #1027: URL: https://github.com/apache/incubator-pekko/pull/1027#discussion_r1463011306 ## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ## @@ -173,19 +173,23 @@ object MonitorableThreadFactory { val doNothing: Thread

Re: [PR] pekko-http2-support is part of pekko-http-core [incubator-pekko-http]

2024-01-23 Thread via GitHub
pjfanning merged PR #437: URL: https://github.com/apache/incubator-pekko-http/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [I] Fix wrong config in example [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
Touutae-lab closed issue #6: Fix wrong config in example URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/issues/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] pekko-http2-support is part of pekko-http-core (#437) [incubator-pekko-http]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #439: URL: https://github.com/apache/incubator-pekko-http/pull/439 cherry pick 0dcc3466115d659d6a79330536e52cfbd53565d6 #437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #1027: URL: https://github.com/apache/incubator-pekko/pull/1027#discussion_r1463031013 ## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ## @@ -173,19 +173,23 @@ object MonitorableThreadFactory { val doNothing: Thread.Un

Re: [PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning commented on code in PR #1027: URL: https://github.com/apache/incubator-pekko/pull/1027#discussion_r1463033945 ## actor/src/main/scala/org/apache/pekko/dispatch/ThreadPoolBuilder.scala: ## @@ -173,19 +173,23 @@ object MonitorableThreadFactory { val doNothing: Thread

Re: [PR] pekko-http2-support is part of pekko-http-core (#437) [incubator-pekko-http]

2024-01-23 Thread via GitHub
pjfanning merged PR #439: URL: https://github.com/apache/incubator-pekko-http/pull/439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [D] enable http2 support by default in pekko-http 1.1.0? [incubator-pekko-http]

2024-01-23 Thread via GitHub
GitHub user He-Pin added a comment to the discussion: enable http2 support by default in pekko-http 1.1.0? I'm not sure about this ,but I saw quarkus are optimizating http/2 supporting, so I would like it to be disabled by default, end users can turn on if they need it. https://github.com/q

Re: [PR] chore: clarify the JMH Readme [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #1025: URL: https://github.com/apache/incubator-pekko/pull/1025#discussion_r1463055893 ## bench-jmh/README.md: ## @@ -4,12 +4,22 @@ This subproject contains some microbenchmarks excercising key parts of Apache Pe own jmh module) -You can run

[PR] Resolves #1017 [incubator-pekko]

2024-01-23 Thread via GitHub
HapppyLiu opened a new pull request, #1028: URL: https://github.com/apache/incubator-pekko/pull/1028 Add JDK21 info to doc #1017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] chore: Temporarily disable the license report generation to speed up build [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #704: URL: https://github.com/apache/incubator-pekko/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] Resolves #1017 [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning merged PR #1028: URL: https://github.com/apache/incubator-pekko/pull/1028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[PR] Add JDK21 info to doc #1017 (#1028) [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #1029: URL: https://github.com/apache/incubator-pekko/pull/1029 cherry pick dc1fc69255dafd0da67a0554fa5dbd98fcb9a4dd #1028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] chore: Remove unused attributes in Stages. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #991: URL: https://github.com/apache/incubator-pekko/pull/991#issuecomment-1905935525 I think they added these because they plan to implement these:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] chore: Remove unused attributes in Stages. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #991: URL: https://github.com/apache/incubator-pekko/pull/991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin opened a new pull request, #1030: URL: https://github.com/apache/incubator-pekko/pull/1030 Motivation: Add these files so they are not been formatted when run `sbt javafmtAll`. Result: There files are ignored. -- This is an automated message from the Apache Git Service.

Re: [PR] chore: clarify the JMH Readme [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #1025: URL: https://github.com/apache/incubator-pekko/pull/1025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] fix bug in http2 config names [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #7: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/7#discussion_r1463252696 ## src/main/g8/src/main/scala/com/example/helloworld/GreeterServer.scala: ## @@ -37,7 +37,7 @@ object GreeterServer { def main(args: Arr

Re: [I] [DOC] Style Guide document render issue [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on issue #975: URL: https://github.com/apache/incubator-pekko/issues/975#issuecomment-1906023106 The good news is I managed to replicate this with the original paradox, that's meaning we narrowed the bug scope. I will continue https://github.com/apache/incubator-pe

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#issuecomment-1906026753 This should be backport to 1.0.x too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add JDK21 info to doc #1017 (#1028) [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #1029: URL: https://github.com/apache/incubator-pekko/pull/1029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [I] Add JDK21 info to doc [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin closed issue #1017: Add JDK21 info to doc URL: https://github.com/apache/incubator-pekko/issues/1017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Add JDK21 info to doc [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on issue #1017: URL: https://github.com/apache/incubator-pekko/issues/1017#issuecomment-1906059534 @HapppyLiu thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] fix bug in http2 config names [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning commented on code in PR #7: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/7#discussion_r1463288485 ## src/main/g8/src/main/scala/com/example/helloworld/GreeterServer.scala: ## @@ -37,7 +37,7 @@ object GreeterServer { def main(args:

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463289891 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Clas

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463289891 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Clas

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463293962 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Cl

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463296763 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Class

Re: [PR] fix bug in http2 config names [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning merged PR #7: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

Re: [I] investigate failure of maven test in CI build [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning closed issue #5: investigate failure of maven test in CI build URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/issues/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] investigate failure of maven test in CI build [incubator-pekko-grpc-quickstart-scala.g8]

2024-01-23 Thread via GitHub
pjfanning commented on issue #5: URL: https://github.com/apache/incubator-pekko-grpc-quickstart-scala.g8/issues/5#issuecomment-1906091293 fixed in #7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463336686 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Clas

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463351485 ## actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java: ## @@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite { @Class

Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #1030: URL: https://github.com/apache/incubator-pekko/pull/1030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] chore: Add PekkoManagedBlocker to reduce memory. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin merged PR #1027: URL: https://github.com/apache/incubator-pekko/pull/1027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] chore: Make use of pattern matching on singleton type instead. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #1026: URL: https://github.com/apache/incubator-pekko/pull/1026#issuecomment-1906198894 ``` [info] REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on [info] why the numbers are the way they are. Use profilers (see -prof

Re: [PR] chore: Make use of pattern matching on singleton type instead. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #1026: URL: https://github.com/apache/incubator-pekko/pull/1026#issuecomment-1906206887 @mdedetrich @pjfanning ping, what's your option on this, I tested seems the performance is the same as my previous commit. -- This is an automated message from the Apache Git Ser

Re: [I] `sbt-license-report` took so much time to compile [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin closed issue #1019: `sbt-license-report` took so much time to compile URL: https://github.com/apache/incubator-pekko/issues/1019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user He-Pin added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry If it's closed source, you may have to send an request to MS... GitHub link: https://github.com/apache/incubator-pekko/discussions/1031#discussioncomment-8222675 This is an

Re: [D] Akka cluster libraries [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user taher-cldcvr closed a discussion: Akka cluster libraries Hi Where can i find akka-management-cluster-bootstrap akka-discovery-kubernetes-api akka-management-cluster-http akka-cluster-metrics akka-cluster-sharding All of these libraries I cannot find. Please help GitHub link: ht

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user pjfanning added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry It is my understanding that Lightbend have a paid-for solution. We can't open source software that has a non open source license. Approach your vendor and ask them for a solut

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user He-Pin added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry It's ai from MSFT, you could asked they form adopt pekko, that will help pekko too. GitHub link: https://github.com/apache/incubator-pekko/discussions/1031#discussioncomment-822

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user He-Pin edited a comment on the discussion: Using Pekko with Application Insights for logs and telemetry It's ai from MSFT, you could asked they from the support console to adopt pekko, that will help pekko too. GitHub link: https://github.com/apache/incubator-pekko/discussions/10

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user pjfanning added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry I still don't understand what the OP expects us to do about a commercial project - why don't they contact their commercial support? GitHub link: https://github.com/apache/inc

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user pjfanning added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry seems like a vert similar issue to the Dynatrace discussion - https://github.com/apache/incubator-pekko/discussions/505 GitHub link: https://github.com/apache/incubator-pekko

Re: [D] Using Pekko with Application Insights for logs and telemetry [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user He-Pin added a comment to the discussion: Using Pekko with Application Insights for logs and telemetry I think he may just not sure who provides that feature. But anyway, he/she is a maybe pekko user GitHub link: https://github.com/apache/incubator-pekko/discussions/1031#discus

[I] add support for building java21 code [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning opened a new issue, #1033: URL: https://github.com/apache/incubator-pekko/issues/1033 https://github.com/apache/incubator-pekko/pull/1023 added java 21 code to our docs. I don't believe that we have support for building this code to see if compiles. We have https://github.com/apa

Re: [I] add support for building java21 code [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on issue #1033: URL: https://github.com/apache/incubator-pekko/issues/1033#issuecomment-1906819224 I can do that on weekend, I was planning to open issue like this. And I think this is a good first issue too -- This is an automated message from the Apache Git Servi

[PR] [DRAFT] set Apache name in Pekko poms [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #1034: URL: https://github.com/apache/incubator-pekko/pull/1034 for https://github.com/apache/incubator-pekko/issues/1006 I'll generate more draft PRs but the build has been pretty brittle when I've tried changes. -- This is an automated message

Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning commented on PR #765: URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1906933410 I want to see this in 1.1.0-M1. It makes it easier for people to try it out. M1 is also a release that we can caveat. A 1.0.3 release would be expected to have well tested, workin

[PR] [DRAFT] try to centralise pom name change logic [incubator-pekko]

2024-01-23 Thread via GitHub
pjfanning opened a new pull request, #1035: URL: https://github.com/apache/incubator-pekko/pull/1035 This has been causing compile issues for me locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DRAFT] try to centralise pom name change logic [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on PR #1035: URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907089555 @pjfanning This can be fixed in a much nicer way, likely with a single line at https://github.com/mdedetrich/sbt-apache-sonatype -- This is an automated message from the Apac

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464117245 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._

Re: [PR] [DRAFT] set Apache name in Pekko poms [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on PR #1034: URL: https://github.com/apache/incubator-pekko/pull/1034#issuecomment-1907115232 > Due to the build brittleness, I want to try getting things working in 1 or 2 repos first before centralising a stable solution in sbt-pekko-build. The place to put this

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam commented on PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#issuecomment-1907254520 This PR hides the element when toc header link is not the current group, I have verified this on my laptop. But after PR #86 and #84, this plugin won't render the n

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam commented on PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#issuecomment-1907255406 cc @He-Pin @mdedetrich @pjfanning @samueleresca -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#discussion_r1464231473 ## theme/src/main/assets/assets/javascripts/groups.js: ## @@ -148,6 +148,41 @@ $(function() { }); }); + // Index Page toc + $(".to

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#discussion_r1464233702 ## theme/src/main/assets/assets/javascripts/groups.js: ## @@ -148,6 +148,41 @@ $(function() { }); }); + // Index Page toc + $(".t

Re: [I] Feature request: Add Flow#find operator. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin closed issue #976: Feature request: Add Flow#find operator. URL: https://github.com/apache/incubator-pekko/issues/976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Feature request: Add Flow#find operator. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on issue #976: URL: https://github.com/apache/incubator-pekko/issues/976#issuecomment-1907264398 This is a collectFirst now, let me close this, can be added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464236451 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._ ov

Re: [PR] [DRAFT] set Apache name in Pekko poms [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on PR #1034: URL: https://github.com/apache/incubator-pekko/pull/1034#issuecomment-1907268500 PR for sbt-pekko-build made at https://github.com/pjfanning/sbt-pekko-build/pull/7 . When I add the necessary functionality to sbt-apache-sonatype, I can just publish a new ver

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#discussion_r1464239124 ## theme/src/main/assets/assets/javascripts/groups.js: ## @@ -148,6 +148,41 @@ $(function() { }); }); + // Index Page toc + $(".to

Re: [PR] [DRAFT] set Apache name in Pekko poms [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #1034: URL: https://github.com/apache/incubator-pekko/pull/1034#issuecomment-1907271758 is there a demo of the result `pom.xml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] feat: +Flow.exists & Sink.exists [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #990: URL: https://github.com/apache/incubator-pekko/pull/990#issuecomment-1907275495 Friendly ping, we are scheduling a 1.1.0-M1 release soon, would you like to work on this this weekend, thanks. @GreyPlane -- This is an automated message from the Apache Git Servi

Re: [PR] [pekko-streams] feat: add Sink.forall [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#issuecomment-1907275881 Friendly ping, we are scheduling a 1.1.0-M1 release soon, would you like to work on this this weekend, thanks. @laglangyue And you can try to use the `foldWhile` now. -- This i

Re: [PR] [pekko-streams] feat: add Sink.forall [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on PR #989: URL: https://github.com/apache/incubator-pekko/pull/989#issuecomment-1907277142 @laglangyue oh my god, sad to hear that, take care. I can help with this, I will back home soon and do my surgical operation. -- This is an automated message from the Apache Gi

Re: [I] Feature request: Add `Flow/Sink#foldWhile` operator. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin closed issue #1010: Feature request: Add `Flow/Sink#foldWhile` operator. URL: https://github.com/apache/incubator-pekko/issues/1010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Feature request: Add Flow#switchMap operator. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on issue #974: URL: https://github.com/apache/incubator-pekko/issues/974#issuecomment-1907287627 Implementation this shold not be that hard but seems no much interest, will defer to later version. it's a kind of stream of streams -- This is an automated message from the

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464251982 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._

Re: [I] Feature request: Add Flow#switchMap operator. [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on issue #974: URL: https://github.com/apache/incubator-pekko/issues/974#issuecomment-1907292579 I think we have enough on our plate right now with all of the new features, we can always add this into 1.1.0-M2 (if a new M2 is needed) or in 1.2.x. -- This is an automa

Re: [I] Feature request: Add Flow#switchMap operator. [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on issue #974: URL: https://github.com/apache/incubator-pekko/issues/974#issuecomment-1907299417 I will back my hometown soon, if anyone submited a pr about this, then this can be added to 1.1.0-M2 I think, before that, it's safe for later version. I was expecting we

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464280226 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._ ov

Re: [I] consider putting static content (CSS etc.) in CDN [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam commented on issue #84: URL: https://github.com/apache/incubator-pekko-sbt-paradox/issues/84#issuecomment-1907357562 > but i mean how can we made the change to Paradox via coding, e.g. Fix this issue: [apache/incubator-pekko#975](https://github.com/apache/incubator-pekko/issues/975

[PR] fix blank toc entry [incubator-pekko-site]

2024-01-23 Thread via GitHub
Roiocam opened a new pull request, #72: URL: https://github.com/apache/incubator-pekko-site/pull/72 Refs: https://github.com/apache/incubator-pekko/issues/975 Copy from: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87 ## result Select Current Group to Java

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam commented on PR #87: URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87#issuecomment-1907364048 close and reopen in the right repo: https://github.com/apache/incubator-pekko-site/pull/72 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Index toc rendering issue [incubator-pekko-sbt-paradox]

2024-01-23 Thread via GitHub
Roiocam closed pull request #87: Index toc rendering issue URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix paradox document blank toc entry [incubator-pekko-site]

2024-01-23 Thread via GitHub
Roiocam commented on PR #72: URL: https://github.com/apache/incubator-pekko-site/pull/72#issuecomment-1907387254 @samueleresca I think after https://github.com/apache/incubator-pekko-sbt-paradox/pull/86, the paradox wan't generate `group.js` anymore, do you think these CI need to change?

Re: [PR] [DRAFT] try to centralise pom name change logic [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on PR #1035: URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907426732 @pjfanning So I went down the rabbit hole of the whole `pom.xml` name field issue and I created a PR for this with tests at https://github.com/mdedetrich/sbt-apache-sonatype/pu

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464351731 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464355698 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._ ov

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464360162 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._ ov

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464367735 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._

Re: [PR] Support Supervision.restart for SubFlow's [incubator-pekko]

2024-01-23 Thread via GitHub
He-Pin commented on code in PR #981: URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464375057 ## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala: ## @@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._ ov

Re: [PR] [DRAFT] try to centralise pom name change logic [incubator-pekko]

2024-01-23 Thread via GitHub
gmethvin commented on PR #1035: URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907479386 I think if we're going to bother having a display name that's different from the artifact ID, we might as well have a fully pretty-printed version of the name. If we use somethin

Re: [PR] [DRAFT] try to centralise pom name change logic [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on PR #1035: URL: https://github.com/apache/incubator-pekko/pull/1035#issuecomment-1907487115 > I think if we're going to bother having a display name that's different from the artifact ID, we might as well have a fully pretty-printed version of the name. If we use some

Re: [PR] chore: Move java 21 code to a dedicated folder and including code sni… [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on code in PR #1023: URL: https://github.com/apache/incubator-pekko/pull/1023#discussion_r1464404398 ## docs/src/main/java-jdk-21/docs/actors/classical/OptimizedActorWithJava21.java: ## @@ -0,0 +1,33 @@ + +// #pattern-matching + +static class OptimizedActorWith

Re: [I] Support building with Windows [incubator-pekko]

2024-01-23 Thread via GitHub
Roiocam commented on issue #829: URL: https://github.com/apache/incubator-pekko/issues/829#issuecomment-1907504081 Related on #986? could you give more information about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] Support building with Windows [incubator-pekko]

2024-01-23 Thread via GitHub
mdedetrich commented on issue #829: URL: https://github.com/apache/incubator-pekko/issues/829#issuecomment-1907515619 > Related on #986? could you give more information about this? Its unrelated to https://github.com/apache/incubator-pekko/issues/986 . The context of this issue is th

Re: [D] Stream JavaDSL: start adding alternate methods that use Java function interfaces instead of the Pekko ones [incubator-pekko]

2024-01-23 Thread via GitHub
GitHub user mdedetrich edited a comment on the discussion: Stream JavaDSL: start adding alternate methods that use Java function interfaces instead of the Pekko ones > Perhaps the Java API could be written in Java to make it look better for Java > users, Yes but not at the cost of correct AP

  1   2   >