mdedetrich commented on code in PR #981:
URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464367735
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala:
##########
@@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._
override def onDownstreamFinish(cause: Throwable): Unit = {
substreamCancelled = true
- if (isClosed(in) || propagateSubstreamCancel(cause)) {
- cancelStage(cause)
- } else {
- // Start draining
- if (!hasBeenPulled(in)) pull(in)
+ decider(cause) match {
Review Comment:
Isn't this being tested in a different way later down with
`isClosed`/`hasBeenPulled`? Also I had a look at parts of the Pekko codebase
that implements `Supervision.restart` and I don't see `NoMoreElementsNeeded |
StageWasCompleted` being tested in this way.
This doesn't mean its wrong, but if thats the case then testing
`NoMoreElementsNeeded | StageWasCompleted` would be unique to `SubFlow` and I
am not sure why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
