He-Pin commented on code in PR #981:
URL: https://github.com/apache/incubator-pekko/pull/981#discussion_r1464236451
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/StreamOfStreams.scala:
##########
@@ -614,14 +607,31 @@ import pekko.util.ccompat.JavaConverters._
override def onDownstreamFinish(cause: Throwable): Unit = {
substreamCancelled = true
- if (isClosed(in) || propagateSubstreamCancel(cause)) {
- cancelStage(cause)
- } else {
- // Start draining
- if (!hasBeenPulled(in)) pull(in)
+ decider(cause) match {
+ case Supervision.Stop =>
+ cancelStage(cause)
+ case Supervision.Resume =>
+ if (isClosed(in)) cancelStage(cause)
+ else {
+ // Start draining
+ if (!hasBeenPulled(in)) pull(in)
+ }
+ case Supervision.Restart =>
+ if (isClosed(in)) completeStage()
+ else {
+ restartState()
+ // Start draining
+ if (!hasBeenPulled(in)) pull(in)
+ }
Review Comment:
I will review it after work, but I think you can added a `Sink.orElse`,
alias with `Flow.orElse` too. Ping me after You think this ready.
And I think your current implementation is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
