[GitHub] [ignite-3] ptupitsyn merged pull request #2230: IGNITE-19624 Java client: propagate compute deployment units

2023-06-22 Thread via GitHub
ptupitsyn merged PR #2230: URL: https://github.com/apache/ignite-3/pull/2230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238396316 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -130,24 +132,32 @@ public class CatalogServiceImpl extends Producer v

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238396993 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -130,24 +132,32 @@ public class CatalogServiceImpl extends Producer v

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238408528 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -773,11 +783,21 @@ private void registerCatalog(Catalog newCatalog) {

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238416697 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -773,11 +783,21 @@ private void registerCatalog(Catalog newCatalog) {

[GitHub] [ignite] NSAmelchev merged pull request #10783: IGNITE-19766 Added topology snapshot info to services system view

2023-06-22 Thread via GitHub
NSAmelchev merged PR #10783: URL: https://github.com/apache/ignite/pull/10783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: [WIP] IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-22 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238450494 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNodeTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software F

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: [WIP] IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-22 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1238450830 ## modules/table/src/main/java/org/apache/ignite/internal/utils/PrimaryReplica.java: ## @@ -57,4 +59,26 @@ public ClusterNode node() { public long term() {

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238456915 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -243,4 +243,11 @@ public HybridTimestamp addPhysicalTime(long mills) {

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238459124 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -209,13 +214,14 @@ public CompletableFuture onUpdate(WatchEvent eve

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238464931 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -209,13 +214,14 @@ public CompletableFuture onUpdate(WatchEvent

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1602660647 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238560776 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238562976 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238566574 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238572022 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1602711662 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] valepakh commented on a diff in pull request #2216: IGNITE-19450 Add * char to latest version of unit in list command

2023-06-22 Thread via GitHub
valepakh commented on code in PR #2216: URL: https://github.com/apache/ignite-3/pull/2216#discussion_r1238593160 ## modules/rest/src/main/java/org/apache/ignite/internal/rest/deployment/DeploymentManagementController.java: ## @@ -158,18 +156,15 @@ private static List fromUnitSt

[GitHub] [ignite-3] Pochatkin opened a new pull request, #2238: IGNITE-19694 Introduce deployment unit operation ID

2023-06-22 Thread via GitHub
Pochatkin opened a new pull request, #2238: URL: https://github.com/apache/ignite-3/pull/2238 https://issues.apache.org/jira/browse/IGNITE-19694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238642247 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -209,13 +214,14 @@ public CompletableFuture onUpdate(WatchEvent eve

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-22 Thread via GitHub
korlov42 commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238615534 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateEntry.java: ## @@ -18,9 +18,18 @@ package org.apache.ignite.internal.catalog.storag

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10800: IGNITE-19807 Deprecated legacy authorization approach through Security Context.

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10800: URL: https://github.com/apache/ignite/pull/10800#issuecomment-1602861783 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2208: IGNITE-19764 FileDeployerService does not stop underlying thread pool

2023-06-22 Thread via GitHub
PakhomovAlexander merged PR #2208: URL: https://github.com/apache/ignite-3/pull/2208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: Ignite 19675

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1603009900 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] skorotkov opened a new pull request, #10801: IGNITE-19729 [ducktests] Support sqlConfiguration and calcite sql query engine

2023-06-22 Thread via GitHub
skorotkov opened a new pull request, #10801: URL: https://github.com/apache/ignite/pull/10801 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10801: IGNITE-19729 [ducktests] Support sqlConfiguration and calcite sql query engine

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10801: URL: https://github.com/apache/ignite/pull/10801#issuecomment-1603078395 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] zstan opened a new pull request, #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

2023-06-22 Thread via GitHub
zstan opened a new pull request, #2241: URL: https://github.com/apache/ignite-3/pull/2241 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite-3] sanpwc merged pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

2023-06-22 Thread via GitHub
sanpwc merged PR #2227: URL: https://github.com/apache/ignite-3/pull/2227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

2023-06-22 Thread via GitHub
sanpwc commented on code in PR #2186: URL: https://github.com/apache/ignite-3/pull/2186#discussion_r1238924032 ## modules/api/src/main/java/org/apache/ignite/lang/RecoverableException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

2023-06-22 Thread via GitHub
sanpwc commented on code in PR #2186: URL: https://github.com/apache/ignite-3/pull/2186#discussion_r1238933373 ## modules/api/src/main/java/org/apache/ignite/lang/RecoverableException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

2023-06-22 Thread via GitHub
sanpwc commented on code in PR #2186: URL: https://github.com/apache/ignite-3/pull/2186#discussion_r1238924032 ## modules/api/src/main/java/org/apache/ignite/lang/RecoverableException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10800: IGNITE-19807 Deprecated legacy authorization approach through Security Context.

2023-06-22 Thread via GitHub
sonarcloud[bot] commented on PR #10800: URL: https://github.com/apache/ignite/pull/10800#issuecomment-1603220759 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-22 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239314685 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -293,6 +297,10 @@ public synchronized void start() { ser

[GitHub] [ignite-3] lowka commented on a diff in pull request #2199: IGNITE-19726: Sql. Migrate index operations to ScannableTable.

2023-06-22 Thread via GitHub
lowka commented on code in PR #2199: URL: https://github.com/apache/ignite-3/pull/2199#discussion_r1239314550 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java: ## @@ -63,6 +72,113 @@ public Publisher scan(ExecutionContext c

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-22 Thread via GitHub
tkalkirill commented on code in PR #2231: URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1239353061 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateEntry.java: ## @@ -18,9 +18,18 @@ package org.apache.ignite.internal.catalog.stor

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2242: IGNITE-19500 IndexManager should listen CatalogService events instead of configuration

2023-06-22 Thread via GitHub
tkalkirill opened a new pull request, #2242: URL: https://github.com/apache/ignite-3/pull/2242 https://issues.apache.org/jira/browse/IGNITE-19500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239374905 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239376159 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -773,11 +783,21 @@ private void registerCatalog(Catalog newCatalog

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239381926 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239382486 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239383598 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-22 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239385621 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -773,11 +783,21 @@ private void registerCatalog(Catalog newCatalog

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239388840 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLog.java: ## @@ -67,7 +68,8 @@ interface OnUpdateHandler { * An actual ha

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
ibessonov commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239381529 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -649,7 +646,8 @@ public CompletableFuture upsertAl

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill opened a new pull request, #2243: URL: https://github.com/apache/ignite-3/pull/2243 https://issues.apache.org/jira/browse/IGNITE-19799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] tkalkirill merged pull request #2231: IGNITE-19641 Catalog events are triggered too early.

2023-06-23 Thread via GitHub
tkalkirill merged PR #2231: URL: https://github.com/apache/ignite-3/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: Ignite 19675

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1603848298 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239469773 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239476791 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -189,14 +193,7 @@ static ByteArray updatePrefix() { }

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239477856 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -773,11 +783,21 @@ private void registerCatalog(Catalog newCatalog) {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239486721 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -649,7 +646,8 @@ public CompletableFuture upsertA

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239487027 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1077,19 +1078,20 @@ private void validatePartitio

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
korlov42 commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239486944 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java: ## @@ -41,6 +47,20 @@ public String schemaName() {

[GitHub] [ignite-3] korlov42 opened a new pull request, #2244: IGNITE-19815 Make ItTableScanTest resilient

2023-06-23 Thread via GitHub
korlov42 opened a new pull request, #2244: URL: https://github.com/apache/ignite-3/pull/2244 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1603876562 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239494442 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1206,28 +1208,87 @@ public int partitionId(Binary

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239494792 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1206,28 +1208,87 @@ public int partitionId(Binary

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239497171 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -137,66 +137,61 @@ public CatalogServiceImpl(UpdateLog updateLog,

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239502262 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1206,28 +1208,87 @@ public int partitionId(Binary

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239505728 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -189,14 +193,7 @@ static ByteArray updatePrefix() { }

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239507405 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239508269 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1206,28 +1208,87 @@ public int partitionId(Binary

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2232: URL: https://github.com/apache/ignite-3/pull/2232#discussion_r1239510362 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -181,4 +181,11 @@ public interface MetaStorageManager exte

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
ibessonov commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239517816 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -646,7 +647,7 @@ public CompletableFuture upsertAl

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2236: URL: https://github.com/apache/ignite-3/pull/2236#discussion_r1239520522 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -646,7 +647,7 @@ public CompletableFuture upsertA

[GitHub] [ignite-3] ibessonov opened a new pull request, #2245: IGNITE-19806 Port of new log storage from "sofa-jraft"

2023-06-23 Thread via GitHub
ibessonov opened a new pull request, #2245: URL: https://github.com/apache/ignite-3/pull/2245 https://issues.apache.org/jira/browse/IGNITE-19806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239527691 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java: ## @@ -41,6 +47,20 @@ public String schemaName() {

[GitHub] [ignite-3] AMashenkov closed pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-23 Thread via GitHub
AMashenkov closed pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans. URL: https://github.com/apache/ignite-3/pull/2164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1603942630 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] sergeyuttsel closed pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

2023-06-23 Thread via GitHub
sergeyuttsel closed pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage URL: https://github.com/apache/ignite-3/pull/2232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239619567 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java: ## @@ -384,12 +375,10 @@ public void testMergeKeysConflict() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239629356 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareService.java: ## @@ -28,6 +28,12 @@ public interface PrepareService extend

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239634731 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/property/PropertiesHelper.java: ## @@ -42,6 +43,23 @@ public static Builder newBuilder() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239634731 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/property/PropertiesHelper.java: ## @@ -42,6 +43,23 @@ public static Builder newBuilder() {

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239638368 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionBuilderImpl.java: ## @@ -133,19 +135,20 @@ public SessionBuilder property(String name,

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239638368 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionBuilderImpl.java: ## @@ -133,19 +135,20 @@ public SessionBuilder property(String name,

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239645143 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catalog,

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1604074196 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10775: IGNITE-19676 Command JMX Invoker

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10775: URL: https://github.com/apache/ignite/pull/10775#issuecomment-1604102436 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239677550 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239677897 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java: ## @@ -165,9 +165,13 @@ private void restoreStateFromVault(OnUpdateHandle

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239684236 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AbstractIndexCommandParams.java: ## @@ -41,6 +47,20 @@ public String schemaName() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239685753 ## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/matchers/CompletableFutureMatcher.java: ## @@ -145,7 +146,7 @@ public static Complet

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239686536 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239686857 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239687539 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239687735 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239687906 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239689410 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill commented on code in PR #2243: URL: https://github.com/apache/ignite-3/pull/2243#discussion_r1239690756 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -863,4 +654,197 @@ private Catalog applyUpdateFinal(Catalog catal

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239690070 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -81,6 +76,25 @@ public interface MetaStorageManager ex

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
sashapolo commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239692137 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/ClockWaiter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2228: IGNITE-19209 Implement installing table schema updates

2023-06-23 Thread via GitHub
rpuch commented on code in PR #2228: URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1239694109 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -81,6 +76,25 @@ public interface MetaStorageManager extend

[GitHub] [ignite] ivandasch opened a new pull request, #10802: IGNITE-16181 SQL Calcite: Implement integer overflow

2023-06-23 Thread via GitHub
ivandasch opened a new pull request, #10802: URL: https://github.com/apache/ignite/pull/10802 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10802: IGNITE-16181 SQL Calcite: Implement integer overflow

2023-06-23 Thread via GitHub
sonarcloud[bot] commented on PR #10802: URL: https://github.com/apache/ignite/pull/10802#issuecomment-1604146971 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] tkalkirill merged pull request #2236: IGNITE-16004 Preserve key order in InternalTableImpl#collectMultiRowsResponses

2023-06-23 Thread via GitHub
tkalkirill merged PR #2236: URL: https://github.com/apache/ignite-3/pull/2236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] tkalkirill merged pull request #2243: IGNITE-19799 Refactoring classes associated with the catalog

2023-06-23 Thread via GitHub
tkalkirill merged PR #2243: URL: https://github.com/apache/ignite-3/pull/2243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-extensions] nizhikov closed pull request #211: IGNITE-XXXX usage of async commit for metadata offset store

2023-06-23 Thread via GitHub
nizhikov closed pull request #211: IGNITE- usage of async commit for metadata offset store URL: https://github.com/apache/ignite-extensions/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

2023-06-23 Thread via GitHub
korlov42 commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1239624615 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PlanningContext.java: ## @@ -39,23 +39,31 @@ * Planning context. */ public fina

[GitHub] [ignite-3] valepakh opened a new pull request, #2246: IGNITE-19825 Warning during rest integration test build

2023-06-23 Thread via GitHub
valepakh opened a new pull request, #2246: URL: https://github.com/apache/ignite-3/pull/2246 https://issues.apache.org/jira/browse/IGNITE-19825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

<    1   2   3   4   5   6   7   8   9   10   >