korlov42 commented on code in PR #2231:
URL: https://github.com/apache/ignite-3/pull/2231#discussion_r1238615534
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateEntry.java:
##########
@@ -18,9 +18,18 @@
package org.apache.ignite.internal.catalog.storage;
import java.io.Serializable;
+import org.apache.ignite.internal.catalog.Catalog;
/**
- * A marker interface describing a particular change within the {@link
VersionedUpdate group}.
+ * Interface describing a particular change within the {@link VersionedUpdate
group}.
*/
public interface UpdateEntry extends Serializable {
+ /**
+ * Applies own change to the catalog.
+ *
+ * @param catalog Current catalog.
+ * @param update Group of changes that relates to specified version.
+ * @return New catalog.
+ */
+ Catalog applyUpdate(Catalog catalog, VersionedUpdate update);
Review Comment:
this signature doesn't feel right. Which update should I apply to the
catalog? Why do I need VersionedUpdate at all? Should I verify that current
entry is part of VersionedUpdate.
If you need to bump version, it's better to do as post processing of all
updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
