rpuch commented on code in PR #2228:
URL: https://github.com/apache/ignite-3/pull/2228#discussion_r1238459124
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateLogImpl.java:
##########
@@ -209,13 +214,14 @@ public CompletableFuture<Void> onUpdate(WatchEvent event)
{
VersionedUpdate update = fromBytes(payload);
- onUpdateHandler.handle(update);
+ HybridTimestamp entryTimestamp =
metastoreRevisionToTs.apply(eventEntry.newEntry().revision());
Review Comment:
If I'm not mistaken, to get a ts we MUST make a lookup (as it's stored in an
index by revision). If we move it to `WatchEvent`, we'll have to make this
lookup for 100% of entries; here we do it on-demand, only when required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
