nizhikov commented on PR #10778:
URL: https://github.com/apache/ignite/pull/10778#issuecomment-1629449076
Not sure about `CdcBuffer` on heap approach. I think we must rework this to
offheap to be able to work with relatively big buffers like several gigabytes.
--
This is an automated mess
isapego merged PR #2284:
URL: https://github.com/apache/ignite-3/pull/2284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ign
sonarcloud[bot] commented on PR #10832:
URL: https://github.com/apache/ignite/pull/10832#issuecomment-1629615375
Kudos, SonarCloud Quality Gate passed! [ {
ass
ibessonov commented on code in PR #2273:
URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1259299932
##
modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java:
##
@@ -214,7 +223,7 @@ void unsubscribe(NodeId nodeId) {
ass
ygerzhedovich commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1259321937
##
modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java:
##
@@ -180,6 +180,18 @@ public BinaryObject binaryObjectValue(int columnIndex) {
re
ibessonov merged PR #2295:
URL: https://github.com/apache/ignite-3/pull/2295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1259370891
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionImpl.java:
##
@@ -330,7 +329,13 @@ public Publisher executeBatchReactive(@Nullable
Tr
hennejg opened a new issue, #10833:
URL: https://github.com/apache/ignite/issues/10833
At least it is missing from maven central. Also, there seems to be no
release note mentioning where else the functionality went.
--
This is an automated message from the Apache Git Service.
To respond t
lowka commented on PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#issuecomment-1630369497
`ItJdbcMetadataSelfTest` requires updaing. See
> // Add columns with All supported types.
>EnumSet excludeTypes = EnumSet
>.of(ColumnType.TIMEST
hennejg commented on issue #10833:
URL: https://github.com/apache/ignite/issues/10833#issuecomment-1630377108
Sorry, I missed the note stating "Moved ignite-cloud IP Finder to the Ignite
Extensions project."
--
This is an automated message from the Apache Git Service.
To respond to the me
hennejg closed issue #10833: ignite-cloud seems to be missing from the
2.14.0-release onward
URL: https://github.com/apache/ignite/issues/10833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
lowka commented on PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#issuecomment-1630392068
Also see `ItJdbcMetadataSelfTest:: dataTypeToJavaCls(int dataType, String
typeName)` and ` void checkMeta(ResultSetMetaData meta)`.
--
This is an automated message from the Apache Git Se
fenixcitizen opened a new issue, #10834:
URL: https://github.com/apache/ignite/issues/10834
Up until Apache Ignite 2.14 it was possible to use Visor console to connect
to a cluster using Spring XML configuration file as documented at
https://github.com/apache/ignite/blob/2.14.0/modules/viso
ptupitsyn commented on code in PR #2302:
URL: https://github.com/apache/ignite-3/pull/2302#discussion_r1259490927
##
modules/core/src/main/java/org/apache/ignite/internal/util/HashCalculator.java:
##
@@ -170,8 +244,19 @@ public void appendNumber(BigInteger v) {
* @param v
ptupitsyn commented on code in PR #2302:
URL: https://github.com/apache/ignite-3/pull/2302#discussion_r1259491239
##
modules/core/src/main/java/org/apache/ignite/internal/util/HashUtils.java:
##
@@ -120,12 +105,50 @@ public static int hash32(int data, int seed) {
* @param
valepakh opened a new pull request, #2304:
URL: https://github.com/apache/ignite-3/pull/2304
https://issues.apache.org/jira/browse/IGNITE-19948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1259504450
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/SessionImpl.java:
##
@@ -330,7 +329,13 @@ public Publisher executeBatchReactive(@Nullable
Transac
ibessonov merged PR #2273:
URL: https://github.com/apache/ignite-3/pull/2273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1259545781
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/NodeLeftException.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Founda
ptupitsyn commented on code in PR #2303:
URL: https://github.com/apache/ignite-3/pull/2303#discussion_r1259550450
##
modules/platforms/cpp/ignite/tuple/tuple_test.cpp:
##
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
Review Comment:
The rest of the file has n
isapego commented on code in PR #2303:
URL: https://github.com/apache/ignite-3/pull/2303#discussion_r1259553807
##
modules/platforms/cpp/ignite/odbc/app/application_data_buffer.cpp:
##
@@ -892,22 +841,27 @@ conversion_result application_data_buffer::put_time(const
ignite_time&
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1259554177
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/NodeLeftException.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation
isapego commented on code in PR #2303:
URL: https://github.com/apache/ignite-3/pull/2303#discussion_r1259555883
##
modules/platforms/cpp/ignite/tuple/tuple_test.cpp:
##
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
Review Comment:
Yeah. It seems that I remove
korlov42 opened a new pull request, #2305:
URL: https://github.com/apache/ignite-3/pull/2305
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
isapego merged PR #2303:
URL: https://github.com/apache/ignite-3/pull/2303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ign
sashapolo opened a new pull request, #2306:
URL: https://github.com/apache/ignite-3/pull/2306
https://issues.apache.org/jira/browse/IGNITE-19952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
nizhikov closed pull request #210: IGNITE-15629 Management API openAPI invoker
implemented
URL: https://github.com/apache/ignite-extensions/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
xtern commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1259649051
##
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleReader.java:
##
@@ -79,6 +80,34 @@ public boolean hasNullValue(int index) {
xtern commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1259652213
##
modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java:
##
@@ -180,6 +180,18 @@ public BinaryObject binaryObjectValue(int columnIndex) {
return val
xtern commented on PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#issuecomment-1630724728
> You forgot to adjust folowing places:
>
> * RecordMarshallerTest; besides, this test should be moved from
testFixtures
>
> *
org.apache.ignite.internal.sql.engine.u
ptupitsyn merged PR #2302:
URL: https://github.com/apache/ignite-3/pull/2302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
sonarcloud[bot] commented on PR #10798:
URL: https://github.com/apache/ignite/pull/10798#issuecomment-1630827664
SonarCloud Quality Gate failed. [ {
Propertie
yurinaryshkin commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1259801677
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordV2Serializer.java:
##
@@ -266,7 +265,7 @@ private stat
yurinaryshkin commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1259802922
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/Crc32CheckingDataInput.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to t
timoninmaxim commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1259472660
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/ByteBufferWalIterator.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
sonarcloud[bot] commented on PR #10798:
URL: https://github.com/apache/ignite/pull/10798#issuecomment-1630931173
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
sonarcloud[bot] commented on PR #10762:
URL: https://github.com/apache/ignite/pull/10762#issuecomment-1631985042
Kudos, SonarCloud Quality Gate passed! [ {
SammyVimes merged PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
ibessonov closed pull request #2260: IGNITE-19801 Configuration prematurely
executes metastore revision update listener
URL: https://github.com/apache/ignite-3/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ibessonov opened a new pull request, #2307:
URL: https://github.com/apache/ignite-3/pull/2307
https://issues.apache.org/jira/browse/IGNITE-19801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lowka commented on code in PR #2297:
URL: https://github.com/apache/ignite-3/pull/2297#discussion_r1260785148
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/configuration/TableValidatorImpl.java:
##
@@ -65,7 +65,7 @@ public void validate(TableValidator annotat
timoninmaxim commented on code in PR #10798:
URL: https://github.com/apache/ignite/pull/10798#discussion_r1260786856
##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/AbstractWalRecordsIteratorAdapter.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Lice
sonarcloud[bot] commented on PR #10798:
URL: https://github.com/apache/ignite/pull/10798#issuecomment-1632179526
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
ibessonov commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1260915293
##
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/IgniteTestUtils.java:
##
@@ -891,4 +894,40 @@ public boolean matches(Object o) {
sonarcloud[bot] commented on PR #10778:
URL: https://github.com/apache/ignite/pull/10778#issuecomment-1632245659
SonarCloud Quality Gate failed. [ {
ptupitsyn opened a new pull request, #2309:
URL: https://github.com/apache/ignite-3/pull/2309
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1260982123
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/NodeLeftException.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1260982123
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/NodeLeftException.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation
AMashenkov commented on code in PR #2214:
URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1260983884
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##
@@ -155,7 +158,7 @@ public class ExecutionServiceIm
ptupitsyn merged PR #2308:
URL: https://github.com/apache/ignite-3/pull/2308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
timoninmaxim merged PR #10778:
URL: https://github.com/apache/ignite/pull/10778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
rpuch commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1260955770
##
modules/core/src/main/java/org/apache/ignite/internal/future/OrderingFuture.java:
##
@@ -337,6 +338,41 @@ public CompletableFuture
thenComposeToCompletable(Function
AMashenkov commented on code in PR #2214:
URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1261001744
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgnitePlanner.java:
##
@@ -560,6 +564,11 @@ public void checkCancel() {
ibessonov merged PR #2307:
URL: https://github.com/apache/ignite-3/pull/2307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254250115
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -311,11 +310,11 @@ private static RuntimeException
conve
AMashenkov commented on code in PR #2297:
URL: https://github.com/apache/ignite-3/pull/2297#discussion_r1261012671
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/configuration/TableValidatorImpl.java:
##
@@ -65,7 +65,7 @@ public void validate(TableValidator an
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1261013150
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1261013962
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
@@ -117,92 +117,35 @@ public static class Sql {
/** Session not found error. */
AMashenkov commented on code in PR #2297:
URL: https://github.com/apache/ignite-3/pull/2297#discussion_r1261012671
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/configuration/TableValidatorImpl.java:
##
@@ -65,7 +65,7 @@ public void validate(TableValidator an
SammyVimes commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1261029565
##
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/netty/ItConnectionManagerTest.java:
##
@@ -295,6 +299,99 @@ public void testStopTwice
SammyVimes commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1261037490
##
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/netty/ItConnectionManagerTest.java:
##
@@ -295,6 +299,99 @@ public void testStopTwice
SammyVimes commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1261038492
##
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/netty/ItConnectionManagerTest.java:
##
@@ -295,6 +299,99 @@ public void testStopTwice
sonarcloud[bot] commented on PR #10798:
URL: https://github.com/apache/ignite/pull/10798#issuecomment-1632358983
SonarCloud Quality Gate failed. [ {
public
SammyVimes commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1261042757
##
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/IgniteTestUtils.java:
##
@@ -891,4 +894,40 @@ public boolean matches(Object o) {
rpuch opened a new pull request, #2310:
URL: https://github.com/apache/ignite-3/pull/2310
https://issues.apache.org/jira/browse/IGNITE-19963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
SammyVimes commented on code in PR #2283:
URL: https://github.com/apache/ignite-3/pull/2283#discussion_r1261046027
##
modules/network/src/integrationTest/java/org/apache/ignite/network/scalecube/ItScaleCubeNetworkMessagingTest.java:
##
@@ -355,25 +357,44 @@ public void nodeCanno
ptupitsyn merged PR #170:
URL: https://github.com/apache/ignite-website/pull/170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
sonarcloud[bot] commented on PR #10762:
URL: https://github.com/apache/ignite/pull/10762#issuecomment-1632377128
Kudos, SonarCloud Quality Gate passed! [ thro
ygerzhedovich commented on code in PR #2305:
URL: https://github.com/apache/ignite-3/pull/2305#discussion_r1261089059
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##
@@ -170,6 +172,14 @@ public void tearDown() thro
ygerzhedovich commented on code in PR #2305:
URL: https://github.com/apache/ignite-3/pull/2305#discussion_r1261092424
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##
@@ -170,6 +172,14 @@ public void tearDown() thro
korlov42 commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1261094438
##
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##
Review Comment:
1) I would say, we need neither `SESSION_NOT_FOUND_ERR` nor
`SESSION_E
AMashenkov opened a new pull request, #2311:
URL: https://github.com/apache/ignite-3/pull/2311
https://issues.apache.org/jira/browse/IGNITE-19942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
korlov42 commented on code in PR #2305:
URL: https://github.com/apache/ignite-3/pull/2305#discussion_r1261106126
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##
@@ -170,6 +172,14 @@ public void tearDown() throws Ex
ptupitsyn merged PR #2309:
URL: https://github.com/apache/ignite-3/pull/2309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
PakhomovAlexander merged PR #2304:
URL: https://github.com/apache/ignite-3/pull/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
1301 - 1400 of 37343 matches
Mail list logo
