[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2273: IGNITE-19946 Implement batch log updates for RAFT.

[via GitHub]

ibessonov commented on code in PR #2273:
URL: https://github.com/apache/ignite-3/pull/2273#discussion_r1259299932


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java:
##########
@@ -214,7 +223,7 @@ void unsubscribe(NodeId nodeId) {
             assert handler != null : format("Group of the event is unsupported 
[nodeId={}, event={}]", event.nodeId(), event);
 
             //TODO: IGNITE-15568 endOfBatch should be set to true to prevent 
caching tasks until IGNITE-15568 has fixed.
-            handler.onEvent(event, sequence, subscribers.size() > 1 ? true : 
endOfBatch);
+            handler.onEvent(event, sequence, endOfBatch || subscribers.size() 
>= 1 && !supportsBatches);

Review Comment:
   Must be `> 1` I guess



##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/disruptor/StripedDisruptor.java:
##########
@@ -214,7 +223,7 @@ void unsubscribe(NodeId nodeId) {
             assert handler != null : format("Group of the event is unsupported 
[nodeId={}, event={}]", event.nodeId(), event);
 
             //TODO: IGNITE-15568 endOfBatch should be set to true to prevent 
caching tasks until IGNITE-15568 has fixed.
-            handler.onEvent(event, sequence, subscribers.size() > 1 ? true : 
endOfBatch);
+            handler.onEvent(event, sequence, endOfBatch || subscribers.size() 
>= 1 && !supportsBatches);

Review Comment:
   Must be `== 1` I guess



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org