[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226680971 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226702935 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226702935 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226710781 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -18,48 +18,34 @@ package org.apache.ignite.internal.sql.engi

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226710781 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -18,48 +18,34 @@ package org.apache.ignite.internal.sql.engi

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226729461 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java: ## @@ -80,9 +66,6 @@ public boolean equals(Object o) { if

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1226747351 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -244,7 +260,7 @@ public synchronized void start() {

[GitHub] [ignite-3] AMashenkov merged pull request #2174: IGNITE-19304 Forbid creating index on the duplicate columns

2023-06-12 Thread via GitHub
AMashenkov merged PR #2174: URL: https://github.com/apache/ignite-3/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-12 Thread via GitHub
AMashenkov commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226776026 ## modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java: ## @@ -105,7 +106,7 @@ public void execute(Runnable cmd) { * @

[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-12 Thread via GitHub
lowka commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226780794 ## modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java: ## @@ -105,7 +106,7 @@ public void execute(Runnable cmd) { * @throw

[GitHub] [ignite-3] xtern commented on a diff in pull request #2164: IGNITE-17765 Sql. Avoid parsing queries that already have cached plans.

2023-06-12 Thread via GitHub
xtern commented on code in PR #2164: URL: https://github.com/apache/ignite-3/pull/2164#discussion_r1227149541 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -407,70 +423,83 @@ private CompletableFuture>> querySingle0(

[GitHub] [ignite-extensions] Noone-No commented on pull request #94: IGNITE-16124 change signature in method deleteAllById in spring data 2.2

2023-06-12 Thread via GitHub
Noone-No commented on PR #94: URL: https://github.com/apache/ignite-extensions/pull/94#issuecomment-1588492617 how to fix this error ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [ignite-3] ptupitsyn merged pull request #2180: IGNITE-19707 Fix AssertionError in DistributionZoneManagerScaleUpTest

2023-06-12 Thread via GitHub
ptupitsyn merged PR #2180: URL: https://github.com/apache/ignite-3/pull/2180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes

2023-06-12 Thread via GitHub
alievmirza commented on code in PR #2171: URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1227592992 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java: ## @@ -45,6 +48,9 @@

[GitHub] [ignite-3] vldpyatkov opened a new pull request, #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov opened a new pull request, #2183: URL: https://github.com/apache/ignite-3/pull/2183 …geManager.start() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
timoninmaxim commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227630007 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-13 Thread via GitHub
korlov42 commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226605360 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutor.java: ## @@ -45,4 +45,13 @@ public interface QueryTaskExecutor extend

[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-13 Thread via GitHub
lowka commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1227689796 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTable.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [ignite-3] denis-chudov closed pull request #2115: IGNITE-19478 Possible excess size of table entities written into meta storage

2023-06-13 Thread via GitHub
denis-chudov closed pull request #2115: IGNITE-19478 Possible excess size of table entities written into meta storage URL: https://github.com/apache/ignite-3/pull/2115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [ignite-3] denis-chudov closed pull request #1875: placement driver start

2023-06-13 Thread via GitHub
denis-chudov closed pull request #1875: placement driver start URL: https://github.com/apache/ignite-3/pull/1875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [ignite-3] denis-chudov closed pull request #2014: wip

2023-06-13 Thread via GitHub
denis-chudov closed pull request #2014: wip URL: https://github.com/apache/ignite-3/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [ignite] ivandasch commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
ivandasch commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227780600 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite] ivandasch commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
ivandasch commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227782321 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite] ivandasch commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
ivandasch commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227788649 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10767: URL: https://github.com/apache/ignite/pull/10767#issuecomment-1588864646 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] ivandasch commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
ivandasch commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227806712 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandInvoker.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite] nizhikov commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
nizhikov commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227814904 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [ignite] nizhikov commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
nizhikov commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227816389 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [ignite] nizhikov commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
nizhikov commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227815722 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [ignite] nizhikov commented on a diff in pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
nizhikov commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227820159 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandInvoker.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10675: URL: https://github.com/apache/ignite/pull/10675#issuecomment-1588919357 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] yurinaryshkin commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
yurinaryshkin commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227840681 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java: ## @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10767: URL: https://github.com/apache/ignite/pull/10767#issuecomment-1588956393 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

2023-06-13 Thread via GitHub
ibessonov commented on code in PR #2178: URL: https://github.com/apache/ignite-3/pull/2178#discussion_r1227754082 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2127: IGNITE-19552 Build JDBC module jar

2023-06-13 Thread via GitHub
PakhomovAlexander merged PR #2127: URL: https://github.com/apache/ignite-3/pull/2127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

2023-06-13 Thread via GitHub
sk0x50 commented on code in PR #2178: URL: https://github.com/apache/ignite-3/pull/2178#discussion_r1227877049 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

2023-06-13 Thread via GitHub
sk0x50 commented on code in PR #2178: URL: https://github.com/apache/ignite-3/pull/2178#discussion_r1227878072 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2178: IGNITE-19535 Removed a requirement to have a special constructor for Ignite exceptions

2023-06-13 Thread via GitHub
sk0x50 commented on code in PR #2178: URL: https://github.com/apache/ignite-3/pull/2178#discussion_r1227879844 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [ignite] nizhikov merged pull request #10675: IGNITE-15629 Management API introduced

2023-06-13 Thread via GitHub
nizhikov merged PR #10675: URL: https://github.com/apache/ignite/pull/10675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] alievmirza opened a new pull request, #2185: IGNITE-19714 Fix AssertionError in DistributionZoneManagerWatchListenerTest

2023-06-13 Thread via GitHub
alievmirza opened a new pull request, #2185: URL: https://github.com/apache/ignite-3/pull/2185 https://issues.apache.org/jira/browse/IGNITE-19714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
timoninmaxim commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227906760 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java: ## @@ -113,18 +110,14 @@ public void testSetLimit() throws Exception {

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
timoninmaxim commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227909206 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
timoninmaxim commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227912089 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/ThinClientIndexQueryTest.java: ## @@ -369,6 +393,47 @@ private void assertClientQuery(ClientCache

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
timoninmaxim commented on code in PR #10767: URL: https://github.com/apache/ignite/pull/10767#discussion_r1227914726 ## modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQueryLimitTest.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10767: IGNITE-16619 IndexQuery should support limit

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10767: URL: https://github.com/apache/ignite/pull/10767#issuecomment-1589086329 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] ivandasch commented on a diff in pull request #10769: IGNITE-19588 SQL Calcite: Add long-running queries warnings

2023-06-13 Thread via GitHub
ivandasch commented on code in PR #10769: URL: https://github.com/apache/ignite/pull/10769#discussion_r1227953672 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/CalciteQueryProcessor.java: ## @@ -534,7 +519,7 @@ private T processQuery(

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10638: IGNITE-19164 Improve message about requested partitions during snapshot restore

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10638: URL: https://github.com/apache/ignite/pull/10638#issuecomment-1589144139 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] ptupitsyn merged pull request #2182: IGNITE-19545 .NET: Add Basic Data Streamer

2023-06-13 Thread via GitHub
ptupitsyn merged PR #2182: URL: https://github.com/apache/ignite-3/pull/2182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes

2023-06-13 Thread via GitHub
kgusakov commented on code in PR #2171: URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1228023852 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java: ## @@ -45,6 +48,9 @@ v

[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes

2023-06-13 Thread via GitHub
kgusakov commented on code in PR #2171: URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1228028031 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java: ## @@ -45,6 +48,9 @@ v

[GitHub] [ignite-3] vldpyatkov merged pull request #2157: IGNITE-18692 ItRebalanceTest fix

2023-06-13 Thread via GitHub
vldpyatkov merged PR #2157: URL: https://github.com/apache/ignite-3/pull/2157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10638: IGNITE-19164 Improve message about requested partitions during snapshot restore

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10638: URL: https://github.com/apache/ignite/pull/10638#issuecomment-1589205779 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] zstan commented on pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

2023-06-13 Thread via GitHub
zstan commented on PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#issuecomment-1589237743 @korlov42 i revert tx fix and change only mapping part, can u take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2152: IGNITE-19522 Modify deploy unit command

2023-06-13 Thread via GitHub
PakhomovAlexander merged PR #2152: URL: https://github.com/apache/ignite-3/pull/2152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

2023-06-13 Thread via GitHub
korlov42 commented on code in PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#discussion_r1228113151 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteFragmentMapping.java: ## @@ -85,33 +231,19 @@ public MetadataDef getDef() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

2023-06-13 Thread via GitHub
korlov42 commented on code in PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#discussion_r1228113886 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteFragmentMapping.java: ## @@ -69,13 +75,153 @@ public class IgniteMdFragmentMa

[GitHub] [ignite] asfgit closed pull request #10769: IGNITE-19588 SQL Calcite: Add long-running queries warnings

2023-06-13 Thread via GitHub
asfgit closed pull request #10769: IGNITE-19588 SQL Calcite: Add long-running queries warnings URL: https://github.com/apache/ignite/pull/10769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10769: IGNITE-19588 SQL Calcite: Add long-running queries warnings

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10769: URL: https://github.com/apache/ignite/pull/10769#issuecomment-1589314034 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
rpuch commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228074486 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -1031,10 +1038,10 @@ public void handle(VersionedUpdate update) {

[GitHub] [ignite] petrov-mg opened a new pull request, #10770: IGNITE-19715 Thin client socket#open timeout changed to ClientConfiguration#timeout property.

2023-06-13 Thread via GitHub
petrov-mg opened a new pull request, #10770: URL: https://github.com/apache/ignite/pull/10770 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228209827 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogServiceImpl.java: ## @@ -1031,10 +1038,10 @@ public void handle(VersionedUpdate update) {

[GitHub] [ignite-3] sk0x50 opened a new pull request, #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

2023-06-13 Thread via GitHub
sk0x50 opened a new pull request, #2186: URL: https://github.com/apache/ignite-3/pull/2186 https://issues.apache.org/jira/browse/IGNITE-19536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10770: IGNITE-19715 Thin client socket#open timeout changed to ClientConfiguration#timeout property.

2023-06-13 Thread via GitHub
sonarcloud[bot] commented on PR #10770: URL: https://github.com/apache/ignite/pull/10770#issuecomment-1589412385 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228213949 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogDescriptorUtils.java: ## @@ -188,4 +211,21 @@ private static CatalogIndexColu

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228215004 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogZoneDescriptor.java: ## @@ -75,6 +78,35 @@ public CatalogZoneDescriptor(

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228216385 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogServiceSelfTest.java: ## @@ -1408,55 +1419,38 @@ public void testDefaultZone() {

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228217596 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -154,21 +140,11 @@ protected final void initi

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228220452 ## modules/catalog/build.gradle: ## @@ -29,6 +29,7 @@ dependencies { implementation project(':ignite-metastorage-api') implementation project(':ignite-vau

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2146: IGNITE-19517 Cache JobClassLoaders

2023-06-13 Thread via GitHub
PakhomovAlexander commented on code in PR #2146: URL: https://github.com/apache/ignite-3/pull/2146#discussion_r1227119099 ## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/DeploymentManagerImpl.java: ## @@ -296,6 +319,41 @@ public CompletableFuture o

[GitHub] [ignite-3] PakhomovAlexander merged pull request #2146: IGNITE-19517 Cache JobClassLoaders

2023-06-13 Thread via GitHub
PakhomovAlexander merged PR #2146: URL: https://github.com/apache/ignite-3/pull/2146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #2146: IGNITE-19517 Cache JobClassLoaders

2023-06-13 Thread via GitHub
Flaugh24 commented on code in PR #2146: URL: https://github.com/apache/ignite-3/pull/2146#discussion_r1228238924 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/ClassLoaderExceptionsMapper.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
rpuch commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228241311 ## modules/catalog/build.gradle: ## @@ -29,6 +29,7 @@ dependencies { implementation project(':ignite-metastorage-api') implementation project(':ignite-vault')

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill commented on code in PR #2184: URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228254928 ## modules/catalog/build.gradle: ## @@ -29,6 +29,7 @@ dependencies { implementation project(':ignite-metastorage-api') implementation project(':ignite-vau

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228259420 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public static

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228270424 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -170,8 +170,10 @@ public interface MetaStorageManager ext

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228276622 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public static

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228286531 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[GitHub] [ignite-3] tkalkirill merged pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

2023-06-13 Thread via GitHub
tkalkirill merged PR #2184: URL: https://github.com/apache/ignite-3/pull/2184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228289667 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228294924 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-13 Thread via GitHub
lowka commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1228296263 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutor.java: ## @@ -45,4 +45,13 @@ public interface QueryTaskExecutor extends L

[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.

2023-06-13 Thread via GitHub
lowka commented on code in PR #2140: URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1228296810 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTable.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228302585 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228308032 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public sta

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228313489 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228322151 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public sta

[GitHub] [ignite-3] sk0x50 merged pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes

2023-06-13 Thread via GitHub
sk0x50 merged PR #2171: URL: https://github.com/apache/ignite-3/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] denis-chudov closed pull request #2179: IGNITE-19079 ExecutionTimeout in ItIgniteNodeRestartTest

2023-06-13 Thread via GitHub
denis-chudov closed pull request #2179: IGNITE-19079 ExecutionTimeout in ItIgniteNodeRestartTest URL: https://github.com/apache/ignite-3/pull/2179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] denis-chudov opened a new pull request, #2187: IGNITE-19079 Enabled tests in ItIgniteNodeRestartTest: testTwoNodesRestartDirect and testTwoNodesRestartReverse

2023-06-13 Thread via GitHub
denis-chudov opened a new pull request, #2187: URL: https://github.com/apache/ignite-3/pull/2187 https://issues.apache.org/jira/browse/IGNITE-19079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228354015 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -170,8 +170,10 @@ public interface MetaStorageManager

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228359724 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public static

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228365449 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -170,8 +170,10 @@ public interface MetaStorageManager ext

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228369000 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public static

[GitHub] [ignite-3] zstan commented on a diff in pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

2023-06-13 Thread via GitHub
zstan commented on code in PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#discussion_r1228370294 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteFragmentMapping.java: ## @@ -85,33 +231,19 @@ public MetadataDef getDef() {

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
sanpwc commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228373071 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/impl/MetaStorageDeployWatchesCorrectnessTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[GitHub] [ignite-3] zstan commented on a diff in pull request #2181: IGNITE-19709 Sql. Get rid of starting implicit transactions for SELECT statements without FROM keyword, change mapping

2023-06-13 Thread via GitHub
zstan commented on code in PR #2181: URL: https://github.com/apache/ignite-3/pull/2181#discussion_r1228370294 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/IgniteFragmentMapping.java: ## @@ -85,33 +231,19 @@ public MetadataDef getDef() {

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2183: IGNITE-19606 Linearize metaStorageManager.deployWatches and metaStora…

2023-06-13 Thread via GitHub
vldpyatkov commented on code in PR #2183: URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1228652145 ## modules/distribution-zones/src/testFixtures/java/org/apache/ignite/internal/distributionzones/DistributionZonesTestUtil.java: ## @@ -313,17 +313,17 @@ public sta

[GitHub] [ignite-3] ptupitsyn opened a new pull request, #2189: IGNITE-19728 .NET: Fix TestAutoFlushFrequency flakiness

2023-06-13 Thread via GitHub
ptupitsyn opened a new pull request, #2189: URL: https://github.com/apache/ignite-3/pull/2189 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [ignite-3] zstan opened a new pull request, #2190: IGNITE-19373 Get rid of waitForIndex from tests

2023-06-13 Thread via GitHub
zstan opened a new pull request, #2190: URL: https://github.com/apache/ignite-3/pull/2190 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10770: IGNITE-19715 Thin client socket#open timeout changed to ClientConfiguration#timeout property.

2023-06-14 Thread via GitHub
sonarcloud[bot] commented on PR #10770: URL: https://github.com/apache/ignite/pull/10770#issuecomment-1590594553 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

  1   2   3   4   5   6   7   8   9   10   >