[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2184: IGNITE-19483 Transform TableManager and IndexManager to internally work against Catalog event types

[via GitHub]

tkalkirill commented on code in PR #2184:
URL: https://github.com/apache/ignite-3/pull/2184#discussion_r1228213949


##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogDescriptorUtils.java:
##########
@@ -188,4 +211,21 @@ private static CatalogIndexColumnDescriptor 
toIndexColumnDescriptor(IndexColumnV
 
         return new CatalogIndexColumnDescriptor(config.name(), collation);
     }
+
+    // TODO: IGNITE-19719 Fix it
+    private static CatalogDataStorageDescriptor 
toDataStorageDescriptor(DataStorageView config) {
+        String dataRegion;
+
+        try {
+            Method dataRegionMethod = 
config.getClass().getMethod("dataRegion");

Review Comment:
   Yes, this "great" solution came from the unavailability of these engines, 
and at the moment I would not really like to add them to the dependency, since 
it will turn out to be a cyclic dependency.
   
   I created IGNITE-19719 to figure out how we can do well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org