nizhikov commented on code in PR #10675: URL: https://github.com/apache/ignite/pull/10675#discussion_r1227820159
########## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandInvoker.java: ########## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.commandline; + +import java.io.IOException; +import java.net.InetAddress; +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import org.apache.ignite.IgniteLogger; +import org.apache.ignite.internal.client.GridClient; +import org.apache.ignite.internal.client.GridClientBeforeNodeStart; +import org.apache.ignite.internal.client.GridClientCompute; +import org.apache.ignite.internal.client.GridClientConfiguration; +import org.apache.ignite.internal.client.GridClientDisconnectedException; +import org.apache.ignite.internal.client.GridClientException; +import org.apache.ignite.internal.client.GridClientFactory; +import org.apache.ignite.internal.client.GridClientNode; +import org.apache.ignite.internal.dto.IgniteDataTransferObject; +import org.apache.ignite.internal.management.api.BeforeNodeStartCommand; +import org.apache.ignite.internal.management.api.Command; +import org.apache.ignite.internal.management.api.ComputeCommand; +import org.apache.ignite.internal.management.api.LocalCommand; +import org.apache.ignite.internal.management.api.PreparableCommand; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.internal.util.typedef.F; +import org.apache.ignite.internal.visor.VisorTaskArgument; +import org.apache.ignite.lang.IgniteBiTuple; + +import static java.util.Collections.singleton; +import static java.util.stream.Collectors.toMap; +import static org.apache.ignite.internal.commandline.CommandHandler.DFLT_HOST; + +/** + * Adapter of new management API command for legacy {@code control.sh} execution flow. + */ +public class CommandInvoker<A extends IgniteDataTransferObject> { + /** Command to execute. */ + private final Command<A, ?> cmd; + + /** Parsed argument. */ + private final A arg; + + /** Client configuration. */ + private GridClientConfiguration clientCfg; + + /** @param cmd Command to execute. */ + public CommandInvoker(Command<A, ?> cmd, A arg, GridClientConfiguration clientCfg) { + this.cmd = cmd; + this.arg = arg; + this.clientCfg = clientCfg; + } + + /** + * Actual command execution with verbose mode if needed. + * Implement it if your command supports verbose mode. + * + * @param log Logger to use. + * @param verbose Use verbose mode or not + * @return Result of operation (mostly usable for tests). + * @throws Exception If error occur. + */ + public <R> R invoke(IgniteLogger log, boolean verbose) throws Exception { + try (GridClient client = startClient(clientCfg)) { + String deprecationMsg = cmd.deprecationMessage(arg); + + if (deprecationMsg != null) + log.warning(deprecationMsg); + + R res; + + if (cmd instanceof LocalCommand) + res = ((LocalCommand<A, R>)cmd).execute(client, arg, log::info); + else if (cmd instanceof ComputeCommand) { + GridClientCompute compute = client.compute(); + + Map<UUID, GridClientNode> nodes = compute.nodes().stream() + .collect(toMap(GridClientNode::nodeId, n -> n)); + + ComputeCommand<A, R> cmd = (ComputeCommand<A, R>)this.cmd; + + Collection<UUID> cmdNodes = cmd.nodes(nodes, arg); + + if (cmdNodes == null) + cmdNodes = singleton(defaultNode(client, clientCfg).nodeId()); + + for (UUID id : cmdNodes) { + if (!nodes.containsKey(id)) + throw new IllegalArgumentException("Node with id=" + id + " not found."); + } + + Collection<GridClientNode> connectable = F.viewReadOnly( + cmdNodes, + nodes::get, + id -> nodes.get(id).connectable() + ); + + if (!F.isEmpty(connectable)) + compute = compute.projection(connectable); + + res = compute.execute(cmd.taskClass().getName(), new VisorTaskArgument<>(cmdNodes, arg, false)); + + cmd.printResult(arg, res, log::info); + } + else + throw new IllegalArgumentException("Unknown command type: " + cmd); + + return res; + } + catch (Throwable e) { + log.error("Failed to perform operation."); + log.error(CommandLogger.errorMessage(e)); + + throw e; + } + } + + /** */ + public boolean prepare(IgniteLogger log) throws Exception { + if (!(cmd instanceof PreparableCommand)) + return true; + + try (GridClient client = startClient(clientCfg)) { + return ((PreparableCommand<A, ?>)cmd).prepare(client, arg, log::info); + } Review Comment: Yes. Method changed to `public boolean prepare(GridClient cli, A arg, Consumer<String> printer) throws GridClientException;`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
