[PR] IGNITE-24371 Pass isVolatile flag when creating a zone partition [ignite-3]

2025-04-04 Thread via GitHub
JAkutenshi opened a new pull request, #5465: URL: https://github.com/apache/ignite-3/pull/5465 JIRA Ticket: [IGNITE-24371](https://issues.apache.org/jira/browse/IGNITE-24371) ## The goal ## The reason ## The solution -- This is an automated message from the Apache Git

[PR] IGNITE-24855 Adopt CatalogCompactionRunnerSelfTest for colocation track [ignite-3]

2025-04-04 Thread via GitHub
sk0x50 opened a new pull request, #5448: URL: https://github.com/apache/ignite-3/pull/5448 https://issues.apache.org/jira/browse/IGNITE-24855 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-04 Thread via GitHub
zstan commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2015671324 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -700,34 +700,48 @@ private void checkIntegerLimit(@Nulla

Re: [PR] IGNITE-24949 Refactor createTableLocally [ignite-3]

2025-04-04 Thread via GitHub
rpuch commented on code in PR #5512: URL: https://github.com/apache/ignite-3/pull/5512#discussion_r2022568895 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -452,6 +439,7 @@ public class TableManager implements IgniteTablesIn

Re: [PR] IGNITE-24301 Sql schema. Fix Thin client protocol to use schema names [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov merged PR #5426: URL: https://github.com/apache/ignite-3/pull/5426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24371 Pass isVolatile flag when creating a zone partition [ignite-3]

2025-04-04 Thread via GitHub
JAkutenshi commented on code in PR #5465: URL: https://github.com/apache/ignite-3/pull/5465#discussion_r2011738951 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneInMemoryTest.java: ## @@ -0,0 +1,197 @@ +/* + * Licen

Re: [PR] IGNITE-24996 Sql. Improve OrderedMergePublisher performance [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on PR #5525: URL: https://github.com/apache/ignite-3/pull/5525#issuecomment-2766774372 TPC-H query SF=0.1 Before ``` Benchmark (fsync) (queryId) Mode Cnt ScoreError Units TpchBenchmark.runfalse 2 avgt 20 241.401 ± 0.920

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028612665 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1312,15 +1296,13 @@ public long re

Re: [PR] IGNITE-24751 SQL Calcite: Add thread pool starvation warning [ignite]

2025-04-04 Thread via GitHub
sonarqubecloud[bot] commented on PR #11980: URL: https://github.com/apache/ignite/pull/11980#issuecomment-2774835810 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24548 Enable speed-based throttling [ignite-3]

2025-04-04 Thread via GitHub
rpuch commented on code in PR #5474: URL: https://github.com/apache/ignite-3/pull/5474#discussion_r2020553000 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java: ## @@ -152,6 +152,8 @@ public class Checkpointer ext

Re: [PR] IGNITE-24840: Sql. Extend SQL logic test coverage for TIME types [ignite-3]

2025-04-04 Thread via GitHub
xtern merged PR #5553: URL: https://github.com/apache/ignite-3/pull/5553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25024 Remove async from SchemaManager#dropRegistryAsync [ignite-3]

2025-04-04 Thread via GitHub
sashapolo merged PR #5571: URL: https://github.com/apache/ignite-3/pull/5571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov merged PR #5572: URL: https://github.com/apache/ignite-3/pull/5572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [I] NullPointerException during Client Node Join in Apache Ignite 2.15.0 [ignite]

2025-04-04 Thread via GitHub
jamnaritesh commented on issue #11983: URL: https://github.com/apache/ignite/issues/11983#issuecomment-2778580371 just to add more info, if i retry the node join at a later point, it works fine. Can someone please guide me towards what could be wrong here? We are starting the server nodes i

Re: [PR] IGNITE-24979 Sql. Optimize row values conversion by sql engine to/from internal representation [ignite-3]

2025-04-04 Thread via GitHub
korlov42 commented on code in PR #5538: URL: https://github.com/apache/ignite-3/pull/5538#discussion_r2028297960 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -272,14 +272,73 @@ private static boolean hasConvertableFields(Re

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028606793 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListener.java: ## @@ -239,10 +239,24 @@ private Com

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028609217 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java: ## @@ -448,9 +446,9 @@ public void testDropTable() throws Exceptio

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sk0x50 commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028614673 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItAbstractColocationTest.java: ## @@ -301,6 +302,10 @@ static v

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028597581 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -565,23 +565,15 @@ public void put(

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028605320 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -565,23 +565,15 @@ public void put(

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028635613 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListener.java: ## @@ -239,10 +239,24 @@ private Com

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
rpuch commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028634283 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListener.java: ## @@ -239,10 +239,24 @@ private Complet

Re: [PR] IGNITE-24956 Enhance SQL_PLANS_HISTORY Documentation with Performance… [ignite]

2025-04-04 Thread via GitHub
asfgit closed pull request #11979: IGNITE-24956 Enhance SQL_PLANS_HISTORY Documentation with Performance… URL: https://github.com/apache/ignite/pull/11979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] IGNITE-25011 Make IgniteNameUtils.quoteIfNeeded consistent with parse methods. [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov merged PR #5559: URL: https://github.com/apache/ignite-3/pull/5559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028660287 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java: ## @@ -448,9 +446,9 @@ public void testDropTable() throws Exceptio

[PR] IGNITE-25012 Extract GridToStringBuilder Unsafe code to interface [ignite]

2025-04-04 Thread via GitHub
nizhikov opened a new pull request, #11982: URL: https://github.com/apache/ignite/pull/11982 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24976 Sql. Optimize sql row serialization [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on code in PR #5536: URL: https://github.com/apache/ignite-3/pull/5536#discussion_r2028555813 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ProjectedTuple.java: ## @@ -45,49 +41,47 @@ public class FormatAwareProjectedTuple ex

Re: [PR] IGNITE-25012 Extract GridToStringBuilder Unsafe code to interface [ignite]

2025-04-04 Thread via GitHub
sonarqubecloud[bot] commented on PR #11982: URL: https://github.com/apache/ignite/pull/11982#issuecomment-2778266087 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028566082 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1281,8 +1273,6 @@ private Set col

[PR] IGNITE-25024 Remove async from SchemaManager#dropRegistryAsync [ignite-3]

2025-04-04 Thread via GitHub
sashapolo opened a new pull request, #5571: URL: https://github.com/apache/ignite-3/pull/5571 https://issues.apache.org/jira/browse/IGNITE-25024 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24708 Sql. Improve CREATE ZONE syntax [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on code in PR #5451: URL: https://github.com/apache/ignite-3/pull/5451#discussion_r2028751687 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlZoneOption.java: ## @@ -18,19 +18,34 @@ package org.apache.ignite.internal.s

[PR] IGNITE-25020 Fix NPE in TableManagerTest when colocation is enabled [ignite-3]

2025-04-04 Thread via GitHub
sk0x50 opened a new pull request, #5570: URL: https://github.com/apache/ignite-3/pull/5570 https://issues.apache.org/jira/browse/IGNITE-25020 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an

Re: [PR] IGNITE-22489 Add units suffix to all configuration values [ignite-3]

2025-04-04 Thread via GitHub
Pochatkin merged PR #5541: URL: https://github.com/apache/ignite-3/pull/5541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[I] NullPointerException during Client Node Join in Apache Ignite 2.15.0 [ignite]

2025-04-04 Thread via GitHub
jamnaritesh opened a new issue, #11983: URL: https://github.com/apache/ignite/issues/11983 NullPointerException during Client Node Join in Apache Ignite 2.15.0 **Environment:** Apache Ignite Version: 2.15.0 Cluster Size: 14 server nodes, 4 client nodes Deployment: Dockerized n

[PR] IGNITE-24996 Notify failure handler instead of logging errors [ignite-3]

2025-04-04 Thread via GitHub
rpuch opened a new pull request, #5574: URL: https://github.com/apache/ignite-3/pull/5574 https://issues.apache.org/jira/browse/IGNITE-24996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov opened a new pull request, #5572: URL: https://github.com/apache/ignite-3/pull/5572 https://issues.apache.org/jira/browse/IGNITE-25031 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24976 Sql. Optimize sql row serialization [ignite-3]

2025-04-04 Thread via GitHub
korlov42 commented on code in PR #5536: URL: https://github.com/apache/ignite-3/pull/5536#discussion_r2028242283 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/UpgradeRowBenchmark.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028574970 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -565,23 +565,17 @@ public void put(

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
rpuch commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028572841 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java: ## @@ -669,6 +671,28 @@ public void

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo merged PR #5568: URL: https://github.com/apache/ignite-3/pull/5568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028640638 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java: ## @@ -448,9 +446,9 @@ public void testDropTable() throws Exceptio

[PR] IGNITE-25038 Increase await timeouts in ItLearnersTest [ignite-3]

2025-04-04 Thread via GitHub
sashapolo opened a new pull request, #5573: URL: https://github.com/apache/ignite-3/pull/5573 https://issues.apache.org/jira/browse/IGNITE-25038 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] Ignite-23251 : Calcite. Validate number of passed query parameters. [ignite]

2025-04-04 Thread via GitHub
asfgit closed pull request #11547: Ignite-23251 : Calcite. Validate number of passed query parameters. URL: https://github.com/apache/ignite/pull/11547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] IGNITE-25042 Fix build [ignite-3]

2025-04-04 Thread via GitHub
valepakh opened a new pull request, #5575: URL: https://github.com/apache/ignite-3/pull/5575 https://issues.apache.org/jira/browse/IGNITE-25042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump netty from 4.1.119.Final to 4.2.0.Final [ignite-3]

2025-04-04 Thread via GitHub
dependabot[bot] opened a new pull request, #5576: URL: https://github.com/apache/ignite-3/pull/5576 Bumps `netty` from 4.1.119.Final to 4.2.0.Final. Updates `io.netty:netty-common` from 4.1.119.Final to 4.2.0.Final Commits https://github.com/netty/netty/commit/09e64d259c99be8

[PR] Bump mockito from 5.16.1 to 5.17.0 [ignite-3]

2025-04-04 Thread via GitHub
dependabot[bot] opened a new pull request, #5577: URL: https://github.com/apache/ignite-3/pull/5577 Bumps `mockito` from 5.16.1 to 5.17.0. Updates `org.mockito:mockito-core` from 5.16.1 to 5.17.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito

Re: [PR] IGNITE-25042 Fix build [ignite-3]

2025-04-04 Thread via GitHub
Pochatkin merged PR #5575: URL: https://github.com/apache/ignite-3/pull/5575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [I] NullPointerException during Client Node Join in Apache Ignite 2.15.0 [ignite]

2025-04-04 Thread via GitHub
ptupitsyn commented on issue #11983: URL: https://github.com/apache/ignite/issues/11983#issuecomment-2778732652 Does it happen in more recent versions (Ignite 2.17)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] IGNITE-22485 Rename deployment.deploymentLocation config value to deployment.location [ignite-3]

2025-04-04 Thread via GitHub
Pochatkin merged PR #5543: URL: https://github.com/apache/ignite-3/pull/5543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24979 Sql. Optimize row values conversion by sql engine to/from internal representation [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on code in PR #5538: URL: https://github.com/apache/ignite-3/pull/5538#discussion_r2028651947 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java: ## @@ -272,14 +272,73 @@ private static boolean hasConvertableFields(

Re: [PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
rpuch commented on code in PR #5568: URL: https://github.com/apache/ignite-3/pull/5568#discussion_r2028635544 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java: ## @@ -448,9 +446,9 @@ public void testDropTable() throws Exception {

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028643515 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1312,15 +1296,13 @@ public long re

Re: [PR] IGNITE-25031 Remove unnecessary locks from some meta-storage operations [ignite-3]

2025-04-04 Thread via GitHub
ibessonov commented on code in PR #5572: URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028575756 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1281,8 +1273,6 @@ private Set col

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-04 Thread via GitHub
ptupitsyn commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020784912 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -124,11 +256,26 @@ public CompletableFuture rollbackAsync() {

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-04 Thread via GitHub
ptupitsyn commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2024215742 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java: ## @@ -391,24 +413,47 @@ public static TableNotFoundE

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-04 Thread via GitHub
ascherbakoff commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020560108 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java: ## @@ -391,24 +413,47 @@ public static TableNotFou

Re: [PR] IGNITE-24970 Fix wheels building by GitHub Actions [ignite-3]

2025-04-04 Thread via GitHub
isapego merged PR #5528: URL: https://github.com/apache/ignite-3/pull/5528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-22487 Remove compute.threadPoolStopTimeoutMillis config value [ignite-3]

2025-04-04 Thread via GitHub
Pochatkin merged PR #5539: URL: https://github.com/apache/ignite-3/pull/5539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24859 Fixed scripts and fonts load, search and bugyard [ignite-website]

2025-04-04 Thread via GitHub
Daikon5 closed pull request #223: IGNITE-24859 Fixed scripts and fonts load, search and bugyard URL: https://github.com/apache/ignite-website/pull/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-24811 Fix restoration of empty tables storages for zone-based colocation [ignite-3]

2025-04-04 Thread via GitHub
sanpwc commented on code in PR #5424: URL: https://github.com/apache/ignite-3/pull/5424#discussion_r2020628245 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -1109,8 +1110,11 @@ private void sendSafeTimeSyncIfReplicaReady(Co

Re: [PR] IGNITE-24561 Add lightweight client-side tx coordination [ignite-3]

2025-04-04 Thread via GitHub
ptupitsyn commented on code in PR #5383: URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020628588 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java: ## @@ -321,9 +342,9 @@ public static void writeTx(@Nullable Transaction tx,

[I] Automatic Node Discovery fails in .NET Client with HTTPS enabled [ignite]

2025-04-04 Thread via GitHub
martinsuchan opened a new issue, #11960: URL: https://github.com/apache/ignite/issues/11960 We've discovered a bug in Ignite 2.15-2.17 if `EnableClusterDiscovery` property is set in .NET Client when connecting to a cluster with HTTPS enabled on each host. If we try to connect form .NET T

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-04 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022717208 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [I] NullPointerException during Client Node Join in Apache Ignite 2.15.0 [ignite]

2025-04-04 Thread via GitHub
jamnaritesh commented on issue #11983: URL: https://github.com/apache/ignite/issues/11983#issuecomment-2779513760 Hey @ptupitsyn thanks for your response. I'm using an internal wrapper on top of Ignite, so did not get a chance to test it out yet with 2.17.0. Did we fix this as a part

[PR] IGNITE-24751 SQL Calcite: Add thread pool starvation warning [ignite]

2025-04-04 Thread via GitHub
alex-plekhanov opened a new pull request, #11980: URL: https://github.com/apache/ignite/pull/11980 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

Re: [PR] IGNITE-24702 Fix of CompactedException on the end of rebalancing [ignite-3]

2025-04-04 Thread via GitHub
denis-chudov commented on code in PR #5468: URL: https://github.com/apache/ignite-3/pull/5468#discussion_r2024992367 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItDistributionZoneMetaStorageCompactionTest.java: ## @@ -130,6

Re: [PR] IGNITE-24548 Enable speed-based throttling [ignite-3]

2025-04-04 Thread via GitHub
ibessonov merged PR #5474: URL: https://github.com/apache/ignite-3/pull/5474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2026551392 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java: ## @@ -89,19 +93,30 @@ public void push(RowT row) throws Exceptio

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-04-04 Thread via GitHub
slukyano commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r2000633612 ## docs/_docs/administrators-guide/lifecycle.adoc: ## @@ -40,7 +40,15 @@ First, the nodes specified in the `--cluster-management-group` argument form a R image::i

Re: [PR] IGNITE-15803 Remove setMarshaller from tests [ignite]

2025-04-04 Thread via GitHub
nizhikov commented on code in PR #11938: URL: https://github.com/apache/ignite/pull/11938#discussion_r2003696056 ## modules/core/src/test/java/org/apache/ignite/internal/marshaller/optimized/OptimizedMarshallerSelfTest.java: ## @@ -36,8 +39,17 @@ @GridCommonTest(group = "Marsha

[PR] IGNITE-24397 Add tests for table removal for colocation [ignite-3]

2025-04-04 Thread via GitHub
sashapolo opened a new pull request, #5568: URL: https://github.com/apache/ignite-3/pull/5568 https://issues.apache.org/jira/browse/IGNITE-24397 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24997 Adapt runner test for the colocation track [ignite-3]

2025-04-04 Thread via GitHub
sk0x50 merged PR #5551: URL: https://github.com/apache/ignite-3/pull/5551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-24753 SQL Calcite: Fix freeze in MergeJoin right/full execution nodes [ignite]

2025-04-04 Thread via GitHub
sonarqubecloud[bot] commented on PR #11955: URL: https://github.com/apache/ignite/pull/11955#issuecomment-2741306494 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

[PR] IGNITE-24941 IgniteUtils initial cleanup [ignite]

2025-04-04 Thread via GitHub
shishkovilja opened a new pull request, #11976: URL: https://github.com/apache/ignite/pull/11976 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

[PR] IGNITE-24736 Fix invalid IgniteTestUtils.randomString function [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov opened a new pull request, #5469: URL: https://github.com/apache/ignite-3/pull/5469 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24751 SQL Calcite: Add thread pool starvation warning [ignite]

2025-04-04 Thread via GitHub
sonarqubecloud[bot] commented on PR #11980: URL: https://github.com/apache/ignite/pull/11980#issuecomment-2775300874 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24227 Sql. Improve type checking in LIMIT / OFFSET clauses [ignite-3]

2025-04-04 Thread via GitHub
AMashenkov commented on code in PR #5479: URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2026549199 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java: ## @@ -136,6 +153,6 @@ protected Downstream requestDownstream(int

Re: [PR] IGNITE-23439 C++: Implement query cancellation [ignite-3]

2025-04-04 Thread via GitHub
mpoeter commented on code in PR #5532: URL: https://github.com/apache/ignite-3/pull/5532#discussion_r2022699155 ## modules/platforms/cpp/ignite/client/detail/cancellation_token_impl.cpp: ## @@ -0,0 +1,121 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-24624 : Calcite. Heuristics of join order. [ignite]

2025-04-04 Thread via GitHub
alex-plekhanov commented on code in PR #11935: URL: https://github.com/apache/ignite/pull/11935#discussion_r2016410984 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/PlannerHelper.java: ## @@ -490,32 +523,86 @@ private boolean modify

Re: [I] Automatic Node Discovery fails in .NET Client with HTTPS enabled [ignite]

2025-04-04 Thread via GitHub
martinsuchan commented on issue #11960: URL: https://github.com/apache/ignite/issues/11960#issuecomment-2776206226 Update, the same error is also logged when using this property in .NET Thin client and using HTTPS on server: `IgniteClientConfiguration.EnableHeartbeats = true` even when

Re: [PR] IGNITE-25019 Remove unneeded future from ClusterManagementGroupManager [ignite-3]

2025-04-04 Thread via GitHub
Copilot commented on code in PR #5567: URL: https://github.com/apache/ignite-3/pull/5567#discussion_r2026917917 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -648,9 +649,10 @@ private Completab

[PR] [POC] .NET Native Compute [ignite-3]

2025-04-04 Thread via GitHub
ptupitsyn opened a new pull request, #5556: URL: https://github.com/apache/ignite-3/pull/5556 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e