sashapolo commented on code in PR #5572:
URL: https://github.com/apache/ignite-3/pull/5572#discussion_r2028566082
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1281,8 +1273,6 @@ private Set<UpdateOnlyRevisionEvent>
collectUpdateRevisionEventsFromStorage(long
@Override
public HybridTimestamp timestampByRevision(long revision) {
- rwLock.readLock().lock();
-
try {
assertRequestedRevisionLessThanOrEqualToCurrent(revision, rev);
Review Comment:
We are accessing a non-volatile field here, are you sure this is safe?
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1395,16 +1379,12 @@ protected void saveCompactionRevision(long revision,
KeyValueUpdateContext conte
@Override
public long checksum(long revision) {
- rwLock.readLock().lock();
-
try {
assertRequestedRevisionLessThanOrEqualToCurrent(revision, rev);
Review Comment:
Same question
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -565,23 +565,17 @@ public void put(byte[] key, byte[] value,
KeyValueUpdateContext context) {
@Override
public void setIndexAndTerm(long index, long term) {
- rwLock.writeLock().lock();
-
try (WriteBatch batch = new WriteBatch()) {
Review Comment:
Why do we even need a batch here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
