[PR] IGNITE-24785 Implement test of enter a node with an index greater than the current majority [ignite-3]

2025-03-13 Thread via GitHub
tkalkirill opened a new pull request, #5406: URL: https://github.com/apache/ignite-3/pull/5406 https://issues.apache.org/jira/browse/IGNITE-24785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

2025-03-13 Thread via GitHub
zstan merged PR #5380: URL: https://github.com/apache/ignite-3/pull/5380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5401: URL: https://github.com/apache/ignite-3/pull/5401#discussion_r1993738872 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientPrimaryReplicaTracker.java: ## @@ -247,11 +253,26 @@ private PrimaryReplicasResult primary

Re: [PR] IGNITE-24721 SQL Calcite: Fix distribution for rehashing to the right… [ignite]

2025-03-13 Thread via GitHub
asfgit closed pull request #11913: IGNITE-24721 SQL Calcite: Fix distribution for rehashing to the right… URL: https://github.com/apache/ignite/pull/11913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5401: URL: https://github.com/apache/ignite-3/pull/5401#discussion_r1993744954 ## modules/client/src/test/java/org/apache/ignite/client/PartitionAwarenessTest.java: ## @@ -181,7 +185,7 @@ public void testNonNullTxDisablesPartitionAwareness() {

Re: [PR] IGNITE-24765 Sql. Reduce number of state checks in executions nodes [ignite-3]

2025-03-13 Thread via GitHub
AMashenkov commented on code in PR #5395: URL: https://github.com/apache/ignite-3/pull/5395#discussion_r1993500030 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/CorrelatedNestedLoopJoinExecutionTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed

Re: [PR] IGNITE-24765 Sql. Reduce number of state checks in executions nodes [ignite-3]

2025-03-13 Thread via GitHub
korlov42 commented on code in PR #5395: URL: https://github.com/apache/ignite-3/pull/5395#discussion_r1993462643 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java: ## @@ -31,12 +31,19 @@ * Abstract node of execution tree. */

Re: [PR] IGNITE-24765 Sql. Reduce number of state checks in executions nodes [ignite-3]

2025-03-13 Thread via GitHub
AMashenkov commented on code in PR #5395: URL: https://github.com/apache/ignite-3/pull/5395#discussion_r1993500030 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/CorrelatedNestedLoopJoinExecutionTest.java: ## @@ -0,0 +1,315 @@ +/* + * Licensed

Re: [PR] IGNITE-24669 Set H2 default SQL plan history to zero [ignite]

2025-03-13 Thread via GitHub
asfgit closed pull request #11903: IGNITE-24669 Set H2 default SQL plan history to zero URL: https://github.com/apache/ignite/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

2025-03-13 Thread via GitHub
ygerzhedovich commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1993591998 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -746,9 +746,9 @@ public void charLimitationWithM

Re: [PR] Ignite-23772 : Calcite. Incorrect processing of old date literals. [ignite]

2025-03-13 Thread via GitHub
Vladsz83 commented on code in PR #11822: URL: https://github.com/apache/ignite/pull/11822#discussion_r1993525343 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DateTimeTest.java: ## @@ -202,6 +203,67 @@ public void testDstShift()

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1993686745 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -239,6 +241,7 @@ public void testTableIgnoredOnRecovery(

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

2025-03-13 Thread via GitHub
ygerzhedovich merged PR #5357: URL: https://github.com/apache/ignite-3/pull/5357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5401: URL: https://github.com/apache/ignite-3/pull/5401#discussion_r1993707946 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadWriteScanTest.java: ## @@ -38,6 +40,7 @@ /** * Tests for {@link InternalTab

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

2025-03-13 Thread via GitHub
lowka commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1993491396 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogSystemViewDescriptorSerializers.java: ## @@ -76,4 +77,39 @@ public void writeTo(Ca

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

2025-03-13 Thread via GitHub
lowka commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1993490362 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogStorageProfilesDescriptorSerializers.java: ## @@ -55,11 +56,34 @@ public CatalogSt

Re: [PR] IGNITE-24762 Support zone partitions in unit tests of ignite-table [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5391: URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1993687659 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java: ## @@ -206,6 +207,7 @@ void after() throws Exception { }

Re: [PR] IGNITE-24773. Calcite. IgniteReduceSortAggregate misses collation. [ignite]

2025-03-13 Thread via GitHub
asfgit closed pull request #11940: IGNITE-24773. Calcite. IgniteReduceSortAggregate misses collation. URL: https://github.com/apache/ignite/pull/11940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

2025-03-13 Thread via GitHub
ibessonov commented on code in PR #5403: URL: https://github.com/apache/ignite-3/pull/5403#discussion_r1992902653 ## modules/metastorage-cache/src/main/java/org/apache/ignite/internal/metastorage/cache/IdempotentCacheVacuumizer.java: ## @@ -113,8 +112,10 @@ public CompletableFut

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

2025-03-13 Thread via GitHub
rpuch commented on code in PR #5401: URL: https://github.com/apache/ignite-3/pull/5401#discussion_r1993753329 ## modules/client-handler/src/testFixtures/java/org/apache/ignite/client/handler/FakeCatalogService.java: ## @@ -53,7 +53,7 @@ public FakeCatalogService(int partitions)

Re: [PR] Ignite-23772 : Calcite. Incorrect processing of old date literals. [ignite]

2025-03-13 Thread via GitHub
Vladsz83 commented on code in PR #11822: URL: https://github.com/apache/ignite/pull/11822#discussion_r1993565473 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteRexBuilder.java: ## @@ -62,6 +74,97 @@ public IgniteRexBuilder(Rel

Re: [PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

2025-03-13 Thread via GitHub
korlov42 commented on code in PR #5357: URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1993456047 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -746,9 +746,9 @@ public void charLimitationWithMergeU

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-13 Thread via GitHub
slukyano commented on PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#issuecomment-2722782072 @sashapolo Could you please check again? I think I've addressed everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] IGNITE-24669 Set H2 default SQL plan history to zero [ignite]

2025-03-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #11903: URL: https://github.com/apache/ignite/pull/11903#issuecomment-2721637439 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-24768 Support per-zone partitions in client handler [ignite-3]

2025-03-13 Thread via GitHub
rpuch merged PR #5401: URL: https://github.com/apache/ignite-3/pull/5401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-24790 Fix race in meta-storage compaction [ignite-3]

2025-03-13 Thread via GitHub
ibessonov opened a new pull request, #5405: URL: https://github.com/apache/ignite-3/pull/5405 https://issues.apache.org/jira/browse/IGNITE-24790 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

2025-03-13 Thread via GitHub
ibessonov commented on code in PR #5403: URL: https://github.com/apache/ignite-3/pull/5403#discussion_r1992902653 ## modules/metastorage-cache/src/main/java/org/apache/ignite/internal/metastorage/cache/IdempotentCacheVacuumizer.java: ## @@ -113,8 +112,10 @@ public CompletableFut

[PR] IGNITE-24787 Fix "Lease update" message frequency [ignite-3]

2025-03-13 Thread via GitHub
ibessonov opened a new pull request, #5404: URL: https://github.com/apache/ignite-3/pull/5404 https://issues.apache.org/jira/browse/IGNITE-24787 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24484 RAFT heartbeat coalescing [ignite-3]

2025-03-13 Thread via GitHub
vldpyatkov commented on code in PR #5221: URL: https://github.com/apache/ignite-3/pull/5221#discussion_r1992946478 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/NodeManager.java: ## @@ -14,24 +14,158 @@ * See the License for the specific language governing permiss

Re: [PR] IGNITE-24784 Fix eviction timestamp calculation in idempotent cache vacuumizer [ignite-3]

2025-03-13 Thread via GitHub
ibessonov merged PR #5403: URL: https://github.com/apache/ignite-3/pull/5403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24787 Fix "Lease update" message frequency [ignite-3]

2025-03-13 Thread via GitHub
ibessonov merged PR #5404: URL: https://github.com/apache/ignite-3/pull/5404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24782 Initial commit for ignite-commons [ignite]

2025-03-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #11942: URL: https://github.com/apache/ignite/pull/11942#issuecomment-2720308769 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

2025-03-13 Thread via GitHub
zstan commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1992954671 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateTableImpl.java: ## @@ -123,18 +115,6 @@ CreateTableImpl zone(String zone) { re

Re: [PR] IGNITE-24790 Fix race in meta-storage compaction [ignite-3]

2025-03-13 Thread via GitHub
tkalkirill commented on code in PR #5405: URL: https://github.com/apache/ignite-3/pull/5405#discussion_r1993072639 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/BasicOperationsKeyValueStorageTest.java: ## @@ -2284,6 +2287,58 @@ void testNoti

[PR] IGNITE-24780 Binary API initial commit [ignite]

2025-03-13 Thread via GitHub
nizhikov opened a new pull request, #11945: URL: https://github.com/apache/ignite/pull/11945 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-24196 Sql. Merge projection into join node [ignite-3]

2025-03-13 Thread via GitHub
korlov42 commented on code in PR #5398: URL: https://github.com/apache/ignite-3/pull/5398#discussion_r1993257375 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java: ## @@ -1104,4 +1123,38 @@ private static BinaryTupleSchema

Re: [PR] IGNITE-24294 IgniteCatalog API. Table's IndexDefinition reports incorrect name/sorting of index column [ignite-3]

2025-03-13 Thread via GitHub
lowka commented on code in PR #5380: URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1993270067 ## modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateTableImpl.java: ## @@ -123,18 +115,6 @@ CreateTableImpl zone(String zone) { re

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

2025-03-13 Thread via GitHub
AMashenkov commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1993260917 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogStorageProfilesDescriptorSerializers.java: ## @@ -55,11 +56,34 @@ public Cata

Re: [PR] IGNITE-24790 Fix race in meta-storage compaction [ignite-3]

2025-03-13 Thread via GitHub
ibessonov merged PR #5405: URL: https://github.com/apache/ignite-3/pull/5405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24698 Add new catalog serializers that conform with the new serialization protocol [ignite-3]

2025-03-13 Thread via GitHub
AMashenkov commented on code in PR #5373: URL: https://github.com/apache/ignite-3/pull/5373#discussion_r1993277463 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogSystemViewDescriptorSerializers.java: ## @@ -76,4 +77,39 @@ public void write

Re: [PR] IGNITE-24765 Sql. Reduce number of state checks in executions nodes [ignite-3]

2025-03-13 Thread via GitHub
zstan commented on code in PR #5395: URL: https://github.com/apache/ignite-3/pull/5395#discussion_r1993277118 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -155,6 +155,25 @@ private InnerHashJoin( super(c