korlov42 commented on code in PR #5395:
URL: https://github.com/apache/ignite-3/pull/5395#discussion_r1993462643
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java:
##########
@@ -31,12 +31,19 @@
* Abstract node of execution tree.
*/
public abstract class AbstractNode<RowT> implements Node<RowT> {
+ /** Special value to highlights that all row were received and we are not
waiting any more. */
Review Comment:
```suggestion
/** Special value to highlight that all row were received and we do not
expect more. */
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AsyncRootNode.java:
##########
@@ -37,6 +37,9 @@
* An async iterator over the execution tree.
*/
public class AsyncRootNode<InRowT, OutRowT> implements Downstream<InRowT>,
AsyncCursor<OutRowT> {
+ /** Special value to highlights that all row were received and we are not
waiting any more. */
+ private static final int NOT_WAITING = -1;
Review Comment:
perhaps, it would be better to make `AbstractNode#NOT_WAITING` package
private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
