zstan commented on code in PR #5380:
URL: https://github.com/apache/ignite-3/pull/5380#discussion_r1992954671
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateTableImpl.java:
##########
@@ -123,18 +115,6 @@ CreateTableImpl zone(String zone) {
return this;
}
- CreateTableImpl addIndex(String name, String columnList) {
- return addIndex(name, null, columnList);
- }
-
- CreateTableImpl addIndex(String name, IndexType type, String columnList) {
- return addIndex(name, type, parseIndexColumnList(columnList));
- }
-
- CreateTableImpl addIndex(String name, IndexType type, ColumnSorted...
columns) {
- return addIndex(name, type, asList(columns));
- }
-
CreateTableImpl addIndex(String name, IndexType type, List<ColumnSorted>
columns) {
Objects.requireNonNull(name, "Index name must not be null.");
Objects.requireNonNull(columns, "Index columns list must not be
null.");
Review Comment:
i suppose it also can`t be an empty ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
