Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-06 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1830841403 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +177,66 @@ public void te

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-06 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1831480547 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +177,66 @@ public void te

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
sonarcloud[bot] commented on PR #11645: URL: https://github.com/apache/ignite/pull/11645#issuecomment-2460603758 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831566293 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -795,20 +788,11 @@ private GridCloseableIterator> s

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831600943 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -869,36 +852,6 @@ private GridCloseableIterator scan

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
sonarcloud[bot] commented on PR #11645: URL: https://github.com/apache/ignite/pull/11645#issuecomment-2460628082 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23591 Fix entry and checkpoint locks orders [ignite]

2024-11-06 Thread via GitHub
alex-plekhanov commented on code in PR #11641: URL: https://github.com/apache/ignite/pull/11641#discussion_r1831648466 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/ConcurrentCheckpointAndUpdateTtlTest.java: ## @@ -0,0 +1,177 @@ +/* + * Licensed to th

Re: [PR] IGNITE-23549 Flush Metastorage underlying storage to disk after taking snapshot [ignite-3]

2024-11-06 Thread via GitHub
tkalkirill merged PR #4679: URL: https://github.com/apache/ignite-3/pull/4679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-23600 Extend GLOBAL_PARTITION_STATES and LOCAL_PARTITION_STATES system views [ignite-3]

2024-11-06 Thread via GitHub
Phillippko opened a new pull request, #4681: URL: https://github.com/apache/ignite-3/pull/4681 https://issues.apache.org/jira/browse/IGNITE-23600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-06 Thread via GitHub
skorotkov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1830734841 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

[PR] IGNITE-23571 resetPartitions improvements: do not try to recover replica factor after not anual reset [ignite-3]

2024-11-06 Thread via GitHub
alievmirza opened a new pull request, #4686: URL: https://github.com/apache/ignite-3/pull/4686 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-06 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1831129861 ## modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java: ## @@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function longMetric, Functi

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-06 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1831130233 ## modules/core/src/test/java/org/apache/ignite/cdc/AbstractCdcTest.java: ## @@ -269,6 +261,55 @@ private void checkMetrics(long expCnt, Function longMetric, Functi

Re: [PR] IGNITE-23430: Sql. Provide an ability to cancel query before first page ready [ignite-3]

2024-11-06 Thread via GitHub
korlov42 commented on code in PR #4615: URL: https://github.com/apache/ignite-3/pull/4615#discussion_r1830970865 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/lang/ItQueryCancelTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation

[PR] IGNITE-22759 Do not do partition SafeTime sync if previous attempt is not finished [ignite-3]

2024-11-06 Thread via GitHub
rpuch opened a new pull request, #4684: URL: https://github.com/apache/ignite-3/pull/4684 https://issues.apache.org/jira/browse/IGNITE-22759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23618 Fix dead lock when restoring metastorage [ignite-3]

2024-11-06 Thread via GitHub
tkalkirill merged PR #4682: URL: https://github.com/apache/ignite-3/pull/4682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23600 Extend GLOBAL_PARTITION_STATES and LOCAL_PARTITION_STATES system views [ignite-3]

2024-11-06 Thread via GitHub
ivanzlenko commented on code in PR #4681: URL: https://github.com/apache/ignite-3/pull/4681#discussion_r1830689233 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/recovery/partitions/states/ItPartitionStatesTest.java: ## @@ -262,15 +265,16 @@ void

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
alex-plekhanov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831180356 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java: ## @@ -3594,4 +3595,15 @@ public boolean uncommited

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-06 Thread via GitHub
kgusakov commented on code in PR #4667: URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1831171168 ## modules/catalog-dsl/src/test/java/org/apache/ignite/internal/catalog/sql/CreateFromAnnotationsTest.java: ## @@ -150,6 +151,29 @@ void createFromRecordClass() {

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-06 Thread via GitHub
skorotkov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1830878593 ## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[PR] Ignite-23523 Sql. Fixed incorrect time formatting in sql logic tests [ignite-3]

2024-11-06 Thread via GitHub
ygerzhedovich opened a new pull request, #4683: URL: https://github.com/apache/ignite-3/pull/4683 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

[PR] IGNITE-23134 Add transactional benchmarks to measure operations with lock conficts [ignite-3]

2024-11-06 Thread via GitHub
denis-chudov opened a new pull request, #4685: URL: https://github.com/apache/ignite-3/pull/4685 TxUpsertRetryOperationBenchmark ``` Benchmark (fsync) (keysUpperBound) (txRetryMode) Mode CntScore Error Units TxUpsertRetryOperation

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-06 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1830983486 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java: ## @@ -409,4 +413,31 @@ public int hashCode() {

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-06 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1830981442 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java: ## @@ -409,4 +413,31 @@ public int hashCode() {

Re: [PR] IGNITE-23594 WIP [ignite]

2024-11-06 Thread via GitHub
sonarcloud[bot] commented on PR #11642: URL: https://github.com/apache/ignite/pull/11642#issuecomment-2459137323 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-06 Thread via GitHub
AMashenkov commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1830982554 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java: ## @@ -409,4 +413,31 @@ public int hashCode() {

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-06 Thread via GitHub
skorotkov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1830716285 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlInputStreamWrapper.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-06 Thread via GitHub
skorotkov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1830734841 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

Re: [PR] Ignite-23523 Sql. Fixed incorrect time formatting in sql logic tests [ignite-3]

2024-11-06 Thread via GitHub
ygerzhedovich commented on PR #4683: URL: https://github.com/apache/ignite-3/pull/4683#issuecomment-2459647473 After merging the ticket should be closed following tickets: https://issues.apache.org/jira/browse/IGNITE-19804 https://issues.apache.org/jira/browse/IGNITE-18362 -- This is

Re: [PR] IGNITE-23282 Clear the VersionedValue after metastorage compaction is completed [ignite-3]

2024-11-06 Thread via GitHub
tkalkirill commented on code in PR #4671: URL: https://github.com/apache/ignite-3/pull/4671#discussion_r1830612006 ## modules/schema/src/test/java/org/apache/ignite/internal/schema/SchemaManagerTest.java: ## @@ -72,14 +71,12 @@ class SchemaManagerTest extends BaseIgniteAbstractT

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-06 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1830838961 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +177,66 @@ public void te

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-06 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1830841403 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +177,66 @@ public void te

Re: [PR] IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) [ignite]

2024-11-06 Thread via GitHub
shishkovilja commented on code in PR #11512: URL: https://github.com/apache/ignite/pull/11512#discussion_r1831469849 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxWithKeyContentionSelfTest.java: ## @@ -216,120 +177,66 @@ public void te

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831561617 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java: ## @@ -3594,4 +3595,15 @@ public boolean uncommitedTx(fin

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831566293 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -795,20 +788,11 @@ private GridCloseableIterator> s

Re: [PR] IGNITE-23516 : Calcite. Unify rounding of numerics. [ignite]

2024-11-06 Thread via GitHub
Vladsz83 commented on PR #11635: URL: https://github.com/apache/ignite/pull/11635#issuecomment-2461548638 #implemented in 11644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
alex-plekhanov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1832196985 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/ScanQueryIterator.java: ## @@ -0,0 +1,460 @@ +/* + * Licensed to the Apache Soft

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

2024-11-06 Thread via GitHub
sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2461541569 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22969 Sql. Gather execution nodes information from Placement driver [ignite-3]

2024-11-06 Thread via GitHub
zstan merged PR #4629: URL: https://github.com/apache/ignite-3/pull/4629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23449 Add support of the new flag HA in zone description [ignite-3]

2024-11-06 Thread via GitHub
vldpyatkov merged PR #4667: URL: https://github.com/apache/ignite-3/pull/4667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

2024-11-06 Thread via GitHub
timoninmaxim commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1832180105 ## modules/core/src/test/java/org/apache/ignite/logger/java/JavaLoggerTest.java: ## @@ -17,31 +17,154 @@ package org.apache.ignite.logger.java; +import java.

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831571510 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -869,36 +852,6 @@ private GridCloseableIterator scan

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831571510 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -869,36 +852,6 @@ private GridCloseableIterator scan

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831586024 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/ScanQueryIterator.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software F

Re: [PR] IGNITE-23554 ScanQuery code cleanup [ignite]

2024-11-06 Thread via GitHub
nizhikov commented on code in PR #11645: URL: https://github.com/apache/ignite/pull/11645#discussion_r1831571510 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java: ## @@ -869,36 +852,6 @@ private GridCloseableIterator scan

Re: [PR] IGNITE-23114 JDBC thin: add support for stream APIs for BLOB [ignite]

2024-11-06 Thread via GitHub
skorotkov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1830734841 ## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/SqlListenerUtils.java: ## @@ -246,12 +274,61 @@ else if (cls == Timestamp[].class)

[PR] IGNITE-23294 Handle Metastorage leader change case for Compaction Trigger [ignite-3]

2024-11-06 Thread via GitHub
tkalkirill opened a new pull request, #4687: URL: https://github.com/apache/ignite-3/pull/4687 https://issues.apache.org/jira/browse/IGNITE-23294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t