kgusakov commented on code in PR #4667:
URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1831171168
##########
modules/catalog-dsl/src/test/java/org/apache/ignite/internal/catalog/sql/CreateFromAnnotationsTest.java:
##########
@@ -150,6 +151,29 @@ void createFromRecordClass() {
);
}
+ @Test
+ void testDefinitionInvalid() {
+ ZoneDefinition zoneDefinition = ZoneDefinition.builder("zone_test")
+ .ifNotExists()
+ .partitions(1)
+ .replicas(3)
+ .distributionAlgorithm("partitionDistribution")
+ .dataNodesAutoAdjust(1)
+ .dataNodesAutoAdjustScaleDown(2)
+ .dataNodesAutoAdjustScaleUp(3)
+ .filter("filter")
+ .storageProfiles("default")
+ .consistencyMode("MY_CONSISTENCY")
+ .build();
+
+ assertThrows(IllegalArgumentException.class, () -> new
CreateFromDefinitionImpl(null).from(zoneDefinition));
Review Comment:
The better place for this test is the `CreateFromDefinitionTest`, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
