nizhikov commented on code in PR #11645:
URL: https://github.com/apache/ignite/pull/11645#discussion_r1831566293
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -795,20 +788,11 @@ private GridCloseableIterator<IgniteBiTuple<K, V>>
sharedCacheSetIterator(CacheQ
private GridCloseableIterator scanIterator(final CacheQuery<?> qry,
IgniteClosure transformer,
boolean locNode)
throws IgniteCheckedException {
- final InternalScanFilter<K, V> intFilter =
internalFilter(qry.scanFilter());
-
try {
Integer part = qry.partition();
if (part != null && (part < 0 || part >=
cctx.affinity().partitions()))
- return new GridEmptyCloseableIterator() {
- @Override public void close() throws
IgniteCheckedException {
- if (intFilter != null)
Review Comment:
~Because, here we don't allocate any resources.~
~It required and happens only inside `ScanQueryIterator`.~
~`ScanQueryIterator` correctly manage those resources inside.~
You are correct. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
