Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-04-05 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005161340 ## modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java: ## @@ -136,10 +136,10 @@ protected static Set readStringSet(IgniteDataI

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-04-05 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005057075 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java: ## @@ -486,39 +499,

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo merged PR #5443: URL: https://github.com/apache/ignite-3/pull/5443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005042931 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfo.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005169113 ## modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java: ## @@ -136,10 +136,10 @@ protected static Set readStringSet(IgniteData

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005161875 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfo.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005161875 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfo.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005159979 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvPartitionMeta.java: ## @@ -26,20 +27,50 @@ public class MvPartitionMeta extends Pri

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005158248 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvPartitionMeta.java: ## @@ -26,20 +27,50 @@ public class MvPartitionMeta extends Pr

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005149163 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java: ## @@ -486,39 +499

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005145051 ## modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java: ## @@ -136,10 +136,10 @@ protected static Set readStringSet(IgniteData

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005136710 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfoSerializer.java: ## @@ -0,0 +1,91 @@ +/* + *

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005112331 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfo.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005078134 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvPartitionMeta.java: ## @@ -26,20 +27,50 @@ public class MvPartitionMeta extends Pri

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005074766 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvPartitionMeta.java: ## @@ -26,20 +27,50 @@ public class MvPartitionMeta extends Pri

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005074766 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/MvPartitionMeta.java: ## @@ -26,20 +27,50 @@ public class MvPartitionMeta extends Pri

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005072821 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/PartitionSnapshotInfoSerializer.java: ## @@ -0,0 +1,91 @@ +/* + *

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
sashapolo commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005069464 ## modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java: ## @@ -136,10 +136,10 @@ protected static Set readStringSet(IgniteDataI

Re: [PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-20 Thread via GitHub
tkalkirill commented on code in PR #5443: URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2004997930 ## modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java: ## @@ -136,10 +136,10 @@ protected static Set readStringSet(IgniteData

[PR] IGNITE-24838 Add ability to save snapshot information in TX storage [ignite-3]

2025-03-18 Thread via GitHub
sashapolo opened a new pull request, #5443: URL: https://github.com/apache/ignite-3/pull/5443 https://issues.apache.org/jira/browse/IGNITE-24838 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both