sashapolo commented on code in PR #5443:
URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005161340
##########
modules/core/src/main/java/org/apache/ignite/internal/versioned/VersionedSerializer.java:
##########
@@ -136,10 +136,10 @@ protected static Set<String>
readStringSet(IgniteDataInput in) throws IOExceptio
return result;
}
- protected static void writeVarIntSet(Set<Integer> partitionIds,
IgniteDataOutput out) throws IOException {
- out.writeVarInt(partitionIds.size());
+ protected static void writeVarIntSet(Set<Integer> varIntSet,
IgniteDataOutput out) throws IOException {
+ out.writeVarInt(varIntSet.size());
Review Comment:
> I think because +1 is done there to protect the recording of a negative
value and we can write 1 byte more than necessary in rare cases.
Makes sense, but nevertheless, let's do it in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
