tkalkirill commented on code in PR #5443:
URL: https://github.com/apache/ignite-3/pull/5443#discussion_r2005149163
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -486,39 +499,61 @@ private CompletableFuture<Void>
completeRebalance(PartitionSnapshotMeta meta, @N
setError(RaftError.UNKNOWN, throwable.getMessage());
}
- return abortRebalance().thenCompose(unused ->
failedFuture(throwable));
+ return abortRebalance(partitionsByTableId).thenCompose(unused
-> failedFuture(throwable));
}
- var raftGroupConfig = new RaftGroupConfiguration(
- meta.cfgIndex(),
- meta.cfgTerm(),
- meta.peersList(),
- meta.learnersList(),
- meta.oldPeersList(),
- meta.oldLearnersList()
- );
-
- LOG.info(
- "Copier completes the rebalancing of the partition: [{},
lastAppliedIndex={}, lastAppliedTerm={}, raftGroupConfig={}]",
- createPartitionInfo(),
- meta.lastIncludedIndex(),
- meta.lastIncludedTerm(),
- raftGroupConfig
- );
+ if (LOG.isInfoEnabled()) {
Review Comment:
I'm just suggesting that this is not necessary here, if you want to leave
it, I have no objections, you can resolve the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
