Re: Bug 2171

2015-03-09 Thread John-Mark Bell
On Mon, Mar 09, 2015 at 10:57:07PM +, Steve Fryatt wrote: > > Thanks -- I think I can see what's supposed to be happening now. It appears > to be libnsutils, which despite giving the following output when built > > steve@castlerigg:~/Development/NetSurf/workspace/libnsutils$ make >

Re: Bug 2171

2015-03-09 Thread Steve Fryatt
On 9 Mar, Vincent Sanders wrote in message <20150309204510.gj3...@kyllikki.org>: > I will take a look and merge if you are happy with all the RISC OS > changes? For Glen's fix? Yes, it looks fine. I've now managed to get NetSurf to link, and the all menus look OK; there weren't any code chang

Re: Bug 2171

2015-03-09 Thread Vincent Sanders
On Mon, Mar 09, 2015 at 08:19:30PM +, Steve Fryatt wrote: > On 9 Mar, Glen Walker wrote in message > <54fde1ce.8070...@mail.com>: > > > I have tried creating a git patch with the command below so that I could > > e-mail it to this mailing list but all I got was an empty file. > > > > > g

Re: Bug 2171

2015-03-09 Thread Steve Fryatt
On 9 Mar, Glen Walker wrote in message <54fde1ce.8070...@mail.com>: > I have tried creating a git patch with the command below so that I could > e-mail it to this mailing list but all I got was an empty file. > > > git format-patch master --stdout > bug2171.patch I think you need to commit

Re: Bug 2171

2015-03-09 Thread Glen Walker
Hello All, I have tried creating a git patch with the command below so that I could e-mail it to this mailing list but all I got was an empty file. > git format-patch master --stdout > bug2171.patch To progress things I have included the two files that I have modified to fix Bug 2171 but I w

Re: Some questions about submitting patches

2015-03-09 Thread Daniel Silverstone
On Mon, Mar 09, 2015 at 14:10:00 +, David Gee wrote: > From the documentation I know WHERE to submit them. I've also > looked at the coding standards, but I'd like to know: > > * What comments should be added to the source code if any, > in order to indicate changes made, by whom and why; T

Some questions about submitting patches

2015-03-09 Thread David Gee
Hi, I have some queries about submitting patches. From the documentation I know WHERE to submit them. I've also looked at the coding standards, but I'd like to know: * What comments should be added to the source code if any, in order to indicate changes made, by whom and why; * The form in w