RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

2021-04-20 Thread Salil Mehta
> From: Brelinski, TonyX [mailto:tonyx.brelin...@intel.com] > Sent: Tuesday, April 20, 2021 9:26 PM > > > From: Intel-wired-lan On Behalf Of > > Salil Mehta > > Sent: Tuesday, April 13, 2021 3:45 PM > > To: da...@davemloft.net; k...@kernel.org >

[PATCH net 0/2] Misc. fixes for hns3 driver

2021-04-02 Thread Salil Mehta
Fixes for the miscellaneous problems found during the review of the code. Salil Mehta (2): net: hns3: Remove the left over redundant check & assignment net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event() drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

[PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-02 Thread Salil Mehta
This removes the left over check and assignment which is no longer used anywhere in the function and should have been removed as part of the below mentioned patch. Fixes: 012fcb52f67c ("net: hns3: activate reset timer when calling reset_event") Signed-off-by: Salil Mehta --- d

[PATCH net 2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

2021-04-02 Thread Salil Mehta
Code to defer the reset(which caps the frequency of the reset) schedules the timer and returns. Hence, following 'else-if' looks un-necessary. Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently") Signed-off-by: Salil Mehta --- drivers/net/ethernet/h

RE: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
Hi Leon, Thanks for the review. > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Sunday, April 4, 2021 7:26 AM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...@openeuler.org >

RE: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
> From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, April 5, 2021 1:43 PM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...@openeuler.org > Subject: Re: [PATCH net 1/2]

[PATCH V2 net 0/2] Misc. fixes for hns3 driver

2021-04-05 Thread Salil Mehta
Fixes for the miscellaneous problems found during the review of the code. Change Summary: Patch 1/2, Change V1->V2: [1] Fixed comments from Leon Romanovsky Link: https://lkml.org/lkml/2021/4/4/14 Patch 2/2, Change V1->V2: None Salil Mehta (2): net: hns3: Remove the lef

[PATCH V2 net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
This removes the left over check and assignment which is no longer used anywhere in the function and should have been removed as part of the below mentioned patch. Fixes: 012fcb52f67c ("net: hns3: activate reset timer when calling reset_event") Signed-off-by: Salil Mehta -- V1->

[PATCH V2 net 2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

2021-04-05 Thread Salil Mehta
Code to defer the reset(which caps the frequency of the reset) schedules the timer and returns. Hence, following 'else-if' looks un-necessary. Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently") Signed-off-by: Salil Mehta --- drivers/net/ethernet/h

[PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-05 Thread Salil Mehta
Limiting the scope of the variable vector_ring_chain to the block where it is used. Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC") Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++- 1 file changed, 2 insert

RE: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-06 Thread Salil Mehta
anks Salil > From: patchwork-bot+netdev...@kernel.org > [mailto:patchwork-bot+netdev...@kernel.org] > Sent: Monday, April 5, 2021 11:10 PM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...

[PATCH net] net: hns3: Trivial spell fix in hns3 driver

2021-04-09 Thread Salil Mehta
Some trivial spelling mistakes which caught my eye during the review of the code. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-10 Thread Salil Mehta
ement ethtool ops for channels") Signed-off-by: Salil Mehta --- drivers/net/ethernet/intel/ice/ice_lib.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index d13c7fc8fb0a..16

RE: [PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
Hi Anthony, Thanks for reviewing! > From: Nguyen, Anthony L [mailto:anthony.l.ngu...@intel.com] > Sent: Monday, April 12, 2021 11:41 PM > To: da...@davemloft.net; k...@kernel.org; Salil Mehta > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Brandeburg, Jesse > ; linux..

[PATCH V2 net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
t;ice: Implement ethtool ops for channels") Cc: intel-wired-...@lists.osuosl.org Cc: Jeff Kirsher Signed-off-by: Salil Mehta -- Change V1->V2 (*) Fixed the comments from Anthony Nguyen(Intel) Link: https://lkml.org/lkml/2021/4/12/1997 --- drivers/net/ethernet/intel/ice/ice_lib.c | 14

[PATCH net-next 9/9] net: hns3: Remove packet statistics in the range of 8192~12287

2018-05-01 Thread Salil Mehta
patch removes the 8192~12287 range of packet statistics and uses the 8192~9216 and 9217~12287 ranges for statistics. This change depends on the firmware upgrade. Signed-off-by: Xi Wang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4

[PATCH net-next 5/9] net: hns3: fix for phy_addr error in hclge_mac_mdio_config

2018-05-01 Thread Salil Mehta
From: Huazhong Tan When phy exists, phy_addr must less than PHY_MAX_ADDR. If not, hclge_mac_mdio_config should return error. And for fiber(phy_addr=0xff), it does not need hclge_mac_mdio_config. Signed-off-by: Huazhong Tan Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net

[PATCH net-next 6/9] net: hns3: Fix to support autoneg only for port attached with phy

2018-05-01 Thread Salil Mehta
From: Fuyun Liang This patch adds a check to support autoneg(ethtool -A) only when PHY is attached with the port. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --

[PATCH net-next 8/9] net: hns3: Fix for packet loss due wrong filter config in VLAN tbls

2018-05-01 Thread Salil Mehta
will cause packet lost problem. This patch fixes this problem by setting both vlan table, and use hdev->vlan_table to manage thet port vlan table. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c

[PATCH net-next 4/9] net: hns3: Fixes the error legs in hclge_init_ae_dev function

2018-05-01 Thread Salil Mehta
Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 55 +- 1 file changed, 34 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilic

[PATCH net-next 7/9] net: hns3: fix a dead loop in hclge_cmd_csq_clean

2018-05-01 Thread Salil Mehta
y: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c| 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c index ff13d18..fab7

[PATCH net-next 2/9] net: hns3: fix to correctly fetch l4 protocol outer header

2018-05-01 Thread Salil Mehta
f-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 8c55965..c4e2950 100644 --- a/d

[PATCH net-next 3/9] net: hns3: Fixes the out of bounds access in hclge_map_tqp

2018-05-01 Thread Salil Mehta
: Huazhong Tan Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/h

[PATCH net-next 0/9] Misc bug fixes for HNS3 Ethernet driver

2018-05-01 Thread Salil Mehta
This patch-set presents some miscellaneous bug fixs and cleanups for HNS3 Ethernet Driver. Fuyun Liang (1): net: hns3: Fix to support autoneg only for port attached with phy Huazhong Tan (5): net: hns3: fix to correctly fetch l4 protocol outer header net: hns3: Fixes the out of bounds acces

[PATCH net-next 1/9] net: hns3: Remove error log when getting pfc stats fails

2018-05-01 Thread Salil Mehta
already return the error to the user space, so the user should be aware of the error. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[PATCH net-next] net: hns3: Add support of hardware rx-vlan-offload to HNS3 VF driver

2018-05-03 Thread Salil Mehta
From: Yunsheng Lin This patch adds support of hardware rx-vlan-offload to VF driver. VF uses mailbox to convey PF to configure the hardware. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 8

[PATCH net-next 2/4] net: hns3: remove add/del_tunnel_udp in hns3_enet module

2018-05-09 Thread Salil Mehta
ort this feature now. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 7 -- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 89 - 2 files changed, 96 deletions(-) diff --git a/driv

[PATCH net-next 1/4] net: hns3: Fix for setting mac address when resetting

2018-05-09 Thread Salil Mehta
NCL_CONFIG when resetting. Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 8 1 file changed, 4 insert

[PATCH net-next 3/4] net: hns3: fix for cleaning ring problem

2018-05-09 Thread Salil Mehta
hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 34 ++--- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/d

[PATCH net-next 4/4] net: hns3: refactor the loopback related function

2018-05-09 Thread Salil Mehta
From: Yunsheng Lin This patch refactors the loopback related function in order to support the serdes loopback. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 21 +++ .../ethernet/hisilicon/hns3

[PATCH net-next 0/4] Misc bug fixes for HNS3 Ethernet Driver

2018-05-09 Thread Salil Mehta
Fixes to some of the bugs found during system test, internal review and clean-up Yunsheng Lin (4): net: hns3: Fix for setting mac address when resetting net: hns3: remove add/del_tunnel_udp in hns3_enet module net: hns3: fix for cleaning ring problem net: hns3: refactor the loopback relate

[PATCH net-next 5/9] net: hns3: Add support to reset the enet/ring mgmt layer

2018-03-22 Thread Salil Mehta
After VF driver knows that hardware reset has been performed successfully, it should proceed ahead and reset the enet layer. This primarily consists of bringing down interface, clearing TX/RX rings, disassociating vectors from ring etc. Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3

[PATCH net-next 7/9] net: hns3: Changes to support ARQ(Asynchronous Receive Queue)

2018-03-22 Thread Salil Mehta
still gets processed in context to mailbox interrupt. ARQ is important as VF reset introduces some new async messages like MBX_ASSERTING_RESET which adds up to the presssure on the responses for synchronousmessages and they timeout even more quickly. Signed-off-by: Salil Mehta --- drivers/net

[PATCH net-next 9/9] net: hns3: Changes required in PF mailbox to support VF reset

2018-03-22 Thread Salil Mehta
received VF message, inform the VF of assertion and reset the VF using cmdq interface. Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 2 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 42

[PATCH net-next 8/9] net: hns3: Add *Asserting Reset* mailbox message & handling in VF

2018-03-22 Thread Salil Mehta
the hardware to complete the reset and then further resets/tears its own stack. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h | 1 + drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c | 12 2 files changed, 13 insertions(+) diff

[PATCH net-next 4/9] net: hns3: Add support to request VF Reset to PF

2018-03-22 Thread Salil Mehta
VF driver depends upon PF to eventually reset the hardware. This request is made using the mailbox command. This patch adds the required function to acheive above. Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 19 +++ 1 file changed, 19

[PATCH net-next 2/9] net: hns3: Add VF Reset Service Task to support event handling

2018-03-22 Thread Salil Mehta
VF reset would involve handling of different reset related events from the stack, physical function, mailbox etc. Reset service task would be used in servicing such reset event requests and later handling the hardware completions waits and initiating the stack resets. Signed-off-by: Salil Mehta

[PATCH net-next 3/9] net: hns3: Add VF Reset device state and its handling

2018-03-22 Thread Salil Mehta
resetting the stack/enet layer, which in turn means reinitializing the ring management/enet layer. Note: we would be adding support of 3. later as a separate patch. This decision should not affect VF reset as its event handling is generic in nature. Signed-off-by: Salil Mehta --- drivers/net/eth

[PATCH net-next 1/9] net: hns3: Changes to make enet watchdog timeout func common for PF/VF

2018-03-22 Thread Salil Mehta
following: 1. Makes the existing watchdog timeout handler in enet layer generic i.e. suitable for both VF and PF and 2. Introduces the new reset event handler for the VF code. 3. Changes existing reset event handler of PF code to initialize the reset level Signed-off-by: Salil Mehta

[PATCH net-next 6/9] net: hns3: Add support to re-initialize the hclge device

2018-03-22 Thread Salil Mehta
: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 106 ++--- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 14 +++ 2 files changed, 106 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net

[PATCH net-next 0/9] Add support of VF Reset to HNS3 VF driver

2018-03-22 Thread Salil Mehta
"[PATCH net-next 00/11] fix some bugs for HNS3 driver" Link: https://lkml.org/lkml/2018/3/21/72 Salil Mehta (9): net: hns3: Changes to make enet watchdog timeout func common for PF/VF net: hns3: Add VF Reset Service Task to support event handling net: hns3: Add VF Reset de

[PATCH net-next 3/3] net: hns3: Fixes the static check warning due to missing unsupp L3 proto check

2017-08-18 Thread Salil Mehta
This patch fixes the static check warning due to missing handling leg of unsupported L3 protocol type in the hns3_get_l4_protocol() function. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Reported-by: Dan Carpenter Signed-off-by: Salil Mehta --

[PATCH net-next 2/3] net: hns3: Fixes the static checker error warning in hns3_get_link_ksettings()

2017-08-18 Thread Salil Mehta
This patch fixes the static check error warning in hns3_get_link_ksettings() function by re-arranging the code. Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 Driver") Reported-by: Dan Carpenter Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hns3

[PATCH net-next 0/3] Misc. Bug fixes for HNS3 Ethernet Driver

2017-08-18 Thread Salil Mehta
This patch-set fixes various bugs reported by community. Salil Mehta (3): net: hns3: Fixes the missing u64_stats_fetch_begin_irq in 64-bit stats fetch net: hns3: Fixes the static checker error warning in hns3_get_link_ksettings() net: hns3: Fixes the static check warning due to

[PATCH net-next 1/3] net: hns3: Fixes the missing u64_stats_fetch_begin_irq in 64-bit stats fetch

2017-08-18 Thread Salil Mehta
this code ever runs on 32-bit platform and we are trying to do 64-bit stats fetch. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Reported-by: Dan Carpenter Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 2

[PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a netdevice and of a port in hardware . 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 2:31 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > dan.carpen...@oracle.com; mehta.salil@gmail.com; > netdev@vger.

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 4:04 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > dan.carpen...@oracle.com; mehta.salil@gmail.com; > netdev@vger.

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 5:02 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vge

[PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-18 Thread Salil Mehta
This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a of a port in the HNS NIC hardware . 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- PATCH V2: Addresses comments

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew, > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Friday, August 18, 2017 5:02 PM > > To: Salil Mehta > > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > > mehta.salil@gmail.com; ne

RE: [PATCH V2 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-20 Thread Salil Mehta
Hi Leon > -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Sunday, August 20, 2017 8:05 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@v

[PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a of a port in the HNS NIC hardware. 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- PATCH V3: Addressed some minor

RE: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
Hi Leon, -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, August 21, 2017 11:32 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger

RE: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, August 21, 2017 3:30 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vge

[PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a port in the HNS NIC hardware. 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta --- PATCH V4: Addressed some minor

RE: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
Sorry, Please ignore this mail. I forgot to add the Andrew Lunn signed-off-by Tag will this patch. I will add the tag and send the updated version of V4 again. Sorry again. > -Original Message- > From: Salil Mehta > Sent: Monday, August 21, 2017 3:40 PM > To: da...@daveml

RE: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
Hi Leon, > -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, August 21, 2017 3:49 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@v

RE: [PATCH V3 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
Hi Leon, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Monday, August 21, 2017 3:48 PM > To: Salil Mehta > Cc: Andrew Lunn; da...@davemloft.net; Zhuangyuzeng

[PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware

2017-08-21 Thread Salil Mehta
This patch adds the following support to the HNS3 driver: 1. Support to change the Maximum Transmission Unit of a port in the HNS NIC hardware. 2. Initializes the supported MTU range for the netdevice. Signed-off-by: lipeng Signed-off-by: Salil Mehta Reviewed-by: Andrew Lunn Reviewed-by

RE: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy

2019-03-01 Thread Salil Mehta
(+) LinuxArm > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > Sent: Friday, March 1, 2019 12:58 PM > To: liweihang > Cc: netdev@vger.kernel.org; da...@davemloft.net; linyunsheng > ; Zhuangyuzeng (Yisen) > ; Salil Mehta ; lipeng > (Y) ; shenjian (K) > Subject: Re

[PATCH net-next 03/10] net: hns3: Fix for waterline not setting correctly

2018-07-06 Thread Salil Mehta
hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff -

[PATCH V2 net 7/7] net: hns3: Fixes the premature exit of loop when matching clients

2017-09-19 Thread Salil Mehta
. Fixes: 38eddd126772 ("net: hns3: Add support of the HNAE3 framework") Signed-off-by: Lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 ++--- 1 file changed, 9 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet

[PATCH V2 net 6/7] net: hns3: Fixes the default VLAN-id of PF

2017-09-19 Thread Salil Mehta
t;net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Mingguang Qu Signed-off-by: Lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH V2 net 4/7] net: hns3: Fixes the initialization of MAC address in hardware

2017-09-19 Thread Salil Mehta
From: Lipeng This patch fixes the initialization of MAC address, fetched from HNS3 firmware i.e. when it is not randomly generated, to the HNS3 hardware. Fixes: ca60906d2795 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Lipeng Signed-off-by: S

[PATCH V2 net 3/7] net: hns3: Fixes ring-to-vector map-and-unmap command

2017-09-19 Thread Salil Mehta
Lipeng Signed-off-by: Mingguang Qu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 ++-- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 8 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH V2 net 5/7] net: hns3: Fixes the ether address copy with appropriate API

2017-09-19 Thread Salil Mehta
This patch replaces the ethernet address copy instance with more appropriate ether_addr_copy() function. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hc

[PATCH V2 net 2/7] net: hns3: Fixes the command used to unmap ring from vector

2017-09-19 Thread Salil Mehta
From: Lipeng This patch fixes the IMP command being used to unmap the vector from the corresponding ring. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/

[PATCH V2 net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

2017-09-19 Thread Salil Mehta
net: hns3: Fixes the command used to unmap ring from vector net: hns3: Fixes ring-to-vector map-and-unmap command net: hns3: Fixes the initialization of MAC address in hardware net: hns3: Fixes the default VLAN-id of PF net: hns3: Fixes the premature exit of loop when matching clients S

[PATCH V2 net 1/7] net: hns3: Fixes initialization of phy address from firmware

2017-09-19 Thread Salil Mehta
Signed-off-by: Lipeng Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index bb45365..db4e07

[PATCH net-next 11/12] net: hns3: Fix client initialize state issue when roce client initialize failed

2018-09-19 Thread Salil Mehta
Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 12 +--- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 9 +++

[PATCH net-next 04/12] net: hns3: Add support to enable TX/RX promisc mode for H/W rev(0x21)

2018-05-25 Thread Salil Mehta
From: Peng Li HCLGE_PROMISC_TX_EN_B and HCLGE_PROMISC_RX_EN_B are not supported on pdev revision(0x20), new revision(0x21) supports them. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3

[PATCH net-next 12/12] net: hns3: Fixes initalization of RoCE handle and makes it conditional

2018-05-25 Thread Salil Mehta
F HCL(Hardware Compatibility Layer) Support") Reported-by: Xinwei Kong Reported-by: Zhou Wang Signed-off-by: Lijun Ou Signed-off-by: Zhou Wang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH net-next 11/12] net: hns3: Adds support for led locate command for copper port

2018-05-25 Thread Salil Mehta
between driver and firmware. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 12 ++-- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 35 +++--- 2 files changed, 6 insertions(+), 41

[PATCH net-next 08/12] net: hns3: Removes unnecessary check when clearing TX/RX rings

2018-05-25 Thread Salil Mehta
ned-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index d1ef104..4c13

[PATCH net-next 06/12] net: hns3: Fixes the state to indicate client-type initialization

2018-05-25 Thread Salil Mehta
the initialization state. Fixes: 38caee9d3ee8 ("net: hns3: Add support of the HNAE3 framework") Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 49 +++-- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 4 ++

[PATCH net-next 09/12] net: hns3: Clear TX/RX rings when stopping port & un-initializing client

2018-05-25 Thread Salil Mehta
ensure the buffer is clean when port is started. We should clear the rings when clients are being un-initialized as well. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --

[PATCH net-next 10/12] net: hns3: Remove unused led control code

2018-05-25 Thread Salil Mehta
, the dirver just needs to deal with locate command. So the codes for link led, traffic led and speed led are useless now. This patch removes these redundant codes. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h

[PATCH net-next 01/12] net: hns3: Updates RX packet info fetch in case of multi BD

2018-05-25 Thread Salil Mehta
size from the first descriptor and information like VLAN should be fetched from last BD. Signed-off-by: Peng Li Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 36 - 1 file changed, 18 insertions(+), 18 deletions

[PATCH net-next 00/12] Misc. bug fixes & some minor additions to HNS3 driver

2018-05-25 Thread Salil Mehta
This patch-set provides some bug fixes figured out during testing and review. It also provides some additions due to running of the existing code on the new revision of the HNS3 hardware. Fuyun Liang (3): net: hns3: Fixes the init of the VALID BD info in the descriptor net: hns3: Removes unnec

[PATCH net-next 07/12] net: hns3: Fixes the init of the VALID BD info in the descriptor

2018-05-25 Thread Salil Mehta
this bit was not being (re-)initialized properly and hence was causing problems. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/h

[PATCH net-next 05/12] net: hns3: Fix for PF mailbox receving unknown message

2018-05-25 Thread Salil Mehta
Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver") Signed-off-by: Xi Wang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 23 +++--- 1 file changed, 20 insertions(+), 3 deletions(-

[PATCH net-next 03/12] net: hns3: Add STRP_TAGP field support for hardware revision 0x21

2018-05-25 Thread Salil Mehta
bit, 0 indicates the tag is not stripped and 1 indicates the tag is stripped. This patch adds STRP_TAGP support for revision(0x21), and does not change the revision(0x20) action. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 42

[PATCH net-next 02/12] net: hns3: Add support for tx_accept_tag2 and tx_accept_untag2 config

2018-05-25 Thread Salil Mehta
From: Peng Li HNS3 Hardware can support up to two VLAN tags in transmit leg, the PPP module can handle the packets based on the tag1 and tag2 config. This patch adds support for tag2 config for vlan handling Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon

[PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2018-11-26 Thread Salil Mehta
From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and sets NIC port speed accordingly. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net

RE: hns: question regarding ae_node device node refcounting

2019-01-11 Thread Salil Mehta
Hi Alexey, > From: Alexey Khoroshilov [mailto:khoroshi...@ispras.ru] > Sent: Saturday, December 22, 2018 9:55 PM > To: Zhuangyuzeng (Yisen) ; Salil Mehta > ; lipeng (Y) > Cc: Alexey Khoroshilov ; David S. Miller > ; netdev@vger.kernel.org; linux- > ker...@vger

[PATCH V2 net-next 0/5] net: hns3: Add support of hardware GRO to HNS3 Driver

2018-11-15 Thread Salil Mehta
This patch-set adds support of hardware assisted GRO feature to HNS3 driver on Rev B(=0x21) platform. Current hardware only supports TCP/IPv{4|6} flows. Change Log: V1->V2: 1. Remove redundant print reported by Leon Romanovsky. Link: https://lkml.org/lkml/2018/11/13/715 Peng Li (5): net: hns

RE: [PATCH net-next] net: hns3: Fix potential NULL dereference on allocation error

2019-01-28 Thread Salil Mehta
> From: yuehaibing > Sent: Friday, January 25, 2019 3:14 AM > To: da...@davemloft.net; Zhuangyuzeng (Yisen) ; > Salil Mehta ; lipeng (Y) > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; yuehaibing > > Subject: [PATCH net-next] net: hns3: Fix potential NULL derefe

[PATCH net-next 0/2] Adds VF/PF PCIe reg dump(ethtool -d) support to HNS3 driver

2018-11-29 Thread Salil Mehta
This patchset adds VF/PF PCIe register dump support to HNS3 VF and PF driver using "ethtool -d" command. Jian Shen (2): net: hns3: Support "ethtool -d" for HNS3 VF driver net: hns3: Adds support to dump(using ethool-d) PCIe regs in HNS3 PF driver .../ethernet/hisilicon/hns3/hns3pf/hclge_

[PATCH net-next 2/2] net: hns3: Adds support to dump(using ethool-d) PCIe regs in HNS3 PF driver

2018-11-29 Thread Salil Mehta
From: Jian Shen This patch adds support to dump PF PCIe registers using ethtool -d for HNS3 PF Driver. Signed-off-by: Jian Shen Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 120 - .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h

[PATCH net-next 1/2] net: hns3: Support "ethtool -d" for HNS3 VF driver

2018-11-29 Thread Salil Mehta
From: Jian Shen This patch adds "ethtool -d" support for HNS3 VF Driver. Signed-off-by: Jian Shen Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 120 + .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 54 +

[RFC net-next 3/9] net: hns3: Add "port vlan table" information query function

2018-12-02 Thread Salil Mehta
off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 80 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h | 3 + 3 files changed, 84 insertions(+) diff --git a/drive

[RFC net-next 0/9] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-02 Thread Salil Mehta
This patch-set adds few more debugfs commands to HNS3 Ethernet Driver. Support has been added to query info related to below items: 1. Packet buffer descriptor ("echo bd info [queue no] [bd index] > cmd") 2. Mac Forward table("echo dump mac tbl > cmd") 3. Port vlan Forward table("echo dump port vla

[RFC net-next 9/9] net: hns3: Add "tm map" status information query function

2018-12-02 Thread Salil Mehta
From: liuzhongzhu This patch prints dcb register status information by module. debugfs command: root@(none)# echo dump tm map 100 > cmd queue_id | qset_id | pri_id | tc_id 0100 | 0065| 08 | 00 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/

[RFC net-next 5/9] net: hns3: Add "manager table" information query function

2018-12-02 Thread Salil Mehta
0 |0 01 |c2:f1:c5:82:68:17|0 |0|0 ||0 |00 |00 |0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 16 ++ .../ethernet/hisilicon/hns3/

[RFC net-next 7/9] net: hns3: Add "dcb register" status information query function

2018-12-02 Thread Salil Mehta
ned-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 7 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 9 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 102 + .../ethernet/hisilicon/hns3/hns

[RFC net-next 8/9] net: hns3: Add "queue map" information query function

2018-12-02 Thread Salil Mehta
47 784 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 33 ++ .../et

[RFC net-next 6/9] net: hns3: Add "status register" information query function

2018-12-02 Thread Salil Mehta
2: 0x2 DFX_MSIX_INFO_NIC_3: 0x2 DFX_MSIX_INFO_ROC_0: 0xc000 DFX_MSIX_INFO_ROC_1: 0x0 DFX_MSIX_INFO_ROC_2: 0x0 DFX_MSIX_INFO_ROC_3: 0x0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 15 + .../net/ethernet/hisilicon/hns3/

[RFC net-next 2/9] net: hns3: Add "mac table" information query function

2018-12-02 Thread Salil Mehta
c_addr |UM_MC_RDATA |0556 |33:33:00:00:00:01 |:0001::: |2812 |33:33:ff:82:68:17 |:0001::: |2844 |01:00:5e:00:00:01 |:0001::: root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil

[RFC net-next 4/9] net: hns3: Add "vf vlan table" information query function

2018-12-02 Thread Salil Mehta
@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 93 ++ 2 files changed, 94 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugf

  1   2   3   4   5   6   >