Hi Leon, > -----Original Message----- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, August 21, 2017 3:49 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil....@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next] net: hns3: Add support to change MTU > in HNS3 hardware > > On Mon, Aug 21, 2017 at 03:40:03PM +0100, Salil Mehta wrote: > > This patch adds the following support to the HNS3 driver: > > 1. Support to change the Maximum Transmission Unit of a > > port in the HNS NIC hardware. > > 2. Initializes the supported MTU range for the netdevice. > > > > Signed-off-by: lipeng <lipeng...@huawei.com> > > Signed-off-by: Salil Mehta <salil.me...@huawei.com> > > --- > > PATCH V4: Addressed some minor comments Leon Romanovsky > > 1. https://lkml.org/lkml/2017/8/21/212 > > PATCH V3: Addressed some minor comments Leon Romanovsky > > 1. https://lkml.org/lkml/2017/8/20/27 > > PATCH V2: Addresses comments given by Andrew Lunn > > 1. https://lkml.org/lkml/2017/8/18/282 > > PATCH V1: Initial Submit > > --- > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 34 > ++++++++++++++++++++++ > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h | 1 + > > 2 files changed, 35 insertions(+) > > > > Wrong error code is not "minor" comment. Sorry for the wrong terminology used. Both of the comments were definitely useful and I have taken into consideration both of them in my recent patch. I think I missed it while replying, saw it while and created the patch later. Sorry for that again.
I will correct this in my subsequent patch. Best regards Salil > > Thanks, > Reviewed-by: Leon Romanovsky <leo...@mellanox.com>
