Hi Alexey, > From: Alexey Khoroshilov [mailto:khoroshi...@ispras.ru] > Sent: Saturday, December 22, 2018 9:55 PM > To: Zhuangyuzeng (Yisen) <yisen.zhu...@huawei.com>; Salil Mehta > <salil.me...@huawei.com>; lipeng (Y) <lipeng...@huawei.com> > Cc: Alexey Khoroshilov <khoroshi...@ispras.ru>; David S. Miller > <da...@davemloft.net>; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; ldv-proj...@linuxtesting.org > Subject: net: hns: question regarding ae_node device node refcounting > > Hello, > > hns_nic_dev_probe() increments refcount of ae_node device node: > ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0); > > But there is no of_node_put() for ae_node. > What is the right place to decrement the ae_node refount? > > Should it be placed in hns_nic_dev_probe() or in hns_nic_dev_remove()? > Or may be it is managed by fwnode somehow?
Thanks for bringing this to notice. Yes, you are right of_node_put() is missing. We will float a fix for this soon. Cheers Salil
