Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Heiner Kallweit
On 07.04.2021 03:43, Joakim Zhang wrote: > > Hi Heiner, > >> -Original Message- >> From: Heiner Kallweit >> Sent: 2021年4月7日 2:22 >> To: Joakim Zhang ; christian.me...@t2data.com; >> and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; >> k...@kernel.org; Russell King - ARM Linux

Re: [PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1

2021-04-07 Thread Arnd Bergmann
On Wed, Apr 7, 2021 at 2:24 AM Marek Behún wrote: > > The -Wextra flag enables -Woverride-init in newer versions of GCC. > > This causes the compiler to warn when a value is written twice in a > designated initializer, for example: > int x[1] = { > [0] = 3, > [0] = 3, > }; > > Note tha

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 15:12 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; Fl

[net-next 1/6] can: skb: alloc_can{,fd}_skb(): set "cf" to NULL if skb allocation fails

2021-04-07 Thread Marc Kleine-Budde
The handling of CAN bus errors typically consist of allocating a CAN error SKB using alloc_can_err_skb() followed by stats handling and filling the error details in the newly allocated CAN error SKB. Even if the allocation of the SKB fails the stats handling should not be skipped. The common patte

pull-request: can-next 2021-04-07

2021-04-07 Thread Marc Kleine-Budde
tags/linux-can-next-for-5.13-20210407 for you to fetch changes up to c7eb923c3caf4c6a183465cc012dc368b199a4b2: can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register (2021-04-07 09:31:28 +0200) linux-can

[net-next 3/6] can: c_can: remove unused enum BOSCH_C_CAN_PLATFORM

2021-04-07 Thread Marc Kleine-Budde
This patch removes the unused enum BOSCH_C_CAN_PLATFORM. Link: https://lore.kernel.org/r/20210406110617.1865592-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/c_can/c_can.h b/drivers/net/c

[net-next 2/6] can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call

2021-04-07 Thread Marc Kleine-Budde
In commit 1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context") the RX path for peripherals (i.e. SPI based m_can controllers) was converted to the rx-offload infrastructure. However, the error handling for can_rx_offload_queue_sorted() was for

[net-next 5/6] can: mcp251xfd: mcp251xfd_regmap_crc_read_one(): Factor out crc check into separate function

2021-04-07 Thread Marc Kleine-Budde
This patch factors out the crc check into a separate function. This is preparation for the next patch. Link: https://lore.kernel.org/r/20210406110617.1865592-4-...@pengutronix.de Cc: Manivannan Sadhasivam Cc: Thomas Kopp Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251xfd/mcp251xfd-

[net-next 4/6] can: mcp251xfd: add BQL support

2021-04-07 Thread Marc Kleine-Budde
This patch re-adds BQL support to the driver. Support for netdev_xmit_more() will be added in a separate patch series. Link: https://lore.kernel.org/r/20210406110617.1865592-3-...@pengutronix.de Cc: Manivannan Sadhasivam Cc: Thomas Kopp Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp2

[net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register

2021-04-07 Thread Marc Kleine-Budde
MCP251XFD_REG_TBC is the time base counter register. It increments once per SYS clock tick, which is 20 or 40 MHz. Observation shows that if the lowest byte (which is transferred first on the SPI bus) of that register is 0x00 or 0x80 the calculated CRC doesn't always match the transferred one. To

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Dexuan Cui
> From: Andrew Lunn > Sent: Tuesday, April 6, 2021 6:08 PM > To: Dexuan Cui > > > +static int gdma_query_max_resources(struct pci_dev *pdev) > > +{ > > + struct gdma_context *gc = pci_get_drvdata(pdev); > > + struct gdma_general_req req = { 0 }; > > + struct gdma_query_max_resources_resp r

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Dexuan Cui
> From: kernel test robot > Sent: Tuesday, April 6, 2021 6:31 PM > ... > Hi Dexuan, > I love your patch! Perhaps something to improve: > > All warnings (new ones prefixed by >>): > >drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask': >drivers/pci/controller/pci-hyperv.c:12

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Tue, Apr 06, 2021 at 04:23:21PM -0700, Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Signed-off-by: Dexuan Cui > --- > MAINTAINERS

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:02:17AM +, Dexuan Cui wrote: > > From: Andrew Lunn > > Sent: Tuesday, April 6, 2021 6:08 PM > > To: Dexuan Cui > > > > > +static int gdma_query_max_resources(struct pci_dev *pdev) > > > +{ > > > + struct gdma_context *gc = pci_get_drvdata(pdev); > > > + struct gdma

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Dexuan Cui
> From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 1:15 AM > > ... > > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq) > > { > > struct gdma_generate_test_event_req req = { 0 }; > > struct gdma_general_resp resp = { 0 }; > > BTW, you don't need to write { 0

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Dexuan Cui
> From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 1:10 AM > > <...> > > > +int gdma_verify_vf_version(struct pci_dev *pdev) > > +{ > > + struct gdma_context *gc = pci_get_drvdata(pdev); > > + struct gdma_verify_ver_req req = { 0 }; > > + struct gdma_verify_ver_resp resp = { 0 }; > >

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2021-04-07 Thread Willy Tarreau
Hi Daniel, On Tue, Apr 06, 2021 at 07:04:58PM +0900, Daniel Palmer wrote: > Hi Willy, > > I've been messing with the SSD202D (sibling of the MSC313E) recently > and the ethernet performance was awful. > I remembered this revert and reverted it and it makes the ethernet > work pretty well. OK, th

Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver v3

2021-04-07 Thread Joerg Roedel
On Thu, Apr 01, 2021 at 05:52:36PM +0200, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |5 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 75 -

Re: [PATCH net-next v3 3/8] virtio-net: xsk zero copy xmit setup

2021-04-07 Thread Jason Wang
在 2021/4/7 下午3:27, Xuan Zhuo 写道: On Tue, 6 Apr 2021 12:27:14 +0800, Jason Wang wrote: 在 2021/3/31 下午3:11, Xuan Zhuo 写道: xsk is a high-performance packet receiving and sending technology. This patch implements the binding and unbinding operations of xsk and the virtio-net queue for xsk zero

Re: [PATCH iproute2] erspan: fix JSON output

2021-04-07 Thread Christian Pössinger
On Tue, Apr 6, 2021 at 9:28 AM Stephen Hemminger wrote: > > The format for erspan output is not valid JSON. > The direction should be value and erspan_dir should be the key. > > Fixes: 289763626721 ("erspan: add erspan version II support") > Cc: u9012...@gmail.com > Reported-by: Christian Pössinge

Re: [PATCH net-next v3 7/8] virtio-net: poll tx call xsk zerocopy xmit

2021-04-07 Thread Jason Wang
在 2021/4/7 下午5:10, Xuan Zhuo 写道: On Tue, 6 Apr 2021 15:03:29 +0800, Jason Wang wrote: 在 2021/3/31 下午3:11, Xuan Zhuo 写道: poll tx call virtnet_xsk_run, then the data in the xsk tx queue will be continuously consumed by napi. Signed-off-by: Xuan Zhuo Reviewed-by: Dust Li I think we need sq

Re: [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent

2021-04-07 Thread Marc Zyngier
On Tue, 30 Mar 2021 15:54:26 +0100, Marc Zyngier wrote: > > From: Jianyong Wu > > Currently, the ptp_kvm module contains a lot of x86-specific code. > Let's move this code into a new arch-specific file in the same directory, > and rename the arch-independent file to ptp_kvm_common.c. > > Revie

Re: [PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-04-07 Thread Jason Wang
在 2021/4/7 下午5:26, Xuan Zhuo 写道: + __free_old_xmit(sq, false, &stats); Let's use a separate patch for this kind of factoring. It is also possible to encounter xsk here, so it should not be a separate patch. Thanks. You can do the factoring first and add xsk stuffs on top. Thanks

[PATCH] xircom: remove redundant error check on variable err

2021-04-07 Thread Colin King
From: Colin Ian King The error check on err is always false as err is always 0 at the port_found label. The code is redundant and can be removed. Addresses-Coverity: ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/net/ethernet/xircom/xirc2ps_cs.c | 2 -- 1 file changed, 2 del

[PATCH] wil6210: wmi: Remove useless code

2021-04-07 Thread Jiapeng Chong
Fix the following whitescan warning: An unsigned value can never be less than 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/driver

Re: [RFC] vsock: add multiple transports support for dgram

2021-04-07 Thread Jorgen Hansen
> On 6 Apr 2021, at 20:31, Jiang Wang wrote: > > From: "jiang.wang" > > Currently, only VMCI supports dgram sockets. To supported > nested VM use case, this patch removes transport_dgram and > uses transport_g2h and transport_h2g for dgram too. Could you provide some background for introducin

Re: [PATCH net-next v3 4/8] virtio-net: xsk zero copy xmit implement wakeup and xmit

2021-04-07 Thread Magnus Karlsson
On Tue, Apr 6, 2021 at 3:33 PM Jason Wang wrote: > > > 在 2021/3/31 下午3:11, Xuan Zhuo 写道: > > When the user calls sendto to consume the data in the xsk tx queue, > > virtnet_xsk_wakeup will be called. > > > > In wakeup, it will try to send a part of the data directly, the quantity > > is operated b

Re: [PATCH net-next v3 3/8] virtio-net: xsk zero copy xmit setup

2021-04-07 Thread Magnus Karlsson
On Tue, Apr 6, 2021 at 3:13 PM Jason Wang wrote: > > > 在 2021/3/31 下午3:11, Xuan Zhuo 写道: > > xsk is a high-performance packet receiving and sending technology. > > > > This patch implements the binding and unbinding operations of xsk and > > the virtio-net queue for xsk zero copy xmit. > > > > The

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Joakim Zhang > Sent: 2021年4月7日 15:46 > To: Heiner Kallweit ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; Fl

[PATCH net v3 0/2] Fix link_mode derived params functionality

2021-04-07 Thread Danielle Ratson
Currently, link_mode parameter derives 3 other link parameters, speed, lanes and duplex, and the derived information is sent to user space. Few bugs were found in that functionality. First, some drivers clear the 'ethtool_link_ksettings' struct in their get_link_ksettings() callback and cause rece

[PATCH net v3 1/2] ethtool: Remove link_mode param and derive link params from driver

2021-04-07 Thread Danielle Ratson
Some drivers clear the 'ethtool_link_ksettings' struct in their get_link_ksettings() callback, before populating it with actual values. Such drivers will set the new 'link_mode' field to zero, resulting in user space receiving wrong link mode information given that zero is a valid value for the fie

[PATCH net v3 2/2] ethtool: Add lanes parameter for ETHTOOL_LINK_MODE_10000baseR_FEC_BIT

2021-04-07 Thread Danielle Ratson
Lanes field is missing for ETHTOOL_LINK_MODE_1baseR_FEC_BIT link mode and it causes a failure when trying to set 'speed 1 lanes 1' on Spectrum-2 machines when autoneg is set to on. Add the lanes parameter for ETHTOOL_LINK_MODE_1baseR_FEC_BIT link mode. Fixes: c8907043c6ac9 ("ethtool:

[PATCH] liquidio: Fix unintented sign extension of a left shift of a u16

2021-04-07 Thread Colin King
From: Colin Ian King The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port (a u16) left 24 places. There are two subtle issues here, first the shift gets promoted to an signed int and then sign extended to a u64. If oct->pcie_port is 0x80 or more then the upper bits get sign e

Re: Semantics of AF_PACKET sockets on bridge port interface - patch

2021-04-07 Thread Russell King - ARM Linux admin
On Sat, Apr 03, 2021 at 10:54:18AM +0100, Russell King - ARM Linux admin wrote: > Hi, > > This question has probably come up several times before, but there > doesn't seem to be a solution yet. > > Scenario: a network interface, such as a wireless adapter or a > network interface supporting PTP,

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Heiner Kallweit
On 07.04.2021 12:05, Joakim Zhang wrote: > > Hi Heiner, > >> -Original Message- >> From: Joakim Zhang >> Sent: 2021年4月7日 15:46 >> To: Heiner Kallweit ; christian.me...@t2data.com; >> and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; >> k...@kernel.org >> Cc: netdev@vger.kernel.

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 18:22 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > ; Florian Fainel

[PATCH net-next] wireguard: disable in FIPS mode

2021-04-07 Thread Hangbin Liu
As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not FIPS certified, the WireGuard module should be disabled in FIPS mode. Signed-off-by: Hangbin Liu --- drivers/net/wireguard/main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireguard/main.c b/driv

[PATCH net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL

2021-04-07 Thread Joakim Zhang
Both get and set WoL will check device_can_wakeup(), if MAC supports PMT, it will set device wakeup capability. After commit 1d8e5b0f3f2c ("net: stmmac: Support WOL with phy"), device wakeup capability will be overwrite in stmmac_init_phy() according to phy's Wol feature. If phy doesn't support WoL

[PATCH net-next] net: wan: z85230: drop unused async state

2021-04-07 Thread Johan Hovold
According to the changelog, asynchronous mode was dropped sometime before v2.2. Let's get rid of the unused driver-specific async state as well so that it doesn't show up when doing tree-wide tty work. Signed-off-by: Johan Hovold --- drivers/net/wan/z85230.h | 39

Re: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma)

2021-04-07 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 11:30:23PM +, Saleem, Shiraz wrote: > Hi Jason - I think its because I used --irreversible-delete flag in git > format-patch for review that this one doesn't apply. I doubt it > I can resend without it if your trying to apply. Now it is too big to go to the mailing

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-07 Thread Oliver Neukum
Am Dienstag, den 06.04.2021, 18:01 + schrieb Grant Grundler: > > Ethernet does not support > > different rates in each direction. So if RX and TX are different, i > > would actually say something is broken. > > Agreed. The question is: Is there data or some heuristics we can use > to determin

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

2021-04-07 Thread Kalle Valo
Colin King writes: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the r

Re: [PATCH net-next] wireguard: disable in FIPS mode

2021-04-07 Thread Hangbin Liu
On Wed, Apr 07, 2021 at 06:43:07PM +0800, Hangbin Liu wrote: > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not > FIPS certified, the WireGuard module should be disabled in FIPS mode. > > Signed-off-by: Hangbin Liu Ondrej remind that I need to cc linux-crypto. I will re

[PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-07 Thread Hangbin Liu
As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not FIPS certified, the WireGuard module should be disabled in FIPS mode. Signed-off-by: Hangbin Liu --- drivers/net/wireguard/main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireguard/main.c b/driv

Re: [PATCH net-next] wlcore: fix overlapping snprintf arguments in debugfs

2021-04-07 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > gcc complains about undefined behavior in calling snprintf() > with the same buffer as input and output: > > drivers/net/wireless/ti/wl18xx/debugfs.c: In function > 'diversity_num_of_packets_per_ant_read': > drivers/net/wireless/ti/wl18xx/../wlcore

Re: [PATCH] drivers: net: wireless: struct lbs_private is declared duplicately

2021-04-07 Thread Kalle Valo
Wan Jiabing writes: > struct lbs_private has been declared at 22nd line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > drivers/net/wireless/marvell/libertas/decl.h | 1 - > 1 file changed, 1 deletion(-) The prefix should be "libertas:", I can fix that during commit. -- https

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2021-04-07 Thread Alexandre Belloni
Hi, On 07/04/2021 10:42:07+0200, Willy Tarreau wrote: > Hi Daniel, > > On Tue, Apr 06, 2021 at 07:04:58PM +0900, Daniel Palmer wrote: > > Hi Willy, > > > > I've been messing with the SSD202D (sibling of the MSC313E) recently > > and the ethernet performance was awful. > > I remembered this rever

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2021-04-07 Thread Daniel Palmer
Hi Willy On Wed, 7 Apr 2021 at 17:42, Willy Tarreau wrote: > > There are two new status bits TBNQ and FBNQ at bits 7 and 8. I have no > > idea what they mean. > > Maybe they're related to tx queue empty / tx queue full. Just guessing. > Since all these bits tend not to be reset until written to,

Re: [PATCH] hostap: Fix memleak in prism2_config

2021-04-07 Thread Kalle Valo
Dinghao Liu writes: > When prism2_hw_config() fails, we just return an error code > without any resource release, which may lead to memleak. > > Signed-off-by: Dinghao Liu > --- > drivers/net/wireless/intersil/hostap/hostap_cs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-04-07 Thread Kalle Valo
Ulf Hansson writes: >> If I follow what has been done in other drivers I would write something >> like: >> >> static int wfx_sdio_suspend(struct device *dev) >> { >> struct sdio_func *func = dev_to_sdio_func(dev); >> struct wfx_sdio_priv *bus = sdio_get_drvdata(func); >> >

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Andrew Lunn
> And, some variable defines can not follow the reverse christmas tree > style due to dependency, e.g. > static void hwc_init_event_handler(void *ctx, struct gdma_queue *q_self, >struct gdma_event *event) > { > struct hw_channel_context *hwc = ctx; >

pull-request: wireless-drivers-2021-04-07

2021-04-07 Thread Kalle Valo
Hi, here's a pull request to net tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit 05a59d79793d482f628a31753c671f2e92178a21: Merge git://git.kernel.org:/pub/scm/linux/kernel/git/netdev/net (2021-03-09 17:15:56 -0800) are available

Re: [PATCH net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 06:44:04PM +0800, Joakim Zhang wrote: > Both get and set WoL will check device_can_wakeup(), if MAC supports > PMT, it will set device wakeup capability. After commit 1d8e5b0f3f2c ("net: > stmmac: Support WOL with phy"), device wakeup capability will be > overwrite in stmmac

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:28:45AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:15 AM > > > ... > > > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq) > > > { > > > struct gdma_generate_test_event_req req = { 0 }; > > > str

Re: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac

2021-04-07 Thread Andrew Lunn
> Intel mgbe is flexible to pair with any PHY. Only Aquantia/Marvell > multi-gige PHY can do rate adaption right? The Marvell/Marvell multi-gige PHY can also do rate adaptation. Marvell buying Aquantia made naming messy :-( I should probably use part numbers. > Hence, we still need to take care o

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 08:40:13AM +, Dexuan Cui wrote: > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 1:10 AM > > > > <...> > > > > > +int gdma_verify_vf_version(struct pci_dev *pdev) > > > +{ > > > + struct gdma_context *gc = pci_get_drvdata(pdev); > > > + struct gdma_verify_

Re: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac

2021-04-07 Thread Russell King - ARM Linux admin
On Wed, Apr 07, 2021 at 02:44:39PM +0200, Andrew Lunn wrote: > > Intel mgbe is flexible to pair with any PHY. Only Aquantia/Marvell > > multi-gige PHY can do rate adaption right? > > The Marvell/Marvell multi-gige PHY can also do rate > adaptation. Marvell buying Aquantia made naming messy :-( > I

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Wed, Apr 07, 2021 at 08:08:59AM +, Dexuan Cui wrote: > > From: kernel test robot > > Sent: Tuesday, April 6, 2021 6:31 PM > > ... > > Hi Dexuan, > > I love your patch! Perhaps something to improve: > > > > All warnings (new ones prefixed by >>): > > > >drivers/pci/controller/pci-hype

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Tue, Apr 06, 2021 at 04:23:21PM -0700, Dexuan Cui wrote: [...] > +config MICROSOFT_MANA > + tristate "Microsoft Azure Network Adapter (MANA) support" > + default m > + depends on PCI_MSI > + select PCI_HYPERV OOI which part of the code requires PCI_HYPERV? Asking because I can'

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-07 Thread Danilo Krummrich
I somehow missed this mail.. On Mon, Apr 05, 2021 at 10:12:36PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Apr 05, 2021 at 08:58:07PM +0200, Danilo Krummrich wrote: > > On Mon, Apr 05, 2021 at 03:33:55PM +0200, Andrew Lunn wrote: > > However, this was about something else - Russell wro

[PATCH net-next 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-07 Thread Wong Vee Khee
From: Tan Tee Min The Synopsis MAC controller supports auxiliary snapshot feature that allows user to store a snapshot of the system time based on an external event. This patch add supports to the above mentioned feature. Users will be able to triggered capturing the time snapshot from user-spac

Re: [PATCH AUTOSEL 5.10 09/33] net: correct sk_acceptq_is_full()

2021-04-07 Thread Sasha Levin
On Mon, Apr 05, 2021 at 03:59:02PM -0300, Marcelo Ricardo Leitner wrote: On Mon, Mar 29, 2021 at 06:21:57PM -0400, Sasha Levin wrote: From: liuyacan [ Upstream commit f211ac154577ec9ccf07c15f18a6abf0d9bdb4ab ] The "backlog" argument in listen() specifies the maximom length of pending connecti

Re: [PATCH net-next 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 10:15:37PM +0800, Wong Vee Khee wrote: > From: Tan Tee Min > > The Synopsis MAC controller supports auxiliary snapshot feature that > allows user to store a snapshot of the system time based on an external > event. > > This patch add supports to the above mentioned featur

[PATCH] bnx2x: Fix potential infinite loop

2021-04-07 Thread Colin King
From: Colin Ian King The for_each_tx_queue loop iterates with a u8 loop counter i and compares this with the loop upper limit of bp->num_queues that is an int type. There is a potential infinite loop if bp->num_queues is larger than the u8 loop counter. Fix this by making the loop counter the sa

Re: [PATCH net-next v9 1/2] net: Add a WWAN subsystem

2021-04-07 Thread Dan Williams
On Mon, 2021-04-05 at 11:52 +0200, Loic Poulain wrote: > This change introduces initial support for a WWAN framework. Given > the > complexity and heterogeneity of existing WWAN hardwares and > interfaces, > there is no strict definition of what a WWAN device is and how it > should > be represented

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Wei Liu > Sent: Wednesday, April 7, 2021 9:17 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; li

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 8:51 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; linux- > ker...@vger.kernel

Re: [PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1

2021-04-07 Thread Marek Behún
On Wed, 7 Apr 2021 09:14:29 +0200 Arnd Bergmann wrote: > On Wed, Apr 7, 2021 at 2:24 AM Marek Behún wrote: > > > > The -Wextra flag enables -Woverride-init in newer versions of GCC. > > > > This causes the compiler to warn when a value is written twice in a > > designated initializer, for exampl

Re: [PATCH net] net: fix hangup on napi_disable for threaded napi

2021-04-07 Thread Paolo Abeni
Hello, I'm sorry for the lag, On Thu, 2021-04-01 at 16:44 -0700, Jakub Kicinski wrote: > On Thu, 01 Apr 2021 11:55:45 +0200 Paolo Abeni wrote: > > On Wed, 2021-03-31 at 18:41 -0700, Jakub Kicinski wrote: > > > On Thu, 1 Apr 2021 00:46:18 +0200 Paolo Abeni wrote: > > > > I hit an hangup on napi

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Leon Romanovsky
On Wed, Apr 07, 2021 at 02:41:45PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Leon Romanovsky > > Sent: Wednesday, April 7, 2021 8:51 AM > > To: Dexuan Cui > > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > > ; Haiyang Zhang ; Stephen > > Hemminger ; wei

pull-request: ieee802154 for net 2021-04-07

2021-04-07 Thread Stefan Schmidt
Hello Dave, Jakub. An update from ieee802154 for your *net* tree. Most of these are coming from the flood of syzkaller reports lately got for the ieee802154 subsystem. There are likely to come more for this, but this is a good batch to get out for now. Alexander Aring created a patchset to avoid

Re: [PATCH v4 05/23] ice: Add devlink params support

2021-04-07 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 04:01:07PM -0500, Shiraz Saleem wrote: > Add a new generic runtime devlink parameter 'rdma_protocol' > and use it in ice PCI driver. Configuration changes > result in unplugging the auxiliary RDMA device and re-plugging > it with updated values for irdma auxiiary driver to c

[PATCH net-next] enic: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- .../net/ethernet/cisco/enic/enic_main.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/en

[PATCH net-next] tulip: de2104x: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- .../net/ethernet/dec/tulip/de2104x.c| 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2

[PATCH net-next] net: fealnx: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/fealnx.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/

[PATCH net-next] net: sundance: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/dlink/sundance.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/net/ethernet/dlink/sundanc

[PATCH net-next] tulip: windbond-840: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- .../ethernet/dec/tulip/winbond-840.c| 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/win

[PATCH net-next] net: atheros: atl2: use module_pci_driver to simplify the code

2021-04-07 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- .../atheros/atlx/atl2.c| 24 +- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/net/ethernet/atheros/atlx/

[PATCH net-next] net: encx24j600: use module_spi_driver to simplify the code

2021-04-07 Thread Wei Yongjun
module_spi_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun --- .../net/ethernet/microchip/encx24j600.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Wei Liu
On Wed, Apr 07, 2021 at 02:34:01PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Wei Liu > > Sent: Wednesday, April 7, 2021 9:17 AM > > To: Dexuan Cui > > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > > ; Haiyang Zhang ; Stephen > > Hemminger ; wei@ker

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 10:55 AM > To: Haiyang Zhang > Cc: Dexuan Cui ; da...@davemloft.net; > k...@kernel.org; KY Srinivasan ; Stephen Hemminger > ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; linux- > ker...@vger.kerne

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Tuesday, April 6, 2021 9:17 PM > > On Mon, Apr 05, 2021 at 08:49:56AM +0300, Leon Romanovsky wrote: > > @@ -2293,6 +2295,17 @@ static void ib_sa_event(struct ib_event_handler > *handler, > > } > > } > > > > +static bool ib_sa_client_supported(struct ib_devi

RE: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma)

2021-04-07 Thread Saleem, Shiraz
> Subject: Re: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA > (irdma) > > On Tue, Apr 06, 2021 at 11:30:23PM +, Saleem, Shiraz wrote: > > > Hi Jason - I think its because I used --irreversible-delete flag in git > > format-patch > for review that this one doesn't apply. > >

[PATCH] arch/arm64/kernel/traps: Use find_vma_intersection() in traps for setting si_code

2021-04-07 Thread Liam Howlett
find_vma() will continue to search upwards until the end of the virtual memory space. This means the si_code would almost never be set to SEGV_MAPERR even when the address falls outside of any VMA. The result is that the si_code is not reliable as it may or may not be set to the correct result, d

Re: [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent

2021-04-07 Thread Richard Cochran
On Wed, Apr 07, 2021 at 10:28:44AM +0100, Marc Zyngier wrote: > On Tue, 30 Mar 2021 15:54:26 +0100, > Marc Zyngier wrote: > > > > From: Jianyong Wu > > > > Currently, the ptp_kvm module contains a lot of x86-specific code. > > Let's move this code into a new arch-specific file in the same direc

Re: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Jason Gunthorpe
On Wed, Apr 07, 2021 at 03:06:35PM +, Parav Pandit wrote: > > > > From: Jason Gunthorpe > > Sent: Tuesday, April 6, 2021 9:17 PM > > > > On Mon, Apr 05, 2021 at 08:49:56AM +0300, Leon Romanovsky wrote: > > > @@ -2293,6 +2295,17 @@ static void ib_sa_event(struct ib_event_handler > > *handler

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Wei Liu > Sent: Wednesday, April 7, 2021 11:01 AM > To: Haiyang Zhang > Cc: Wei Liu ; Dexuan Cui ; > da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Stephen Hemminger ; > Wei Liu ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-hyp..

Re: [PATCH v4 resend 21/23] RDMA/irdma: Add ABI definitions

2021-04-07 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 07:15:00PM -0500, Shiraz Saleem wrote: > From: Mustafa Ismail > > Add ABI definitions for irdma. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > include/uapi/rdma/irdma-abi.h | 116 > ++ > 1 file changed, 116

Re: [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent

2021-04-07 Thread Marc Zyngier
On Wed, 07 Apr 2021 16:13:34 +0100, Richard Cochran wrote: > > On Wed, Apr 07, 2021 at 10:28:44AM +0100, Marc Zyngier wrote: > > On Tue, 30 Mar 2021 15:54:26 +0100, > > Marc Zyngier wrote: > > > > > > From: Jianyong Wu > > > > > > Currently, the ptp_kvm module contains a lot of x86-specific c

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-07 Thread J. Bruce Fields
On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. We're already dereferenced msg. Nothing has set gss_msg to NULL. It's the gss_msg->cou

[PATCH net v2 0/3] Action initalization fixes

2021-04-07 Thread Vlad Buslov
This series fixes reference counting of action instances and modules in several parts of action init code. The first patch reverts previous fix that didn't properly account for rollback from a failure in the middle of the loop in tcf_action_init() which is properly fixed by the following patch. Vl

[PATCH net v2 1/3] Revert "net: sched: bump refcount for new action in ACT replace mode"

2021-04-07 Thread Vlad Buslov
This reverts commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149. Following commit in series fixes the issue without introducing regression in error rollback of tcf_action_destroy(). Signed-off-by: Vlad Buslov --- net/sched/act_api.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sched/a

[PATCH net v2 2/3] net: sched: fix action overwrite reference counting

2021-04-07 Thread Vlad Buslov
Action init code increments reference counter when it changes an action. This is the desired behavior for cls API which needs to obtain action reference for every classifier that points to action. However, act API just needs to change the action and releases the reference before returning. This seq

[PATCH net v2 3/3] net: sched: fix err handler in tcf_action_init()

2021-04-07 Thread Vlad Buslov
With recent changes that separated action module load from action initialization tcf_action_init() function error handling code was modified to manually release the loaded modules if loading/initialization of any further action in same batch failed. For the case when all modules successfully loaded

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-07 Thread Jakub Kicinski
On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote: > Thanks for the effort, but reportedly [1] it made no difference, > unfortunately. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8 The only other option I see is that somehow the NAPI has no rings. diff --git a/drivers/n

Re: [PATCH v4 01/23] iidc: Introduce iidc.h

2021-04-07 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 04:01:03PM -0500, Shiraz Saleem wrote: > +/* Following APIs are implemented by core PCI driver */ > +struct iidc_core_ops { > + /* APIs to allocate resources such as VEB, VSI, Doorbell queues, > + * completion queues, Tx/Rx queues, etc... > + */ > + int (*

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Wednesday, April 7, 2021 8:44 PM > > On Wed, Apr 07, 2021 at 03:06:35PM +, Parav Pandit wrote: > > > > > > > From: Jason Gunthorpe > > > Sent: Tuesday, April 6, 2021 9:17 PM > > > > > > On Mon, Apr 05, 2021 at 08:49:56AM +0300, Leon Romanovsky wrote: > > >

[PATCH net-next 0/2] Additional tests for action API

2021-04-07 Thread Vlad Buslov
Add two new tests for action create/change code. Vlad Buslov (2): tc-testing: add simple action test to verify batch add cleanup tc-testing: add simple action test to verify batch change cleanup .../tc-testing/tc-tests/actions/simple.json | 59 +++ 1 file changed, 59 insert

[PATCH net-next 1/2] tc-testing: add simple action test to verify batch add cleanup

2021-04-07 Thread Vlad Buslov
Verify cleanup of failed actions batch add where second action in batch fails after successful init of first action. Signed-off-by: Vlad Buslov --- .../tc-testing/tc-tests/actions/simple.json | 30 +++ 1 file changed, 30 insertions(+) diff --git a/tools/testing/selftests/tc-te

[PATCH net-next 2/2] tc-testing: add simple action test to verify batch change cleanup

2021-04-07 Thread Vlad Buslov
Verify cleanup of failed actions batch change where second action in batch fails after successful init of first action. Signed-off-by: Vlad Buslov --- .../tc-testing/tc-tests/actions/simple.json | 29 +++ 1 file changed, 29 insertions(+) diff --git a/tools/testing/selftests/tc

  1   2   3   >