> From: Leon Romanovsky <l...@kernel.org> > Sent: Wednesday, April 7, 2021 1:15 AM > > ... > > int gdma_test_eq(struct gdma_context *gc, struct gdma_queue *eq) > > { > > struct gdma_generate_test_event_req req = { 0 }; > > struct gdma_general_resp resp = { 0 }; > > BTW, you don't need to write { 0 }, the {} is enough. Thanks for the suggestion! I'll use {0} in v2.
BTW, looks like both are widely used in the kernel. Maybe someone should update scripts/checkpatch.pl to add a warning agaist { 0 } in new code, if {0} is preferred. :-) dexuan@localhost:~/linux$ grep "= { 0 };" kernel/ -nr | wc -l 4 dexuan@localhost:~/linux$ grep "= {0};" kernel/ -nr | wc -l 4 dexuan@localhost:~/linux$ grep "= { 0 };" Documentation/ -nr Documentation/networking/page_pool.rst:117: struct page_pool_params pp_params = { 0 }; dexuan@localhost:~/linux$ grep "= { 0 };" drivers/ -nr | wc -l 1085 dexuan@localhost:~/linux$ grep "= {0};" drivers/ -nr | wc -l 1321 dexuan@localhost:~/linux$ grep "= { 0 };" drivers/net/ -nr | wc -l 408 dexuan@localhost:~/linux$ grep "= {0};" drivers/net/ -nr | wc -l 708