Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-26 Thread Jason Wang
在 2021/3/26 下午2:56, Yongji Xie 写道: On Fri, Mar 26, 2021 at 2:16 PM Jason Wang wrote: 在 2021/3/26 下午1:14, Yongji Xie 写道: + } + map->bounce_page = page; + + /* paired with vduse_domain_map_page() */ + smp_mb(); So this is suspicious. It's better to explain like, we need make

Re: [PATCH] Bluetooth: L2CAP: Rudimentary typo fixes

2021-03-26 Thread Marcel Holtmann
Hi Bhaskar, > s/minium/minimum/ > s/procdure/procedure/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/bluetooth/l2cap_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
Hi Andrew, Thanks for your kindly reply! > -Original Message- > From: Andrew Lunn > Sent: 2021年3月25日 20:45 > To: Joakim Zhang > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: Re: FEC unbind/bind feature > > On Thu, Mar 25, 2021 at 08:04:58AM +, Jo

Re: [PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-26 Thread Geert Uytterhoeven
Hi Anthony, Norbert, Thanks for your patch! On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen wrote: > From: Norbert Ciosek > > Remove padding from RSS structures. Previous layout > could lead to unwanted compiler optimizations > in loops when iterating over key and lut arrays. >From an earlier pri

[PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

2021-03-26 Thread Zhang Jianhua
If CONFIG_ATH9K=y, the following errors will be seen while compiling gpio.c drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 against undef

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年3月26日 16:03 > To: Andrew Lunn > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: RE: FEC unbind/bind feature > > > Hi Andrew, > > Thanks for your kindly reply! > > > -Original Message- > >

[PATCH ipsec v2] xfrm: Provide private skb extensions for segmented and hw offloaded ESP packets

2021-03-26 Thread Steffen Klassert
Commit 94579ac3f6d0 ("xfrm: Fix double ESP trailer insertion in IPsec crypto offload.") added a XFRM_XMIT flag to avoid duplicate ESP trailer insertion on HW offload. This flag is set on the secpath that is shared amongst segments. This lead to a situation where some segments are not transformed co

Re: [net-next V2 01/13] net/mlx5e: alloc the correct size for indirection_rqt

2021-03-26 Thread Arnd Bergmann
On Fri, Mar 26, 2021 at 3:53 AM Saeed Mahameed wrote: > > From: Saeed Mahameed > > The cited patch allocated the wrong size for the indirection_rqt table, > fix that. > > Fixes: 2119bda642c4 ("net/mlx5e: allocate 'indirection_rqt' buffer > dynamically") > CC: Arnd Bergmann > Signed-off-by: Saee

linux-next: build warning after merge of the net-next tree

2021-03-26 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (htmldocs) produced this warning: net/tipc/bearer.c:248: warning: Function parameter or member 'extack' not described in 'tipc_enable_bearer' Introduced by commit b83e214b2e04 ("tipc: add extack messages for bearer/media failu

Re: linux-next: build failure after merge of the tip tree

2021-03-26 Thread Sedat Dilek
On Mon, Mar 22, 2021 at 10:02 AM Borislav Petkov wrote: > > On Mon, Mar 22, 2021 at 02:37:14PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > arch/x86/net/bpf_jit_comp.c: In function 'arch_

Re: [PATCH bpf 2/3] libbpf: restore umem state after socket create failure

2021-03-26 Thread Magnus Karlsson
On Wed, Mar 24, 2021 at 3:46 PM Ciara Loftus wrote: > > If the call to socket_create fails, the user may want to retry the > socket creation using the same umem. Ensure that the umem is in the > same state on exit if the call failed by restoring the _save pointers > and not unmapping the set of um

RE: [PATCH v2 net-next 4/5] stmmac: intel: add support for multi-vector msi and msi-x

2021-03-26 Thread Ong, Boon Leong
>+static int stmmac_config_multi_msi(struct pci_dev *pdev, >+ struct plat_stmmacenet_data *plat, >+ struct stmmac_resources *res) >+{ For optimum RX & TX queue processing on the same IRQ, we should use irq_set_affinity_hint() to set th

[PATCH 0/2] enetc: support PTP Sync packet one-step timestamping

2021-03-26 Thread Yangbo Lu
This patch-set is to add one-step timestamping support for PTP Sync packet. Since ENETC single-step register has to be configured dynamically per packet for correctionField offeset and UDP checksum update, current one-step timestamping packet has to be sent only when the last one completes transmit

[PATCH 2/2] enetc: support PTP Sync packet one-step timestamping

2021-03-26 Thread Yangbo Lu
This patch is to add support for PTP Sync packet one-step timestamping. Since ENETC single-step register has to be configured dynamically per packet for correctionField offeset and UDP checksum update, current one-step timestamping packet has to be sent only when the last one completes transmitting

Re: [PATCH net-next v2 11/12] net: phy: marvell10g: print exact model

2021-03-26 Thread Russell King - ARM Linux admin
On Thu, Mar 25, 2021 at 09:54:14PM +0100, Marek Behún wrote: > On Thu, 25 Mar 2021 21:44:21 +0100 > Heiner Kallweit wrote: > > > On 25.03.2021 21:29, Marek Behún wrote: > > > On Thu, 25 Mar 2021 15:54:52 + > > > Russell King - ARM Linux admin wrote: > > > > > >> The 88X3310 and 88X3340 ca

[PATCH 1/2] enetc: mark TX timestamp type per skb

2021-03-26 Thread Yangbo Lu
Mark TX timestamp type per skb on skb->cb[0], instead of global variable for all skbs. This is a preparation for one step timestamp support. For one-step timestamping enablement, there will be both one-step and two-step PTP messages to transfer. And a skb queue is needed for one-step PTP messages

[PATCH net-next] net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg

2021-03-26 Thread mohammad . athari . ismail
From: Mohammad Athari Bin Ismail In this patch, "net: stmmac: support FPE link partner hand-shaking procedure", priv->plat->fpe_cfg wouldn`t be "devm_kzalloc"ed if dma_cap->frpsel is 0 (Flexible Rx Parser is not supported in SoC) in tc_init(). So, fpe_cfg will be remain as NULL and accessing it w

[net-next] tipc: fix kernel-doc warnings

2021-03-26 Thread Hoang Le
Fix kernel-doc warning introduced in commit b83e214b2e04 ("tipc: add extack messages for bearer/media failure"): net/tipc/bearer.c:248: warning: Function parameter or member 'extack' not described in 'tipc_enable_bearer' Fixes: b83e214b2e04 ("tipc: add extack messages for bearer/media failure")

Re: [PATCH bpf 3/3] libbpf: ignore return values of setsockopt for XDP rings.

2021-03-26 Thread Magnus Karlsson
On Wed, Mar 24, 2021 at 3:46 PM Ciara Loftus wrote: > > During xsk_socket__create the XDP_RX_RING and XDP_TX_RING setsockopts > are called to create the rx and tx rings for the AF_XDP socket. If the ring > has already been set up, the setsockopt will return an error. However, > in the event of a f

Re: [PATCH bpf 1/3] libbpf: ensure umem pointer is non-NULL before dereferencing

2021-03-26 Thread Magnus Karlsson
On Wed, Mar 24, 2021 at 3:46 PM Ciara Loftus wrote: > > Calls to xsk_socket__create dereference the umem to access the > fill_save and comp_save pointers. Make sure the umem is non-NULL > before doing this. > > Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and > devices") > >

Re: [PATCH bpf] bpf: link: refuse non-zero file_flags in BPF_OBJ_GET

2021-03-26 Thread Lorenz Bauer
On Fri, 26 Mar 2021 at 04:43, Andrii Nakryiko wrote: > > Makes sense, but see below about details. > > Also, should we do the same for BPF programs as well? I guess they > don't have a "write operation", once loaded, but still... I asked myself the same question, I don't have a good answer. Right

[PATCH 1/1] net/mlx5: Remove duplicated header file inclusion

2021-03-26 Thread Zhen Lei
The header file "esw/indir_table.h" is already included above and can be removed here. Signed-off-by: Zhen Lei --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/n

Re: [PATCH] net:qrtr: fix allocator flag of idr_alloc_u32() in qrtr_port_assign()

2021-03-26 Thread Greg Kroah-Hartman
On Fri, Mar 26, 2021 at 11:33:45AM +0800, Du Cheng wrote: > change the allocator flag of idr_alloc_u32 from GFP_ATOMIC to > GFP_KERNEL, as GFP_ATOMIC caused BUG: "using smp_processor_id() in > preemptible" as reported by syzkaller. > > Reported-by: syzbot+3eec59e770685e3dc...@syzkaller.appspotmail

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Paolo Abeni
Hello, On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: > From: Norman Maurer > > Support for UDP_GRO was added in the past but the implementation for > getsockopt was missed which did lead to an error when we tried to > retrieve the setting for UDP_GRO. This patch adds the missing switch

Re: [PATCH bpf v2 2/2] bpf/selftests: test that kernel rejects a TCP CC with an invalid license

2021-03-26 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Thu, Mar 25, 2021 at 2:11 PM Toke Høiland-Jørgensen > wrote: >> >> This adds a selftest to check that the verifier rejects a TCP CC struct_ops >> with a non-GPL license. >> >> v2: >> - Use a minimal struct_ops BPF program instead of rewriting bpf_dctcp's >> licens

[PATCH 1/1] media: atomisp: Remove duplicated header file inclusion

2021-03-26 Thread Zhen Lei
The header file "ia_css_isys.h" is already included above and can be removed here. Signed-off-by: Zhen Lei --- drivers/staging/media/atomisp/pci/sh_css.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c

[PATCH bpf v3 2/2] bpf/selftests: test that kernel rejects a TCP CC with an invalid license

2021-03-26 Thread Toke Høiland-Jørgensen
This adds a selftest to check that the verifier rejects a TCP CC struct_ops with a non-GPL license. v3: - Rename prog to bpf_tcp_nogpl - Use ASSERT macros instead of CHECK - Skip unneeded initialisation, unconditionally close skeleton v2: - Use a minimal struct_ops BPF program instead of rewriting

[PATCH bpf v3 1/2] bpf: enforce that struct_ops programs be GPL-only

2021-03-26 Thread Toke Høiland-Jørgensen
With the introduction of the struct_ops program type, it became possible to implement kernel functionality in BPF, making it viable to use BPF in place of a regular kernel module for these particular operations. Thus far, the only user of this mechanism is for implementing TCP congestion control a

[PATCH -next 1/3] net: llc: Correct some function names in header

2021-03-26 Thread Yang Yingliang
Fix the following make W=1 kernel build warning: net/llc/llc_c_ev.c:622: warning: expecting prototype for conn_ev_qlfy_last_frame_eq_1(). Prototype was for llc_conn_ev_qlfy_last_frame_eq_1() instead net/llc/llc_c_ev.c:636: warning: expecting prototype for conn_ev_qlfy_last_frame_eq_0(). Proto

[PATCH -next 0/3] net: llc: Correct some function names in header

2021-03-26 Thread Yang Yingliang
Fix some make W=1 kernel build warnings in net/llc/ Yang Yingliang (3): net: llc: Correct some function names in header net: llc: Correct function name llc_sap_action_unitdata_ind() in header net: llc: Correct function name llc_pdu_set_pf_bit() in header net/llc/llc_c_ev.c | 4 ++-- ne

[PATCH -next 3/3] net: llc: Correct function name llc_pdu_set_pf_bit() in header

2021-03-26 Thread Yang Yingliang
Fix the following make W=1 kernel build warning: net/llc/llc_pdu.c:36: warning: expecting prototype for pdu_set_pf_bit(). Prototype was for llc_pdu_set_pf_bit() instead Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- net/llc/llc_pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH -next 2/3] net: llc: Correct function name llc_sap_action_unitdata_ind() in header

2021-03-26 Thread Yang Yingliang
Fix the following make W=1 kernel build warning: net/llc/llc_s_ac.c:38: warning: expecting prototype for llc_sap_action_unit_data_ind(). Prototype was for llc_sap_action_unitdata_ind() instead Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- net/llc/llc_s_ac.c | 2 +- 1 file chang

Re: [PATCH v2 bpf-next 03/14] bpf: Support bpf program calling kernel function

2021-03-26 Thread Toke Høiland-Jørgensen
Martin KaFai Lau writes: > On Thu, Mar 25, 2021 at 11:02:23PM +0100, Toke Høiland-Jørgensen wrote: >> Martin KaFai Lau writes: >> >> > This patch adds support to BPF verifier to allow bpf program calling >> > kernel function directly. >> >> Hi Martin >> >> This is exciting stuff! :) >> >> Ju

Re: [PATCH net-next] ipv6: fix clang Wformat warning

2021-03-26 Thread Steffen Klassert
On Mon, Mar 22, 2021 at 12:56:49PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with 'make W=1', clang warns about a mismatched > format string: > > net/ipv6/ah6.c:710:4: error: format specifies type 'unsigned short' but the > argument has type 'int' [-Werror,-Wformat] >

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed which did lead to an error when we tried to >>

[PATCH 0/9] A set of patches for ofono/mmsd

2021-03-26 Thread Christopher Talbot
Hello, I am submitting a set of patches I have been workin on for mmsd. I have been working on the assumption that the ofono mailing list is the correct avenue to submit patches for mmsd, and I have attempted to submit patches on a couple of occasions: https://lists.ofono.org/hyperkitty/list/of.

[PATCH 1/9] Fix mmsd to work with T-mobile

2021-03-26 Thread Christopher Talbot
This patch is based off of anteater's patch to enable T-Mobile ( https://git.sr.ht/~anteater/mmsd), but fixes a couple of hacks that were in it --- Makefile.am | 3 +- gweb/gresolv.c| 73 ++- gweb/gweb.c | 1 + plugins/ofono.c | 11 ++- src/mmsutil.c | 23

[PATCH 2/9] Ensure Compatibility with Telus Canada

2021-03-26 Thread Christopher Talbot
mmsd decodes a header that is not in the standard. This patch allows this header to be decoded --- src/mmsutil.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/mmsutil.c b/src/mmsutil.c index 5fcf358..9430bf1 100644 --- a/src/mmsutil.c +++ b/src/mmsutil

netdev@vger.kernel.org

2021-03-26 Thread Christopher Talbot
This patch fixes two issues to ensure compatibility with AT&T: 1) Explicity close connections to the mmsc 2) Allow MMS Proxies that are domain names --- gweb/gweb.c | 3 ++- src/service.c | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gweb/gweb.c b/gweb/gweb.c index f72e1

[PATCH 4/9] Fix issue if there is an empty string in encoded text

2021-03-26 Thread Christopher Talbot
A swedish carrier sends an empty string in the subject line. This patch allows mmsd to handle it --- src/mmsutil.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mmsutil.c b/src/mmsutil.c index 9430bf1..615198f 100644 --- a/src/mmsutil.c +++ b/src/mmsutil.c @@ -297,6 +297,13 @@ s

[PATCH 6/9] Update README

2021-03-26 Thread Christopher Talbot
This updates the README for mmsd --- README | 66 +- 1 file changed, 61 insertions(+), 5 deletions(-) diff --git a/README b/README index e33be69..cecc99f 100644 --- a/README +++ b/README @@ -2,20 +2,76 @@ Multimedia Messaging Service **

[PATCH 5/9] Allow for a user configurable maximum attachment size

2021-03-26 Thread Christopher Talbot
Android and iOS enforce a maximum attachment size for MMS messages. This patch enforces a maximum attachment size for MMS messages and makes it user configurable. The default maximum size is based off of Android, which has a maximum MMS size of 1.1 Megabytes --- src/service.c | 38 +++

[PATCH 7/9] Fix Draft and Sent Bugs

2021-03-26 Thread Christopher Talbot
This fixes some bugs related to sending MMSes: - Makes sure "sent" has an accurate time - Allows "Draft" to Go to "Sent" on the dbus - Allows the time to be preserved if mmsd is closed and opened in sent and recieved messages --- src/mmsutil.h | 2 ++ src/service.c | 60 ++

[PATCH 8/9] Allow Maintainer mode to compile without -WError

2021-03-26 Thread Christopher Talbot
Without this, compiling in maintainer mode errors out. --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 329c6a9..314dbb1 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -15,7 +15,7 @@ AC_DEFUN([COMPILER_FLAGS], [

[PATCH 9/9] Add a Modem Manager Plugin

2021-03-26 Thread Christopher Talbot
This patch enables support for Modem Manager with mmsd. It has been tested on Mobian, PostmarketOS, and PureOS. It has also been tested on the Pinephone and Librem 5. It has also been tested on various carriers in the US, France, and Sweden. --- Makefile.am | 8 +- README

Re: [PATCH net-next] net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg

2021-03-26 Thread Marek Szyprowski
On 26.03.2021 10:10, mohammad.athari.ism...@intel.com wrote: > From: Mohammad Athari Bin Ismail > > In this patch, "net: stmmac: support FPE link partner hand-shaking > procedure", priv->plat->fpe_cfg wouldn`t be "devm_kzalloc"ed if > dma_cap->frpsel is 0 (Flexible Rx Parser is not supported in So

[PATCH 7/9] Fix Draft and Sent Bugs

2021-03-26 Thread Christopher Talbot
This fixes some bugs related to sending MMSes: - Makes sure "sent" has an accurate time - Allows "Draft" to Go to "Sent" on the dbus - Allows the time to be preserved if mmsd is closed and opened in sent and recieved messages --- src/mmsutil.h | 2 ++ src/service.c | 60 ++

[PATCH net-next 0/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-26 Thread Tobias Waldekranz
This is logically the v2 of this patch: https://lore.kernel.org/netdev/20210323102326.3677940-1-tob...@waldekranz.com/ In addition to the mv88e6xxx support to dynamically change the protocol, it is now possible to override the protocol from the device tree. This means that when a board vendor find

[PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-03-26 Thread Tobias Waldekranz
The 'dsa,tag-protocol' is used to force a switch tree to use a particular tag protocol, typically because the Ethernet controller that it is connected to is not compatible with the default one. Signed-off-by: Tobias Waldekranz --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 7 +++ 1

[PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-03-26 Thread Tobias Waldekranz
All devices are capable of using regular DSA tags. Support for Ethertyped DSA tags sort into three categories: 1. No support. Older chips fall into this category. 2. Full support. Datasheet explicitly supports configuring the CPU port to receive FORWARDs with a DSA tag. 3. Undocumented suppor

[PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-26 Thread Tobias Waldekranz
Some combinations of tag protocols and Ethernet controllers are incompatible, and it is hard for the driver to keep track of these. Therefore, allow the device tree author (typically the board vendor) to inform the driver of this fact by selecting an alternate protocol that is known to work. Sign

[PATCHv3 bpf] bpf: Take module reference for trampoline in module

2021-03-26 Thread Jiri Olsa
Currently module can be unloaded even if there's a trampoline register in it. It's easily reproduced by running in parallel: # while :; do ./test_progs -t module_attach; done # while :; do rmmod bpf_testmod; sleep 0.5; done Taking the module reference in case the trampoline's ip is within the

Re: [PATCH net-next v2 11/12] net: phy: marvell10g: print exact model

2021-03-26 Thread Marek Behún
On Fri, 26 Mar 2021 09:07:34 + Russell King - ARM Linux admin wrote: > > Nice, didn't know about that. But I fear whether this would always work > > for the 88X3310 vs 88X3310P, it is possible that this feature is only > > recognizable if the firmware in the PHY is already running. > > The

Re: [PATCH 2/2] enetc: support PTP Sync packet one-step timestamping

2021-03-26 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955 base:b4f20b70784aabf97e1727561e775500f6e294c7 config: ia64-al

Re: [PATCH net-next v4 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 06:04:37PM -0600, Robert Hancock wrote: > Update DT bindings to describe all of the clocks that the axienet > driver will now be able to make use of. > > Acked-by: Rob Herring > Signed-off-by: Robert Hancock Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v4 2/2] net: axienet: Enable more clocks

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 06:04:38PM -0600, Robert Hancock wrote: > This driver was only enabling the first clock on the device, regardless > of its name. However, this controller logic can have multiple clocks > which should all be enabled. Add support for enabling additional clocks. > The clock nam

Re: [PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 07:07:24PM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam::reserved is never looked at by the core. > Make sure it's actually 0. Unfortunately we can't return an error > because old ethtool doesn't zero-initialize the structure for SET. > On GET we can be more verbos

Re: [PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool_fecparam->fec

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 07:07:26PM -0700, Jakub Kicinski wrote: > Reject NONE on set, this mode means device does not support > FEC so it's a little out of place in the set interface. > > This should be safe to do - user space ethtool does not allow > the use of NONE on set. A few drivers treat it

Re: [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 07:07:27PM -0700, Jakub Kicinski wrote: > The definition of the FEC driver interface is quite unclear. > Improve the documentation. > > This is based on current driver and user space code, as well > as the discussions about the interface: > > RFC v1 (24 Oct 2016): > https

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Paolo Abeni
On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote: > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > One thing you can do to simplifies the maintainer's life, would be post > > a v2 with the correct tag (and ev. obsolete this patch in patchwork). > > I am quite new to contribute patches to

Re: FEC unbind/bind feature

2021-03-26 Thread Andrew Lunn
> > Please wrap your lines at around 75 characters. Standard netiquette rules > > for > > emails apply to all Linux lists. > > Ok, thanks. Please keep fighting with your email client, > Yes, you are right. It should be always fine for single FEC controller, and > unbind/bind one by one should

[PATCH net-next] farsync: use DEFINE_SPINLOCK() for spinlock

2021-03-26 Thread 'Liu Jian
From: Liu Jian spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Liu Jian --- drivers/net/wan/farsync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wan/

Re: FEC unbind/bind feature

2021-03-26 Thread Andrew Lunn
> One more add, yes, I am looking the drivers/net/mdio, it is better to > implement standalone MDIO driver when writing the MAC driver at the beginning. > Now if I abstract MDIO driver from FEC driver, dt bindings would change, it > will break all existing implementations in the kernel based on F

[PATCH bpf-next] bpf: trace jit code when enable BPF_JIT_ALWAYS_ON

2021-03-26 Thread Jianlin Lv
When CONFIG_BPF_JIT_ALWAYS_ON is enabled, the value of bpf_jit_enable in /proc/sys is limited to SYSCTL_ONE. This is not convenient for debugging. This patch modifies the value of extra2 (max) to 2 that support developers to emit traces on kernel log. Signed-off-by: Jianlin Lv --- net/core/sysct

Re: [RFC PATCH V5 net-next 5/5] ethtool: Add fallback to get_module_eeprom from netlink command

2021-03-26 Thread Moshe Shemesh
On 3/25/2021 8:13 PM, Don Bollinger wrote: From: Vladyslav Tarasiuk In case netlink get_module_eeprom_by_page() callback is not implemented by the driver, try to call old get_module_info() and get_module_eeprom() pair. Recalculate parameters to get_module_eeprom() offset and len using page nu

Re: [RFC PATCH V5 net-next 0/5] ethtool: Extend module EEPROM dump API

2021-03-26 Thread Moshe Shemesh
On 3/26/2021 1:41 AM, Andrew Lunn wrote: External email: Use caution opening links or attachments On Thu, Mar 25, 2021 at 04:56:50PM +0200, Moshe Shemesh wrote: Ethtool supports module EEPROM dumps via the `ethtool -m ` command. But in current state its functionality is limited - offset and

[PATCH iproute2-next] police: add support for packet-per-second rate limiting

2021-03-26 Thread Simon Horman
From: Baowen Zheng Allow a policer action to enforce a rate-limit based on packets-per-second, configurable using a packet-per-second rate and burst parameters. e.g. # $TC actions add action police pkts_rate 1000 pkts_burst 200 index 1 # $TC actions ls action police total acts 1 acti

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-26 Thread Vladimir Oltean
Hi Tobias, On Fri, Mar 26, 2021 at 11:56:47AM +0100, Tobias Waldekranz wrote: > } else { > - dst->tag_ops = dsa_tag_driver_get(tag_protocol); > - if (IS_ERR(dst->tag_ops)) { > - if (PTR_ERR(dst->tag_ops) == -ENOPROTOOPT) > -

[PATCH net-next 2/2] selftests: forwarding: Add tc-police tests for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Test tc-police action for packets per second. The test is mainly in scenarios Rx policing and Tx policing. The test passes with veth pairs ports. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- tools/testing/selftests/net/forwarding/lib.sh | 9 +++ .../selftest

[PATCH net-next 0/2] selftest: add tests for packet per second

2021-03-26 Thread Simon Horman
Add self tests for the recently added packet per second rate limiting feature of the TC policer action[1]. The forwarding selftest (patch 2/2) depends on iproute2 support for packet per second rate limiting, which has been posted separately[2] [1] [PATCH v3 net-next 0/3] net/sched: act_police: ad

[PATCH net-next 1/2] selftests: tc-testing: add action police selftest for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Add selftest cases in action police for packets per second. These tests depend on corresponding iproute2 command support. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- It is also planned, as a follow-up, to provide packet per second rate limiting tests in tools

Re: linux-next: build failure after merge of the tip tree

2021-03-26 Thread Borislav Petkov
On Fri, Mar 26, 2021 at 09:57:43AM +0100, Sedat Dilek wrote: > The commit b90829704780 "bpf: Use NOP_ATOMIC5 instead of > emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG" is now in Linus Git > (see [1]). > > Where will Stephen's fixup-patch be carried? > Linux-next? > net-next? > ? I guess we'll re

RE: FEC unbind/bind feature

2021-03-26 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年3月26日 20:34 > To: Joakim Zhang > Cc: Florian Fainelli ; hkallwe...@gmail.com; > netdev@vger.kernel.org > Subject: Re: FEC unbind/bind feature > > > One more add, yes, I am looking the drivers/net/mdio, it is better to > implement sta

Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

2021-03-26 Thread Jason Gunthorpe
On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote: > From: Mark Bloch > > Current code uses many different types when dealing with a port of a > RDMA device: u8, unsigned int and u32. Switch to u32 to clean up the > logic. > > This allows us to make (at least) the core view consist

[PATCH net-next] nexthop: Rename artifacts related to legacy multipath nexthop groups

2021-03-26 Thread Petr Machata
After resilient next-hop groups have been added recently, there are two types of multipath next-hop groups: the legacy "mpath", and the new "resilient". Calling the legacy next-hop group type "mpath" is unfortunate, because that describes the fact that a packet could be forwarded in one of several

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-26 Thread Tobias Waldekranz
On Fri, Mar 26, 2021 at 14:57, Vladimir Oltean wrote: > Hi Tobias, > > On Fri, Mar 26, 2021 at 11:56:47AM +0100, Tobias Waldekranz wrote: >> } else { >> -dst->tag_ops = dsa_tag_driver_get(tag_protocol); >> -if (IS_ERR(dst->tag_ops)) { >> -if (PTR_ER

Re: FEC unbind/bind feature

2021-03-26 Thread Andrew Lunn
On Fri, Mar 26, 2021 at 01:18:52PM +, Joakim Zhang wrote: > > > -Original Message- > > From: Andrew Lunn > > Sent: 2021年3月26日 20:34 > > To: Joakim Zhang > > Cc: Florian Fainelli ; hkallwe...@gmail.com; > > netdev@vger.kernel.org > > Subject: Re: FEC unbind/bind feature > > > > > One

Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-26 Thread Marcelo Ricardo Leitner
On Thu, Mar 25, 2021 at 10:46:12AM +0200, Oz Shlomo wrote: > Hi Marcelo, > > On 3/24/2021 11:20 PM, Marcelo Ricardo Leitner wrote: > > Maybe I'm just missing it but I'm not seeing how removals would only > > happen after the entry is actually offloaded. As in, if the add queue > > is very long, an

Re: [PATCH v2 bpf-next 03/14] bpf: Support bpf program calling kernel function

2021-03-26 Thread Alexei Starovoitov
On 3/26/21 3:11 AM, Toke Høiland-Jørgensen wrote: Martin KaFai Lau writes: On Thu, Mar 25, 2021 at 11:02:23PM +0100, Toke Høiland-Jørgensen wrote: Martin KaFai Lau writes: This patch adds support to BPF verifier to allow bpf program calling kernel function directly. Hi Martin This is ex

Re: [PATCH bpf-next] bpf: trace jit code when enable BPF_JIT_ALWAYS_ON

2021-03-26 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 5:40 AM Jianlin Lv wrote: > > When CONFIG_BPF_JIT_ALWAYS_ON is enabled, the value of bpf_jit_enable in > /proc/sys is limited to SYSCTL_ONE. This is not convenient for debugging. > This patch modifies the value of extra2 (max) to 2 that support developers > to emit traces o

[PATCH][next] ethtool: fec: Fix bitwise-and with ETHTOOL_FEC_NONE

2021-03-26 Thread Colin King
From: Colin Ian King Currently ETHTOOL_FEC_NONE_BIT is being used as a mask, however this is zero and the mask should be using ETHTOOL_FEC_NONE instead. Fix this. Addresses-Coverity: ("Bitwise-and with zero") Fixes: 42ce127d9864 ("ethtool: fec: sanitize ethtool_fecparam->fec") Signed-off-by: Col

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed which did lead to an error when we tried to >>

Re: [PATCH v2 0/8] Implement EBPF on powerpc32

2021-03-26 Thread Christophe Leroy
Le 22/03/2021 à 18:53, Andrii Nakryiko a écrit : On Mon, Mar 22, 2021 at 9:37 AM Christophe Leroy wrote: This series implements extended BPF on powerpc32. For the implementation details, see the patch before the last. The following operations are not implemented: case BPF

RE: [PATCH bpf 2/3] libbpf: restore umem state after socket create failure

2021-03-26 Thread Loftus, Ciara
> > On Wed, Mar 24, 2021 at 3:46 PM Ciara Loftus > wrote: > > > > If the call to socket_create fails, the user may want to retry the > > socket creation using the same umem. Ensure that the umem is in the > > same state on exit if the call failed by restoring the _save pointers > > and not unmapp

[PATCH v2 bpf 0/3] AF_XDP Socket Creation Fixes

2021-03-26 Thread Ciara Loftus
This series fixes some issues around socket creation for AF_XDP. Patch 1 fixes a potential NULL pointer dereference in xsk_socket__create_shared. Patch 2 ensures that the umem passed to xsk_socket__create(_shared) remains unchanged in event of failure. Patch 3 makes it possible for xsk_socket__c

[PATCH v2 bpf 1/3] libbpf: ensure umem pointer is non-NULL before dereferencing

2021-03-26 Thread Ciara Loftus
Calls to xsk_socket__create dereference the umem to access the fill_save and comp_save pointers. Make sure the umem is non-NULL before doing this. Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and devices") Acked-by: Magnus Karlsson Signed-off-by: Ciara Loftus --- tools/lib

[PATCH v2 bpf 2/3] libbpf: restore umem state after socket create failure

2021-03-26 Thread Ciara Loftus
If the call to xsk_socket__create fails, the user may want to retry the socket creation using the same umem. Ensure that the umem is in the same state on exit if the call fails by: 1. ensuring the umem _save pointers are unmodified. 2. not unmapping the set of umem rings that were set up with the u

[PATCH v2 bpf 3/3] libbpf: ignore return values of setsockopt for XDP rings.

2021-03-26 Thread Ciara Loftus
During xsk_socket__create the XDP_RX_RING and XDP_TX_RING setsockopts are called to create the rx and tx rings for the AF_XDP socket. If the ring has already been set up, the setsockopt will return an error. However, in the event of a failure during xsk_socket__create(_shared) after the rings have

[PATCH] Add Open/R to rt_protos

2021-03-26 Thread Cooper Ry Lees
From: Cooper Lees - Open Routing is using ID 99 for it's installed routes - https://github.com/facebook/openr - Kernel has accepted 99 in `rtnetlink.h` Signed-of-by: Cooper Lees --- etc/iproute2/rt_protos | 1 + 1 file changed, 1 insertion(+) diff --git a/etc/iproute2/rt_protos b/etc/iproute2

[PATCH net-next 00/12] net: ipa: rework resource programming

2021-03-26 Thread Alex Elder
This series reworks the way IPA resources are defined and programmed. It is a little long--and I apologize for that--but I think the patches are best taken together as a single unit. The IPA hardware operates with a set of distinct "resources." Each hardware instance has a fixed number of each r

[PATCH net-next 01/12] net: ipa: introduce ipa_resource.c

2021-03-26 Thread Alex Elder
Separate the IPA resource-related code into a new source file, "ipa_resource.c", and matching header file "ipa_resource.h". Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile | 2 +- drivers/net/ipa/ipa_main.c | 148 +--- drivers/net/ipa/ipa_reg.h | 42 -

[PATCH net-next 04/12] net: ipa: add some missing resource limits

2021-03-26 Thread Alex Elder
Currently, the SDM845 configuration data defines resource limits for the first two resource groups (for both source and destination resource types). The hardware supports additional resource groups, and we should program the resource limits for those groups as well. Even the "unused" destination

[PATCH net-next 02/12] net: ipa: fix bug in resource group limit programming

2021-03-26 Thread Alex Elder
If the number of resource groups supported by the hardware is less than a certain number, we return early in ipa_resource_config_src() and ipa_resource_config_dst() (to avoid programming resource limits for non-existent groups). Unfortunately, these checks are off by one. Fix this problem in the

[PATCH net-next 03/12] net: ipa: identify resource groups

2021-03-26 Thread Alex Elder
Define a new ipa_resource_group_id enumerated type, whose members have numeric values that match the resource group number used when programming the hardware. Each platform supports a different number of source and destination resource groups, so define the type separately for each platform in its

[PATCH net-next 06/12] net: ipa: index resource limits with type

2021-03-26 Thread Alex Elder
Remove the type field from the ipa_resource_src and ipa_resource_dst structures, and instead use that value as the index into the arrays of source and destination resources. Change ipa_resource_config_src() and ipa_resource_config_dst() so the resource type is passed in as an argument. Signed-off

[PATCH net-next 05/12] net: ipa: combine resource type definitions

2021-03-26 Thread Alex Elder
Combine the ipa_resource_type_src and ipa_resource_type_dst enumerated types into a single enumerated type, ipa_resource_type. Assign value 0 to the first element for the source and destination types, so their numeric values are preserved. Add some additional commentary where these are defined, s

[PATCH net-next 10/12] net: ipa: pass data for source and dest resource config

2021-03-26 Thread Alex Elder
Pass the resource data pointer to ipa_resource_config_src() and ipa_resource_config_dst() to be used for configuring resource limits. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_resource.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipa/i

[PATCH net-next 08/12] net: ipa: combine source and destination group limits

2021-03-26 Thread Alex Elder
Replace IPA_RESOURCE_GROUP_SRC_MAX and IPA_RESOURCE_GROUP_DST_MAX with a single symbol, IPA_RESOURCE_GROUP_MAX. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data.h | 11 +-- drivers/net/ipa/ipa_resource.c | 10 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff

[PATCH net-next 12/12] net: ipa: support more than 6 resource groups

2021-03-26 Thread Alex Elder
IPA versions 3.0 and 3.1 support up to 8 resource groups. There is some interest in supporting these older versions of the hardware, so update the resource configuration code to program resource limits for these groups if specified. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data.h |

[PATCH net-next 11/12] net: ipa: record number of groups in data

2021-03-26 Thread Alex Elder
The arrays of source and destination resource limits defined in configuration data are of a fixed size--which is the maximum number of resource groups supported for any platform. Most platforms will use fewer than that many groups. Add new members to the ipa_rsrc_group_id enumerated type to defin

  1   2   3   >