Hi Yangbo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210325]
[cannot apply to ipvs/master linus/master sparc-next/master v5.12-rc4 v5.12-rc3 
v5.12-rc2 v5.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
base:    b4f20b70784aabf97e1727561e775500f6e294c7
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/ee04f0512d195ae9492fffbd4598c659bbda85d8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Yangbo-Lu/enetc-support-PTP-Sync-packet-one-step-timestamping/20210326-170955
        git checkout ee04f0512d195ae9492fffbd4598c659bbda85d8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/freescale/enetc/enetc.c:263:13: warning: no previous 
>> prototype for 'enetc_start_xmit' [-Wmissing-prototypes]
     263 | netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device 
*ndev)
         |             ^~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || 
ARCH_WANT_FRAME_POINTERS
   Selected by
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && 
STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM 
&& !ARC && !X86


vim +/enetc_start_xmit +263 drivers/net/ethernet/freescale/enetc/enetc.c

   262  
 > 263  netdev_tx_t enetc_start_xmit(struct sk_buff *skb, struct net_device 
 > *ndev)
   264  {
   265          struct enetc_ndev_priv *priv = netdev_priv(ndev);
   266          struct enetc_bdr *tx_ring;
   267          int count;
   268  
   269          tx_ring = priv->tx_ring[skb->queue_mapping];
   270  
   271          if (unlikely(skb_shinfo(skb)->nr_frags > ENETC_MAX_SKB_FRAGS))
   272                  if (unlikely(skb_linearize(skb)))
   273                          goto drop_packet_err;
   274  
   275          count = skb_shinfo(skb)->nr_frags + 1; /* fragments + head */
   276          if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_NEEDED(count)) {
   277                  netif_stop_subqueue(ndev, tx_ring->index);
   278                  return NETDEV_TX_BUSY;
   279          }
   280  
   281          enetc_lock_mdio();
   282          count = enetc_map_tx_buffs(tx_ring, skb);
   283          enetc_unlock_mdio();
   284  
   285          if (unlikely(!count))
   286                  goto drop_packet_err;
   287  
   288          if (enetc_bd_unused(tx_ring) < ENETC_TXBDS_MAX_NEEDED)
   289                  netif_stop_subqueue(ndev, tx_ring->index);
   290  
   291          return NETDEV_TX_OK;
   292  
   293  drop_packet_err:
   294          dev_kfree_skb_any(skb);
   295          return NETDEV_TX_OK;
   296  }
   297  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to