[PATCH v2 0/1] net: Reduce rcu_barrier() contentions from 'unshare(CLONE_NEWNET)'

2020-12-10 Thread SeongJae Park
From: SeongJae Park On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls make the number of active slab objects including 'sock_inode_cache' type rapidly and continuously increase. As a result, memory pressure occurs. In more detail, I made an artificial reproducer that resem

[PATCH v2 1/1] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-10 Thread SeongJae Park
From: SeongJae Park In 'fqdir_exit()', a work for destroy of the 'fqdir' is enqueued. The work function, 'fqdir_work_fn()', calls 'rcu_barrier()'. In case of intensive 'fqdir_exit()' (e.g., frequent 'unshare()' systemcalls), this increased contention could result in unacceptably high latency of

Re: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c module

2020-12-10 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 11:10:12PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > For the flexible control of interrupt trigger type, remove the hard coded > interrupt trigger type in the i2c module. The trigger type will be loaded > from a dts. > > Signed-off-by: Bongsu Jeon > --- > drive

Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-10 Thread kernel test robot
Hi Aleksander, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master sparc-next/master v5.10-rc7 next-20201209] [If your patch is applied to the wrong git tree, kindly drop us a note.

Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB

2020-12-10 Thread Dan Carpenter
Hi Maxim, url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5 config: i386-randconfig-m021-20201209 (attached as .config) compiler

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-10 Thread Vlad Buslov
On Thu 10 Dec 2020 at 00:22, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 22:54:40 +0200 Vlad Buslov wrote: >> > Yes, I think the patch I sent should fix this, ETH_P_ARP should not be >> > dropped ;) >> > >> > I am testing this before offical patch submission. >> >> Your patch fixed TC geneve tests

Desinfetante

2020-12-10 Thread Raquel Carvalho
Bom Dia, A demanda por desinfetantes eficazes que permitam a eliminação de microrganismos prejudiciais é continuamente alta em todo o mundo. Expandir a oferta com uma gama profissional de produtos com atividade viricida e bactericida permite aumentar a posição competitiva da empresa e construir

Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Greg KH
On Wed, Dec 09, 2020 at 11:21:25PM -0800, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI device object ins

[PATCH] can: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli --- driv

[PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli --- driv

[PATCH] vxlan: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: Antonio Quartulli --- driv

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Patrick Havelange
On 2020-12-09 19:55, Madalin Bucur wrote: -Original Message- From: Patrick Havelange Sent: 09 December 2020 16:17 To: Madalin Bucur ; David S. Miller ; Jakub Kicinski ; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main r

Re: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-10 Thread Jisheng Zhang
On Tue, 8 Dec 2020 10:49:03 + Joakim Zhang wrote: > > > > -Original Message- > > From: Jisheng Zhang > > Sent: 2020年12月8日 18:24 > > To: Joakim Zhang > > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > > joab...@synopsys.com; da...@davemloft.net; k...@kernel.org; > > netdev@

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 10 December 2020 10:49 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource > region reservation >

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread David Laight
From: Xie He > Sent: 09 December 2020 22:54 > > On Wed, Dec 9, 2020 at 1:21 PM David Laight wrote: > > > > I always wondered about running Class 2 transport directly over LLC2 > > (rather than Class 4 over LLC1). > > But the only LLC2 user was netbios - and microsoft's LLC2 was broken. > > Not to

Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

2020-12-10 Thread Xie He
On Wed, Dec 9, 2020 at 10:27 PM Martin Schiller wrote: > > > Hi Martin, > > > > When you submit future patch series, can you try ensuring the code to > > be in a completely working state after each patch in the series? This > > makes reviewing the patches easier. After the patches get applied, > >

[PATCH] net: core: fix msleep() is not accurate

2020-12-10 Thread Yejune Deng
See Documentation/timers/timers-howto.rst, msleep() is not for (1ms - 20ms), There is a more advanced API is used. Signed-off-by: Yejune Deng --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d33099f..6e83ee03 100644

Re: [PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Jason A. Donenfeld
On Thu, Dec 10, 2020 at 9:56 AM Antonio Quartulli wrote: > > The definition of IS_ERR() already applies the unlikely() notation > when checking the error status of the passed pointer. For this > reason there is no need to have the same notation outside of > IS_ERR() itself. > > Clean up code by re

Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation

2020-12-10 Thread Xie He
On Wed, Dec 9, 2020 at 10:35 PM Martin Schiller wrote: > > Yes, that's also the reason why I already acked this patch. We can > solve this later a little bit cleaner if necessary. > > My patch that takes care of the orphaned packets in x25_receive_data() > has again a dependency on other patches,

RE: [PATCH net] tcp: fix cwnd-limited bug for TSO deferral where we send nothing

2020-12-10 Thread Ingemar Johansson S
Hi Slighty off topic It is a smaller mystery why I am listed as having reported this artifact ?. I don't have any memory that I did so.. strange 😐. Regards Ingemar > -Original Message- > From: Jakub Kicinski > Sent: den 10 december 2020 01:14 > To: Neal Cardwell > Cc: David Miller ;

pull-request: can-next 2020-12-10

2020-12-10 Thread Marc Kleine-Budde
are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.11-20201210 for you to fetch changes up to ee42bedc85a6e87791d5c20da6f2d150188cde54: can: mcp251xfd: Add support for internal l

[net-next 1/7] can: isotp: add SF_BROADCAST support for functional addressing

2020-12-10 Thread Marc Kleine-Budde
From: Oliver Hartkopp When CAN_ISOTP_SF_BROADCAST is set in the CAN_ISOTP_OPTS flags the CAN_ISOTP socket is switched into functional addressing mode, where only single frame (SF) protocol data units can be send on the specified CAN interface and the given tp.tx_id after bind(). In opposite to n

[net-next 5/7] can: m_can: add PCI glue driver for Intel Elkhart Lake

2020-12-10 Thread Marc Kleine-Budde
From: Jarkko Nikula Add support for M_CAN controller on Intel Elkhart Lake attached to the PCI bus. It integrates the Bosch M_CAN controller with Message RAM and the wrapper IP block with additional registers which all of them are within the same MMIO range. Currently only interrupt control regi

[net-next 2/7] can: rx-offload: can_rx_offload_offload_one(): avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread Marc Kleine-Budde
From: Antonio Quartulli The definition of IS_ERR() already applies the unlikely() notation when checking the error status of the passed pointer. For this reason there is no need to have the same notation outside of IS_ERR() itself. Clean up code by removing redundant notation. Signed-off-by: An

[net-next 6/7] can: flexcan: convert the driver to DT-only

2020-12-10 Thread Marc Kleine-Budde
From: Fabio Estevam The flexcan driver runs only on DT platforms, so simplify the code by using of_device_get_match_data() to retrieve the driver data and also by removing the unused id_table. Signed-off-by: Fabio Estevam Link: https://lore.kernel.org/r/20201128132855.7724-1-feste...@gmail.com

[net-next 4/7] can: m_can: move runtime PM enable/disable to m_can_platform

2020-12-10 Thread Marc Kleine-Budde
From: Patrik Flykt This is a preparatory patch for upcoming PCI based M_CAN devices. The current PM implementation would cause PCI based drivers to enable PM twice, once when the PCI device is added and a second time in m_can_class_register(). This will cause 'Unbalanced pm_runtime_enable!' to be

[net-next 3/7] can: m_can: m_can_config_endisable(): remove double clearing of clock stop request bit

2020-12-10 Thread Marc Kleine-Budde
From: Sean Nyekjaer The CSR bit is already cleared when arriving here so remove this section of duplicate code. The registers set in m_can_config_endisable() is set to same exact values as before this patch. Signed-off-by: Sean Nyekjaer Acked-by: Sriram Dash Acked-by: Dan Murphy Link: https:

[net-next 7/7] can: mcp251xfd: Add support for internal loopback mode

2020-12-10 Thread Marc Kleine-Budde
From: Manivannan Sadhasivam MCP251xFD supports internal loopback mode which can be used to verify CAN functionality in the absence of a real CAN device. Link: https://lore.kernel.org/r/20201201054019.11012-1-manivannan.sadhasi...@linaro.org Signed-off-by: Manivannan Sadhasivam [mkl: mcp251xfd_

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Patrick Havelange
On 2020-12-10 10:05, Madalin Bucur wrote: -Original Message- From: Patrick Havelange [snipped] But then that change would not be compatible with the existing device trees in already existing hardware. I'm not sure how to handle that case properly. One needs to be backwards compati

[PATCH] net/netconsole: Support VLAN for netconsole

2020-12-10 Thread Libing Zhou
During kernel startup phase, current netconsole doesn’t support VLAN since there is no VLAN interface setup already. This patch provides VLAN ID and PCP as optional boot/module parameters to support VLAN environment, thus kernel startup log can be retrieved via VLAN. Signed-off-by: Libing Zhou -

Re: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread Xie He
On Thu, Dec 10, 2020 at 1:14 AM David Laight wrote: > > > To me, LLC1 and LLC2 are to Ethernet what UDP and TCP are to IP > > networks. I think we can use LLC1 and LLC2 wherever UDP and TCP can be > > used, as long as we are in the same LAN and are willing to use MAC > > addresses as the addresses

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-10 Thread Tobias Waldekranz
On Thu, Dec 10, 2020 at 00:21, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 11:01:25PM +0100, Tobias Waldekranz wrote: >> It is not the Fibonacci sequence or anything, it is an integer in the >> range 0..num_lags-1. I realize that some hardware probably allocate IDs >> from some shared (and th

linux-next: Signed-off-by missing for commit in the net-next tree

2020-12-10 Thread Stephen Rothwell
Hi all, Commit 5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpY4y_YDX2tE.pgp Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the net-next tree

2020-12-10 Thread Stephen Rothwell
Hi all, On Thu, 10 Dec 2020 21:37:13 +1100 Stephen Rothwell wrote: > > Commit > > 5137d303659d ("net: flow_offload: Fix memory leak for indirect flow block") > > is missing a Signed-off-by from its committer. Sorry, that is in the net tree (not net-next). -- Cheers, Stephen Rothwell pgp

Re: [PATCH net] tcp: fix cwnd-limited bug for TSO deferral where we send nothing

2020-12-10 Thread Eric Dumazet
On 12/10/20 10:50 AM, Ingemar Johansson S wrote: > Hi > Slighty off topic > It is a smaller mystery why I am listed as having reported this artifact ?. > I don't have any memory that I did so.. strange 😐. > I think this was your report : https://mailarchive.ietf.org/arch/msg/tcpm/3U--r1vC8

RE: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-10 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 10 December 2020 12:06 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH net 1/4] net: freescale/fman: Split the main resource > region reservation >

RE: [PATCH net] tcp: fix cwnd-limited bug for TSO deferral where we send nothing

2020-12-10 Thread Ingemar Johansson S
Obviously my memory needs a backup 😊 Thanks /Ingemar > -Original Message- > From: Eric Dumazet > Sent: den 10 december 2020 11:44 > To: Ingemar Johansson S ; Jakub Kicinski > ; Neal Cardwell > Cc: David Miller ; netdev@vger.kernel.org; Neal > Cardwell ; Yuchung Cheng ; > Soheil Hassas

[PATCH net-next] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-10 Thread Toke Høiland-Jørgensen
Jakub pointed out that the IP_ECN_set* helpers basically open-code csum16_add(), so let's switch them over to using the helper instead. Reported-by: Jakub Kicinski Tested-by: Jonathan Morton Tested-by: Pete Heist Signed-off-by: Toke Høiland-Jørgensen --- include/net/inet_ecn.h | 13 +-

[PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250

2020-12-10 Thread Rasmus Villemoes
The 6220 and 6250 switches do not have a learn2all bit in global1, ATU control register; bit 3 is reserverd. On the switches that do have that bit, it is used to control whether learning frames are sent out the ports that have the message_port bit set. So rather than adding yet another chip method

[PATCH v2 2/3] net: mhi: Get RX queue size from MHI core

2020-12-10 Thread Loic Poulain
The RX queue size can be determined at runtime by retrieving the number of available transfer descriptors. Signed-off-by: Loic Poulain --- v2: Fixed commit message typo drivers/net/mhi_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mhi_net.c b/drive

[PATCH v2 3/3] net: mhi: Add dedicated alloc thread

2020-12-10 Thread Loic Poulain
The buffer allocation for RX path is currently done by a work executed in the system workqueue. The work to do is quite simple and consists mostly in allocating and queueing as much as possible buffers to the MHI RX channel. It appears that using a dedicated kthread would be more appropriate to pr

[PATCH v2 1/3] bus: mhi: core: Add helper API to return number of free TREs

2020-12-10 Thread Loic Poulain
From: Hemant Kumar Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam -

Re: [PATCH v1] ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup

2020-12-10 Thread Sébastien Szymanski
Hi, On 12/9/20 1:20 PM, Oleksij Rempel wrote: > Remove board specific PHY fixup introduced by commit: > > | 709bc0657fe6f9f5 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup > init") > > This fixup addresses boards with a specific configuration: a KSZ8081RNA > PHY with attached clock sou

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-10 Thread Nicolas Dichtel
Le 09/12/2020 à 15:40, Eyal Birger a écrit : > Hi Phil, > > On Tue, Dec 8, 2020 at 8:51 PM Phil Sutter wrote: >> >> Hi Eyal, >> >> On Tue, Dec 08, 2020 at 04:47:02PM +0200, Eyal Birger wrote: >>> On Mon, Dec 7, 2020 at 4:07 PM Phil Sutter wrote: [snip] >> >> The packet appears twice being sent t

[PATCH] net: mhi: Fix unexpected queue wake

2020-12-10 Thread Loic Poulain
This patch checks that MHI queue is not full before waking up the net queue. This fix sporadic MHI queueing issues in xmit. Indeed xmit and its symmetric complete callback (ul_callback) can run concurently, it is then not safe to unconditionnaly waking the queue in the callback without checking que

Unchecked HW/hypervisor input issues in rocker module

2020-12-10 Thread Felicitas Hetzelt
Hello Jiri, we have been analyzing the HW/Hypervisor-OS interface of device drivers and discovered bugs in the rocker driver that can be triggered from a malicious Hypervisor or PCI device. The reason for analyzing these interfaces is that, technologies such as Intel's Trusted Domain Extensions [

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-12-10 Thread Michael Ellerman
On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. Applied t

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-10 Thread Eyal Birger
Hi Nicolas, On Thu, Dec 10, 2020 at 1:10 PM Nicolas Dichtel wrote: > > Le 09/12/2020 à 15:40, Eyal Birger a écrit : > > Hi Phil, > > > > On Tue, Dec 8, 2020 at 8:51 PM Phil Sutter wrote: > >> > >> Hi Eyal, > >> > >> On Tue, Dec 08, 2020 at 04:47:02PM +0200, Eyal Birger wrote: > >>> On Mon, Dec 7

[PATCH bpf-next] selftests/bpf: xsk selftests - adding xdpxceiver to .gitignore

2020-12-10 Thread Weqaar Janjua
This patch adds *xdpxceiver* to selftests/bpf/.gitignore Reported-by: Yonghong Song Suggested-by: Yonghong Song Signed-off-by: Weqaar Janjua --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/se

Re: [PATCH bpf-next v4 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

2020-12-10 Thread Weqaar Janjua
On Wed, 9 Dec 2020 at 18:29, Yonghong Song wrote: > > > > On 12/7/20 1:53 PM, Weqaar Janjua wrote: > > Adds following tests: > > > > 1. AF_XDP SKB mode > > Generic mode XDP is driver independent, used when the driver does > > not have support for XDP. Works on any netdevice using sockets a

Re: [PATCH net-next] net: qualcomm: rmnet: Update rmnet device MTU based on real device

2020-12-10 Thread Loic Poulain
On Thu, 10 Dec 2020 at 06:52, Subash Abhinov Kasiviswanathan wrote: > > Packets sent by rmnet to the real device have variable MAP header > lengths based on the data format configured. This patch adds checks > to ensure that the real device MTU is sufficient to transmit the MAP > packet comprising

[PATCH net-next] ice, xsk: Move Rx alloction out of while-loop

2020-12-10 Thread Björn Töpel
From: Björn Töpel Instead of trying to allocate for each packet, move it outside the while loop and try to allocate once every NAPI loop. This change boosts the xdpsock rxdrop scenario with 15% more packets-per-second. Reviewed-by: Maciej Fijalkowski Signed-off-by: Björn Töpel --- drivers/ne

Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-10 Thread tanhuazhong
On 2020/12/10 13:40, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen For some new device, it supports forwarding packet to queues of specified TC when flow director rule hit. So extend the command handle to support it. ... static int hclge

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-10 Thread tanhuazhong
On 2020/12/10 12:50, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen Currently, the HNS3 driver only supports offload for tc number and prio_tc. This patch adds support for other qopts, including queues count and offset for each tc. When enable

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
> url: > https://github.com/0day-ci/linux/commits/Erez-Geva/Add-sending-TX-hardware-timestamp-for-TC-ETF-Qdisc/20201210-000521 I can not find this commit > base:b65054597872ce3aefbc6a666385eabdf9e288da > config: mips-randconfig-r026-20201209 (attached as .config) > compiler: clang v

Re: [PATCH net] tcp: select sane initial rcvq_space.space for big MSS

2020-12-10 Thread Mohamed Abuelfotoh, Hazem
Hi Eric, I don't see the patch in the stable queue. Can we add it to stable so we can cherry pick it in Amazon Linux kernel? Thank you. Hazem On 09/12/2020, 00:29, "David Miller" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attach

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-10 Thread Nicolas Dichtel
Le 10/12/2020 à 12:48, Eyal Birger a écrit : > Hi Nicolas, Hi Eyal, > > On Thu, Dec 10, 2020 at 1:10 PM Nicolas Dichtel > wrote: [snip] > I also think they should be consistent. But it'd still be confusing to me > to get an OUTPUT hook on the inner packet in the forwarding case. I re-read the wh

Regression in igb / bonding / VLAN between 5.8.10 and 5.9.6?

2020-12-10 Thread Maximilian Wilhelm
Dear netdev people, I updated one of my APU2 boxes yesterday and was confronted with an interesting problem: With (Debian) Kernel 5.9.6 VLAN interfaces on top of a bond on top of two I210 NICs are working only one way (outbound) unless the VLAN interface is in promisc mode. The setup looks like t

Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set)

2020-12-10 Thread Jesper Dangaard Brouer
On Wed, 9 Dec 2020 08:44:33 -0700 David Ahern wrote: > On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > > But I have redesigned the ndo_xdp_xmit call to take a bulk of packets > > (up-to 16) so it should not be a problem to solve this by sharing > > TX-queue and talking a lock per 16 packets.

Re: BPF selftests build failure in 5.10-rc

2020-12-10 Thread Seth Forshee
On Wed, Dec 09, 2020 at 04:15:35PM -0800, Andrii Nakryiko wrote: > On Wed, Dec 9, 2020 at 2:24 PM Seth Forshee > wrote: > > > > Building the BPF selftests with clang 11, I'm getting the following > > error: > > > >CLNG-LLC [test_maps] profiler1.o > > In file included from progs/profiler1.c:6

[PATCH net-next] net: mediatek: simplify the return expression of mtk_gmac_sgmii_path_setup()

2020-12-10 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mediatek/mtk_eth_path.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_path.c b/drivers/net/ethernet/mediatek/mtk_eth_path.c index 0fe97155dd8

[PATCH net-next] net: stmmac: simplify the return tc_delete_knode()

2020-12-10 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index

[PATCH net-next] net/mlx4: simplify the return expression of mlx4_init_srq_table()

2020-12-10 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mellanox/mlx4/srq.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/srq.c b/drivers/net/ethernet/mellanox/mlx4/srq.c index cbe4d9746ddf..dd890f5d

[PATCH wireless -next] wireless/ath10k: simplify the return expression of ath10k_ahb_chip_reset()

2020-12-10 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/ath/ath10k/ahb.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c index 05a61975c83f..0ba31c0bbd24 100644

possible deadlock in zd_chip_disable_rxtx

2020-12-10 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8010622c USB: UAS: introduce a quirk to set no_write_same git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=131e6adf50 kernel config:

Re: [Intel-wired-lan] Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set)

2020-12-10 Thread Magnus Karlsson
On Thu, Dec 10, 2020 at 2:32 PM Jesper Dangaard Brouer wrote: > > On Wed, 9 Dec 2020 08:44:33 -0700 > David Ahern wrote: > > > On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > > > But I have redesigned the ndo_xdp_xmit call to take a bulk of packets > > > (up-to 16) so it should not be a probl

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Andrew Lunn
> > So why are returning link up information? > > Yes that was a bit of a hijacking of the function. I will remove that. > I also removed the dependency on this behaviour in the client driver in the > meantime. > > I think a status function on the generic phy would be useful, but I will > take t

[PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-10 Thread Pavana Sharma
Hi Andrew, > For v10 i said: > > What value does the comment add? > I don't remember you replying. Why is 5gbase-r special and it needs a > comment, saying the same thing in CAPS LETTERS? What value is there in > the CAPS LETTERS string? There isn't anything special regarding 5gbase-r apart fro

Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Jeffrey Hugo
On 12/10/2020 1:55 AM, Greg KH wrote: On Wed, Dec 09, 2020 at 11:21:25PM -0800, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device

Re: [PATCH v3 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2020-12-10 Thread Guillaume Nault
On Thu, Dec 10, 2020 at 02:46:23PM +, Tom Parkin wrote: > On Mon, Dec 07, 2020 at 17:22:28 +0100, Guillaume Nault wrote: > > On Fri, Dec 04, 2020 at 04:36:55PM +, Tom Parkin wrote: > > > + case PPPIOCBRIDGECHAN: > > > + if (get_user(unit, p)) > > > +

[PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core

2020-12-10 Thread Heiner Kallweit
gh which tree this is supposed to go. Patch is based on linux-next-20201210. --- drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 3 +-- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- .../marvell/octeontx/otx_cptvf_reqmgr.c | 5 ++-- drivers/crypto/mediatek/mtk-aes.c

Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB

2020-12-10 Thread Maxim Mikityanskiy
On 2020-12-10 10:28, Dan Carpenter wrote: Hi Maxim, url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5 config: i386-randconfig-m021

Re: [PATCH v3 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2020-12-10 Thread Tom Parkin
On Mon, Dec 07, 2020 at 17:22:28 +0100, Guillaume Nault wrote: > On Fri, Dec 04, 2020 at 04:36:55PM +, Tom Parkin wrote: > > + case PPPIOCBRIDGECHAN: > > + if (get_user(unit, p)) > > + break; > > + err = -ENXIO; > > +

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-10 Thread Paraschiv, Andra-Irina
On 09/12/2020 19:30, Jakub Kicinski wrote: On Wed, 9 Dec 2020 17:17:56 +0200 Paraschiv, Andra-Irina wrote: I agree that could be a problem, but here some considerations: - I checked some applications (qemu-guest-agent, ncat, iperf-vsock) and all use the same pattern: allocate memory, initia

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-10 Thread David Ahern
On 12/9/20 11:48 PM, Saeed Mahameed wrote: > On Wed, 2020-12-09 at 20:34 -0700, David Ahern wrote: >> On 12/9/20 10:15 AM, Saeed Mahameed wrote: My personal experience with this one is mlx5/ConnectX4-LX with a limit >>> >>> This limit was removed from mlx5 >>> https://patchwork.ozlabs.org

[PATCH bpf] xsk: fix race in SKB mode transmit with shared cq

2020-12-10 Thread Magnus Karlsson
From: Magnus Karlsson Fix a race when multiple sockets are simultaneously calling sendto() when the completion ring is shared in the SKB case. This is the case when you share the same netdev and queue id through the XDP_SHARED_UMEM bind flag. The problem is that multiple processes can be in xsk_g

[PATCH bpf-next] samples/bpf: fix possible hang in xdpsock with multiple threads

2020-12-10 Thread Magnus Karlsson
From: Magnus Karlsson Fix a possible hang in xdpsock that can occur when using multiple threads. In this case, one or more of the threads might get stuck in the while-loop in tx_only after the user has signaled the main thread to stop execution. In this case, no more Tx packets will be sent, so a

Re: [PATCH net-next] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-10 Thread kernel test robot
Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201210-190846 base: https://git.kernel.org/pub/scm/

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Russell King - ARM Linux admin
On Thu, Dec 10, 2020 at 03:35:29PM +0100, Marcin Wojtas wrote: > Hi Greg, > > śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman > napisał(a): > > What part fixes the issue? I can't see it... > > I re-checked in my setup and here's the smallest part of the original > patch, that fixes previously descri

[PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
Introduce xdp_init_buff utility routine to initialize xdp_buff data structure. Rely on xdp_init_buff in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 3 +-- drivers/n

[PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-10 Thread Tom Parkin
Following on from my previous RFC[1], this series adds two ioctl calls to the ppp code to implement "channel bridging". When two ppp channels are bridged, frames presented to ppp_input() on one channel are passed to the other channel's ->start_xmit function for transmission. The primary use-case

[PATCH v4 net-next 2/2] docs: update ppp_generic.rst to document new ioctls

2020-12-10 Thread Tom Parkin
Add documentation of the newly-added PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls. Signed-off-by: Tom Parkin --- Documentation/networking/ppp_generic.rst | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/networking/ppp_generic.rst b/Documentation/networking/p

Re: [PATCH bpf-next] selftests/bpf: xsk selftests - adding xdpxceiver to .gitignore

2020-12-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 10 Dec 2020 11:54:35 + you wrote: > This patch adds *xdpxceiver* to selftests/bpf/.gitignore > > Reported-by: Yonghong Song > Suggested-by: Yonghong Song > Signed-off-by: Weqaar Janjua > --- > tools/testing/se

[PATCH v4 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

2020-12-10 Thread Tom Parkin
This new ioctl pair allows two ppp channels to be bridged together: frames arriving in one channel are transmitted in the other channel and vice versa. The practical use for this is primarily to support the L2TP Access Concentrator use-case. The end-user session is presented as a ppp channel (typ

Re: [PATCH wireless -next] wireless/ath10k: simplify the return expression of ath10k_ahb_chip_reset()

2020-12-10 Thread Kalle Valo
Zheng Yongjun writes: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun > --- > drivers/net/wireless/ath/ath10k/ahb.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ahb.c > b/drivers/net/wireless/ath/ath10k/ahb.c

Re: [PATCH bpf-next] selftests/bpf: Fix selftest compilation on clang 11

2020-12-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 9 Dec 2020 15:29:12 +0100 you wrote: > We can't compile test_core_reloc_module.c selftest with clang 11, > compile fails with: > > CLNG-LLC [test_maps] test_core_reloc_module.o > progs/test_core_reloc_module.c:57

Re: [PATCH bpf-next] samples/bpf: fix possible hang in xdpsock with multiple threads

2020-12-10 Thread Daniel Borkmann
On 12/10/20 4:36 PM, Magnus Karlsson wrote: From: Magnus Karlsson Fix a possible hang in xdpsock that can occur when using multiple threads. In this case, one or more of the threads might get stuck in the while-loop in tx_only after the user has signaled the main thread to stop execution. In th

Re: [PATCH iproute2-next v1] iplink macvlan: Added bcqueuelen parameter

2020-12-10 Thread Thomas Karlsson
On 2020-11-30 15:23, Thomas Karlsson wrote: > This is a follow up patch to iproute2 that allows the user > to set and retrieve the added IFLA_MACVLAN_BC_QUEUE_LEN parameter > via the bcqueuelen command line argument > > > v1 Initial version >Note: This patch first requires that the correspond

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > Introduce xdp_init_buff utility routine to initialize xdp_buff data > structure. Rely on xdp_init_buff in all XDP capable drivers. Hm, Jesper was suggesting two helpers, one that you implemented for things that are set once per NA

Re: [EXT] Re: [PATCHv3 net-next] octeontx2-pf: Add RSS multi group support

2020-12-10 Thread Geethasowjanya Akula
Thanks Saeed for the feedback. Will address your comments in next version. From: Saeed Mahameed Sent: Thursday, December 10, 2020 12:38 AM To: Geethasowjanya Akula; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Sunil Kovvuri Goutham; da...@dav

Re: [PATCH bpf-next] selftests/bpf: Fix selftest compilation on clang 11

2020-12-10 Thread Jiri Olsa
On Wed, Dec 09, 2020 at 12:24:23PM -0800, Andrii Nakryiko wrote: > On Wed, Dec 9, 2020 at 7:16 AM Jiri Olsa wrote: > > > > We can't compile test_core_reloc_module.c selftest with clang 11, > > compile fails with: > > > > CLNG-LLC [test_maps] test_core_reloc_module.o > > progs/test_core_reloc_m

Re: [PATCH net-next] ice, xsk: Move Rx alloction out of while-loop

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 01:19:15PM +0100, Björn Töpel wrote: > From: Björn Töpel > > Instead of trying to allocate for each packet, move it outside the > while loop and try to allocate once every NAPI loop. To rectify above, it wasn't for each packet but per ICE_RX_BUF_WRITE cleaned frames (16).

Re: [PATCH bpf-next] samples/bpf: fix possible hang in xdpsock with multiple threads

2020-12-10 Thread Magnus Karlsson
On Thu, Dec 10, 2020 at 5:03 PM Daniel Borkmann wrote: > > On 12/10/20 4:36 PM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Fix a possible hang in xdpsock that can occur when using multiple > > threads. In this case, one or more of the threads might get stuck in > > the while-loop in

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > structure. Rely on xdp_init_buff in all XDP capable drivers. > > Hm, Jesper was suggesting two helpers, one that you implemented for things > that are set

[PATCH bpf-next v2] samples/bpf: fix possible hang in xdpsock with multiple threads

2020-12-10 Thread Magnus Karlsson
From: Magnus Karlsson Fix a possible hang in xdpsock that can occur when using multiple threads. In this case, one or more of the threads might get stuck in the while-loop in tx_only after the user has signaled the main thread to stop execution. In this case, no more Tx packets will be sent, so a

Re: [PATCH bpf-next] selftests/bpf: Fix selftest compilation on clang 11

2020-12-10 Thread Daniel Borkmann
On 12/10/20 5:28 PM, KP Singh wrote: On Thu, Dec 10, 2020 at 5:18 PM Jiri Olsa wrote: [...] It's hard and time-consuming enough to develop these features, I'd rather keep selftests simpler, more manageable, and less brittle by not having excessive amount of feature detection and skipped selfte

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Steen Hegelund
On 10.12.2020 03:11, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 01b53f86004c..f6a094c81e86 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -66,9 +66,11

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
Hi Greg, śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman napisał(a): > > On Tue, Dec 08, 2020 at 04:02:50PM +0100, Marcin Wojtas wrote: > > Hi Sasha, > > > > wt., 8 gru 2020 o 14:35 Sasha Levin napisał(a): > > > > > > On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: > > > >Hi Greg, > >

[PATCH net-next] net: dsa: mt7530: enable MTU normalization

2020-12-10 Thread DENG Qingfang
MT7530 has a global RX length register, so we are actually changing its MRU. Enable MTU normalization for this reason. Signed-off-by: DENG Qingfang --- drivers/net/dsa/mt7530.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 99bf8fe

Re: [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-10 Thread Tom Parkin
On Thu, Dec 10, 2020 at 18:13:09 +0100, Guillaume Nault wrote: > On Thu, Dec 10, 2020 at 03:50:56PM +, Tom Parkin wrote: > > Following on from my previous RFC[1], this series adds two ioctl calls > > to the ppp code to implement "channel bridging". > > > > When two ppp channels are bridged, f

  1   2   3   >