Fixes: bdfffab54933 ("netlink: message format descriptions for rtnetlink")
Cc: Michal Kubecek
Signed-off-by: Ivan Vecera
---
netlink/prettymsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink/prettymsg.c b/netlink/prettymsg.c
index 9e62bebe615e..f992dcaf071f 100644
Memory blocks referenced by new_state and old_state are never freed.
For efeatures there is no need to check pointer as free() can be called
with NULL parameter.
Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES")
Cc: Michal Kubecek
Signed-off-by: Ivan Vecera
---
ethtool.
The System Controller Firmware (SCFW) is a low-level system function
which runs on a dedicated Cortex-M core to provide power, clock, and
resource management. It exists on some i.MX8 processors. e.g. i.MX8QM
(QM, QP), and i.MX8QX (QXP, DX).
SCU driver manages the IPC interface between host CPU and
can: flexcan: initialize all flexcan memory for ECC function
can: flexcan: add flexcan driver for i.MX8MP
These two patches add i.MX8MP driver support.
can: flexcan: add CAN wakeup function for i.MX8
This single patch add stop mode support for i.MX8 serials, e.g.
i.MX8QM/QXP
can: flexcan: disable
Disable runtime PM if register flexcandev failed, and balance reference
of usage_count.
Signed-off-by: Joakim Zhang
---
drivers/net/can/flexcan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 41b52cb56f93..dd9845146982 100644
--
There is a NOTE at the section "Detection and correction of memory errors":
All FlexCAN memory must be initialized before starting its operation in
order to have the parity bits in memory properly updated. CTRL2[WRMFRZ]
grants write access to all memory positions that require initialization,
rangin
Add flexcan driver for i.MX8MP, which supports CAN FD and ECC.
Signed-off-by: Joakim Zhang
---
drivers/net/can/flexcan.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index f02f1de2bbca..8c8753f77764 100644
--- a/drivers/net/ca
On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote:
> On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote:
> > On 9/24/20 3:24 AM, Eli Cohen wrote:
> > > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
> > --- linux-next-20200917.orig/drivers/vdpa/K
There are two chip pins named TXDLY and RXDLY which actually adds the 2ns
delays to TXC and RXC for TXD/RXD latching. These two pins can config via
4.7k-ohm resistor to 3.3V hw setting, but also config via software setting
(extension page 0xa4 register 0x1c bit13 12 and 11).
The configuration regi
On 9/25/20 5:10 PM, Joakim Zhang wrote:
> There is a NOTE at the section "Detection and correction of memory errors":
Can you add a reference to one datasheet including name, revision and section?
> All FlexCAN memory must be initialized before starting its operation in
> order to have the parity
On Thu, 24 Sep 2020 22:12:24 +0200
Heiner Kallweit wrote:
> On 24.09.2020 21:14, Petr Tesarik wrote:
> > On Wed, 23 Sep 2020 11:57:41 +0200
> > Heiner Kallweit wrote:
> >
> >> On 03.09.2020 10:41, Petr Tesarik wrote:
> >>> Hi Heiner,
> >>>
> >>> this issue was on the back-burner for some time,
On 9/25/20 5:10 PM, Joakim Zhang wrote:
> There is a NOTE at the section "Detection and correction of memory errors":
> All FlexCAN memory must be initialized before starting its operation in
> order to have the parity bits in memory properly updated. CTRL2[WRMFRZ]
> grants write access to all memo
On 9/25/20 5:10 PM, Joakim Zhang wrote:
> Add flexcan driver for i.MX8MP, which supports CAN FD and ECC.
>
> Signed-off-by: Joakim Zhang
> ---
> drivers/net/can/flexcan.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> in
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 15:33
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC function
>
> On 9/
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 15:37
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 2/4] can: flexcan: add flexcan
> driver
> for i.MX8MP
>
> On 9/25/20 5:10 PM, J
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 15:29
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC function
>
> On 9/
On 9/25/20 12:03 AM, Daniel Borkmann wrote:
> On 9/24/20 8:58 PM, Eric Dumazet wrote:
>> On 9/24/20 8:21 PM, Daniel Borkmann wrote:
> [...]
>>> diff --git a/include/linux/cookie.h b/include/linux/cookie.h
>>> new file mode 100644
>>> index ..2488203dc004
>>> --- /dev/null
>>> +++ b/i
On 9/25/20 9:38 AM, Joakim Zhang wrote:
> I notice it just now, seems lack of patch for imx firmware in upstream, that
> will always export scu symbols. include/linux/firmware/imx/svc/misc.h
That will affect "can: flexcan: add CAN wakeup function for i.MX8" not this
patch, right?
Marc
--
Pengut
On Fri, Sep 25, 2020 at 4:45 AM Yongxin Liu wrote:
>
> This reverts commit 09ef193fef7efb0175a04634853862d717adbb95.
>
> For C3000 family of SoCs, they have four ixgbe devices sharing a single MDIO
> bus.
> ixgbe_mii_bus_init() returns -ENODEV for other three devices. The propagation
> of the err
On Fri, 25 Sep 2020 at 01:03, Martin KaFai Lau wrote:
>
> check_reg_type() checks whether a reg can be used as an arg of a
> func_proto. For PTR_TO_BTF_ID, the check is actually not
> completely done until the reg->btf_id is pointing to a
> kernel struct that is acceptable by the func_proto.
>
>
On Fri, 25 Sep 2020 at 01:04, Martin KaFai Lau wrote:
>
> There is a constant need to add more fields into the bpf_tcp_sock
> for the bpf programs running at tc, sock_ops...etc.
>
> A current workaround could be to use bpf_probe_read_kernel(). However,
> other than making another helper call for
On Fri, 25 Sep 2020 at 01:04, Martin KaFai Lau wrote:
>
> The patch tests for:
> 1. bpf_sk_release() can be called on a tcp_sock btf_id ptr.
>
> 2. Ensure the tcp_sock btf_id pointer cannot be used
>after bpf_sk_release().
>
> Signed-off-by: Martin KaFai Lau
Acked-by: Lorenz Bauer
> ---
>
Hello,
syzbot found the following issue on:
HEAD commit:12450081 libbpf: Fix native endian assumption when parsing..
git tree: bpf
console output: https://syzkaller.appspot.com/x/log.txt?x=10bf85c590
kernel config: https://syzkaller.appspot.com/x/.config?x=5ac0d21536db480b
dashboar
Hello,
syzbot found the following issue on:
HEAD commit:77972b55 Revert "ravb: Fixed to be able to unload modules"
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=110cf80990
kernel config: https://syzkaller.appspot.com/x/.config?x=5f4c828c9e3cef97
dashboard
From: Kai-Heng Feng
> Sent: 24 September 2020 17:04
...
> > I also don't fully understand the fix. You are now looping up to 6400
> > times, each with a delay of 50uS. So that is around 12800 times more
> > than it actually needs to transfer the 64 bits! I've no idea how this
> > hardware works, bu
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 16:11
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC function
>
> On 9/
> -Original Message-
> From: Bartosz Golaszewski
> Sent: Friday, September 25, 2020 16:15
> To: Liu, Yongxin
> Cc: David S . Miller ; netdev
> ; LKML
> Subject: Re: [PATCH] Revert "net: ethernet: ixgbe: check the return value
> of ixgbe_mii_bus_init()"
>
> On Fri, Sep 25, 2020 at 4:45 A
On Fri, 25 Sep 2020 09:30:37 +0200
Petr Tesarik wrote:
> On Thu, 24 Sep 2020 22:12:24 +0200
> Heiner Kallweit wrote:
>
> > On 24.09.2020 21:14, Petr Tesarik wrote:
> > > On Wed, 23 Sep 2020 11:57:41 +0200
> > > Heiner Kallweit wrote:
> > >
> > >> On 03.09.2020 10:41, Petr Tesarik wrote:
On Thu, 24 Sep 2020 at 20:58, John Fastabend wrote:
>
> The meaning of PTR_TO_BTF_ID_OR_NULL differs slightly from other types
> denoted with the *_OR_NULL type. For example the types PTR_TO_SOCKET
> and PTR_TO_SOCKET_OR_NULL can be used for branch analysis because the
> type PTR_TO_SOCKET is guar
On 9/25/20 10:51 AM, Joakim Zhang wrote:
>>> I notice it just now, seems lack of patch for imx firmware in
>>> upstream, that will always export scu symbols.
>>> include/linux/firmware/imx/svc/misc.h
>>
>> That will affect "can: flexcan: add CAN wakeup function for i.MX8" not this
>> patch, right?
On 9/25/20 5:10 PM, Joakim Zhang wrote:
> Add flexcan driver for i.MX8MP, which supports CAN FD and ECC.
>
> Signed-off-by: Joakim Zhang
> ---
> drivers/net/can/flexcan.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> in
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 17:03
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all
> flexcan
> memory for ECC function
>
> On 9/
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 17:05
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 2/4] can: flexcan: add flexcan
> driver
> for i.MX8MP
>
> On 9/25/20 5:10 PM, J
On 9/25/20 11:09 AM, Joakim Zhang wrote:
>>> "can: flexcan: initialize all flexcan memory for ECC function" for
>>> this patch, I find this issue in i.MX8MP, which is the first SoC
>>> implements ECC for i.MX
>>
>> What about the mx7?
>>> I think this patch should compatible with others which has E
On 9/25/20 9:49 AM, Eric Dumazet wrote:
On 9/25/20 12:03 AM, Daniel Borkmann wrote:
On 9/24/20 8:58 PM, Eric Dumazet wrote:
On 9/24/20 8:21 PM, Daniel Borkmann wrote:
[...]
diff --git a/include/linux/cookie.h b/include/linux/cookie.h
new file mode 100644
index ..2488203dc004
--- /
On 9/25/20 11:11 AM, Joakim Zhang wrote:
>> This doesn't apply to net-next/master. The MX8QM indented differently.
>
> Need I rebase on net-next/master in next version? This patch set is made from
> linux-can-next/flexcan branch.
Yes, the flexcan patches are already in David's tree, so please base
This is a follow-up on a earlier patch submission at:-
https://patchwork.ozlabs.org/patch/1275604/
Changes since the previous patch submission:
- Enable VLAN fail queue for Intel platform data (dwmac-intel).
- Steer the VLAN failed packet to the last Rx queue.
Chuah, Kim Tatt (1):
net: stmmac:
On Fri, 25 Sep 2020 at 01:03, Martin KaFai Lau wrote:
>
> This set allows networking prog type to directly read fields from
> the in-kernel socket type, e.g. "struct tcp_sock".
>
> Patch 2 has the details on the use case.
>
> v3:
> - Pass arg_btf_id instead of fn into check_reg_type() in Patch 1 (
From: "Chuah, Kim Tatt"
Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
Queuing. This option allows packets that fail VLAN filter to be routed
to a specific Rx queue when Receive All is also set.
When this option is enabled:
- Enable VFFQ only when entering promiscuous mode,
On 25.09.2020 10:54, Petr Tesarik wrote:
> On Fri, 25 Sep 2020 09:30:37 +0200
> Petr Tesarik wrote:
>
>> On Thu, 24 Sep 2020 22:12:24 +0200
>> Heiner Kallweit wrote:
>>
>>> On 24.09.2020 21:14, Petr Tesarik wrote:
On Wed, 23 Sep 2020 11:57:41 +0200
Heiner Kallweit wrote:
>>>
On Fri, Sep 25, 2020 at 10:51 AM Liu, Yongxin wrote:
>
[snip]
> > > true);
> > >
> > > - err = ixgbe_mii_bus_init(hw);
> > > - if (err)
> > > - goto err_netdev;
> > > + ixgbe_mii_bus_init(hw);
> > >
> > > return 0;
> > >
> > > -err_
On 9/25/20 5:10 PM, Joakim Zhang wrote:
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
> resource management. It exists on some i.MX8 processors. e.g. i.MX8QM
> (QM, QP), and i.MX8QX (QXP, DX).
>
> SCU d
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 17:36
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 2/4] can: flexcan: add flexcan
> driver
> for i.MX8MP
>
> On 9/25/20 11:11 AM,
> -Original Message-
> From: Marc Kleine-Budde
> Sent: 2020年9月25日 17:44
> To: Joakim Zhang ; linux-...@vger.kernel.org
> Cc: dl-linux-imx ; netdev@vger.kernel.org
> Subject: Re: [PATCH linux-can-next/flexcan 3/4] can: flexcan: add CAN wakeup
> function for i.MX8
>
> On 9/25/20 5:10 PM, J
While unloading the dwmac-intel driver, clk_disable_unprepare() is
being called twice in stmmac_dvr_remove() and
intel_eth_pci_remove(). This causes kernel panic on the second call.
Removing the second call of clk_disable_unprepare() in
intel_eth_pci_remove().
Fixes: 09f012e64e4b ("stmmac: intel:
On Fri, 25 Sep 2020 11:44:09 +0200
Heiner Kallweit wrote:
> On 25.09.2020 10:54, Petr Tesarik wrote:
> > On Fri, 25 Sep 2020 09:30:37 +0200
> > Petr Tesarik wrote:
> >
> >> On Thu, 24 Sep 2020 22:12:24 +0200
> >> Heiner Kallweit wrote:
> >>
> >>> On 24.09.2020 21:14, Petr Tesarik wrote:
The shared header to define SOCKMAP_MAX_ENTRIES is a bit overkill.
Dynamically allocate the sock_fd array based on bpf_map__max_entries
instead.
Suggested-by: Yonghong Song
Signed-off-by: Lorenz Bauer
Acked-by: Yonghong Song
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 36 +-
Enable calling map_update_elem on sockmaps from bpf_iter context. This
in turn allows us to copy a sockmap by iterating its elements.
The change itself is tiny, all thanks to the ground work from Martin,
whose series [1] this patch is based on. I updated the tests to do some
copying, and also incl
Allow passing a pointer to a BTF struct sock_common* when updating
a sockmap or sockhash. Since BTF pointers can fault and therefore be
NULL at runtime we need to add an additional !sk check to
sock_map_update_elem. Doing this allows calling map_update_elem on
sockmap from bpf_iter context, which u
We compare socket cookies to ensure that insertion into a sockmap worked.
Pull this out into a helper function for use in other tests.
Signed-off-by: Lorenz Bauer
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 50 +--
1 file changed, 36 insertions(+), 14 deletions(-)
diff -
Since we can now call map_update_elem(sockmap) from bpf_iter context
it's possible to copy a sockmap or sockhash in the kernel. Add a
selftest which exercises this.
Signed-off-by: Lorenz Bauer
---
.../selftests/bpf/prog_tests/sockmap_basic.c | 14 +-
.../selftests/bpf/progs/bpf_iter_soc
On 9/25/20 11:48 AM, Joakim Zhang wrote:
>>> Need I rebase on net-next/master in next version? This patch set is
>>> made from linux-can-next/flexcan branch.
>> Yes, the flexcan patches are already in David's tree, so please base on
>> net-next/master.
>
> Ok, another I want to indicate is that, i
Try to recycle the xdp tx buffer into the in-irq page_pool cache if
mvneta_txq_bufs_free is executed in the NAPI context.
Signed-off-by: Lorenzo Bianconi
---
drivers/net/ethernet/marvell/mvneta.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
On Fri, Sep 25, 2020 at 10:20:05AM +0300, Leon Romanovsky wrote:
> On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote:
> > On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote:
> > > On 9/24/20 3:24 AM, Eli Cohen wrote:
> > > > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Micha
On Thu, Sep 24, 2020 at 01:24:13PM +0300, Eli Cohen wrote:
> On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
> > > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > > > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > > > @@ -31,7 +31,7 @@ config IFCVF
> > > >
> > > > con
On Fri, Sep 25, 2020 at 12:54 PM Wong Vee Khee wrote:
>
> While unloading the dwmac-intel driver, clk_disable_unprepare() is
> being called twice in stmmac_dvr_remove() and
> intel_eth_pci_remove(). This causes kernel panic on the second call.
>
> Removing the second call of clk_disable_unprepare(
From: Nikolay Aleksandrov
We should remove a group from the sg_port hash only if it's an S,G
entry. This makes it correct and more symmetric with group add. Also
since *,G groups are not added to that hash we can hide a bug.
Fixes: 085b53c8beab ("net: bridge: mcast: add sg_port rhashtable")
Sign
On Fri, 25 Sep 2020 12:01:32 +0200
Lorenzo Bianconi wrote:
> Try to recycle the xdp tx buffer into the in-irq page_pool cache if
> mvneta_txq_bufs_free is executed in the NAPI context.
NACK - I don't think this is safe. That is also why I named the
function postfix rx_napi. The page pool->allo
On Tue, Sep 22, 2020 at 12:27:33PM -0700, Priyaranjan Jha wrote:
> From: Priyaranjan Jha
>
> Ack aggregation is quite prevalent with wifi, cellular and cable modem
> link tchnologies, ACK decimation in middleboxes, and common offloading
> techniques such as TSO and GRO, at end hosts. Previously,
On 2020-09-15 16:51, Christoph Hellwig wrote:
[...]
+These APIs allow to allocate pages in the kernel direct mapping that are
+guaranteed to be DMA addressable. This means that unlike dma_alloc_coherent,
+virt_to_page can be called on the resulting address, and the resulting
Nit: if we explici
On Thu, Sep 24, 2020 at 5:06 PM Oliver Neukum wrote:
>
> Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya:
>
> > I meant that it was stupid to change it without properly understanding
> > the significance of GFP_NOIO in this context.
> >
> > So now, do we re-write the wrapper functi
On 2020/9/24 下午5:31, Michael S. Tsirkin wrote:
On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote:
We need to free vqs during the err path after it has been allocated
since vhost won't do that for us.
Signed-off-by: Jason Wang
This is a bugfix too right? I don't see it posted separa
On 2020/9/25 下午6:19, Michael S. Tsirkin wrote:
On Fri, Sep 25, 2020 at 10:20:05AM +0300, Leon Romanovsky wrote:
On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote:
On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote:
On 9/24/20 3:24 AM, Eli Cohen wrote:
On Thu, Sep
>
> On Fri, 25 Sep 2020 12:01:32 +0200
> Lorenzo Bianconi wrote:
>
> > Try to recycle the xdp tx buffer into the in-irq page_pool cache if
> > mvneta_txq_bufs_free is executed in the NAPI context.
>
> NACK - I don't think this is safe. That is also why I named the
> function postfix rx_napi. The
On 2020/9/24 下午6:17, Stefan Hajnoczi wrote:
On Thu, Sep 24, 2020 at 11:21:01AM +0800, Jason Wang wrote:
This series tries to add the support for control virtqueue in vDPA.
Please include documentation for both driver authors and vhost-vdpa
ioctl users. vhost-vdpa ioctls are only documented wi
On 2020/9/24 下午3:48, Eli Cohen wrote:
On Thu, Sep 24, 2020 at 11:21:03AM +0800, Jason Wang wrote:
We need to free vqs during the err path after it has been allocated
since vhost won't do that for us.
Signed-off-by: Jason Wang
---
drivers/vhost/vdpa.c | 11 ---
1 file changed, 8 in
On Tue, Sep 22, 2020 at 7:51 PM David Miller wrote:
>
> From: Michal Kubecek
> Date: Wed, 23 Sep 2020 01:23:17 +0200
>
> > Even if the module parameters are deprecated and extremely inconvenient
> > as a mean of bonding configuration, I would say changing their names
> > would still count as "bre
Hi Lorenz,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Lorenz-Bauer/Sockmap-copying/20200925-175852
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm
On Fri, 25 Sep 2020 13:29:00 +0200
Lorenzo Bianconi wrote:
> >
> > On Fri, 25 Sep 2020 12:01:32 +0200
> > Lorenzo Bianconi wrote:
> >
> > > Try to recycle the xdp tx buffer into the in-irq page_pool cache if
> > > mvneta_txq_bufs_free is executed in the NAPI context.
> >
> > NACK - I don't t
On Tue, Sep 22, 2020 at 6:19 PM Jay Vosburgh wrote:
>
> Jarod Wilson wrote:
>
> >The bonding driver's use of master and slave, while largely understood
> >in technical circles, poses a barrier for inclusion to some potential
> >members of the development and user community, due to the historical
At this stage, the tc-flower offload of mscc_ocelot can only delegate
rules to the VCAP IS2 security enforcement block. These rules have, in
hardware, separate bits for policing and for overriding the destination
port mask and/or copying to the CPU. So it makes sense that we attempt
to expose some
On Thu, Sep 24, 2020 at 3:01 AM David Miller wrote:
>
> From: Hauke Mehrtens
> Date: Tue, 22 Sep 2020 23:41:12 +0200
>
> > The TX DMA channel data is accessed by the xrx200_start_xmit() and the
> > xrx200_tx_housekeeping() function from different threads. Make sure the
> > accesses are synchroniz
Currently a new filter is created, containing just enough correct
information to be able to call ocelot_vcap_block_find_filter_by_index()
on it.
This will be limiting us in the future, when we'll have more metadata
associated with a filter, which will matter in the stats() and destroy()
callbacks,
This is the result of this discussion:
https://lkml.org/lkml/2020/6/2/203
RFC because there are still some TODO items:
- I haven't added VCAP fields to Ocelot and to Seville, mostly because I
don't understand how to derive the ENTRY_WIDTH setting. Would
appreciate some help there. I've only te
We were installing TCAM rules with the LOOKUP field as unmasked, meaning
that all entries were matching on all lookups. Now that lookups are
exposed as individual chains, let's make the LOOKUP explicit when
offloading TCAM entries.
Signed-off-by: Vladimir Oltean
---
drivers/net/ethernet/mscc/oce
Since the mscc_ocelot_switch_lib is common between a pure switchdev and
a DSA driver, the procedure of retrieving a net_device for a certain
port index differs, as those are registered by their individual
front-ends.
Up to now that has been dealt with by always passing the port index to
the switch
In the Ocelot switches there are 3 TCAMs: VCAP ES0, IS1 and IS2, which
have the same register layout but different actions. The Ocelot driver
currently only supports VCAP IS2, the security enforcement block which
implements Access Control List actions (trap, drop, police).
In preparation of VCAP I
Via the OCELOT_MASK_MODE_REDIRECT flag put in the IS2 action vector, it
is possible to replace previous forwarding decisions with the port mask
installed in this rule.
I have studied Table 54 "MASK_MODE and PORT_MASK Combinations" from the
VSC7514 documentation and it appears to behave sanely when
From: Xiaoliang Yang
When calculating vcap data offset, the function only supports half key
entry. This patch modify vcap_data_offset_get function to calculate a
correct data offset when setting VCAP Type-Group to VCAP_TG_FULL or
VCAP_TG_QUARTER.
Signed-off-by: Xiaoliang Yang
---
drivers/net/e
And rename the existing find to ocelot_vcap_block_find_filter_by_index.
The index is the position in the TCAM, and the id is the flow cookie
given by tc.
Signed-off-by: Vladimir Oltean
---
drivers/net/ethernet/mscc/ocelot_vcap.c | 26 ++---
drivers/net/ethernet/mscc/ocelot_vc
Provide an example script which can be used as a skeleton for offloading
TCAM rules in the Ocelot switches.
Signed-off-by: Vladimir Oltean
---
MAINTAINERS | 1 +
.../drivers/net/ocelot/test_tc_chains.sh | 179 ++
2 files changed, 180 inser
For Ocelot switches, there are 2 ingress pipelines for flow offload
rules: VCAP IS1 (Ingress Classification) and IS2 (Security Enforcement).
IS1 and IS2 support different sets of actions. The pipeline order for a
packet on ingress is:
Basic classification -> VCAP IS1 -> VCAP IS2
Furthermore, IS1
There are some targets (register blocks) in the Ocelot switch that are
instantiated more than once. For example, the VCAP IS1, IS2 and ES0
blocks all share the same register layout for interacting with the cache
for the TCAM and the action RAM.
For the VCAPs, the procedure for servicing them is ac
The issue which led to the introduction of this check was that MAC_ETYPE
rules, such as filters on dst_mac and src_mac, would only match non-IP
frames. There is a knob in VCAP_S2_CFG which forces all IP frames to be
treated as non-IP, which is what we're currently doing if the user
requested a dst_
From: Xiaoliang Yang
VCAP IS1 is a VCAP module which can filter on the most common L2/L3/L4
Ethernet keys, and modify the results of the basic QoS classification
and VLAN classification based on those flow keys.
There are 3 VCAP IS1 lookups, mapped over chains 1, 11000 and 12000.
Currently t
From: Xiaoliang Yang
VCAP ES0 is an egress VCAP working on all outgoing frames.
This patch added ES0 driver to support vlan push action of tc filter.
Usage:
tc filter add dev swp1 egress protocol 802.1Q flower indev swp0 skip_sw \
vlan_id 1 vlan_prio 1 action vlan push id 2 priority 2
T
On Sat, Sep 19, 2020 at 7:48 AM Christoph Hellwig wrote:
>
> > diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> > index 797ba2c1562a..a332d6ae4dc6 100644
> > --- a/include/uapi/linux/if.h
> > +++ b/include/uapi/linux/if.h
> > @@ -247,7 +247,13 @@ struct ifreq {
> > sh
Hi Dan,
url:
https://github.com/0day-ci/linux/commits/Dan-Murphy/DP83869-WoL-and-Speed-optimization/20200925-002844
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
3fc826f121d89c5aa4afd7b3408b07e0ff59466b
config: x86_64-randconfig-m001-20200925 (attached as
To start also "phy state machine", with UP state as it should be,
the phy_start() has to be used, in another case machine even is not
triggered. After this change negotiation is supposed to be triggered
by SM workqueue.
It's not correct usage, but it appears after the following patch,
so add it as
From: Mark Salyzyn
commit 37bd22420f856fcd976989f1d4f1f7ad28e1fcac upstream.
In pfkey_dump() dplen and splen can both be specified to access the
xfrm_address_t structure out of bounds in__xfrm_state_filter_match()
when it calls addr_match() with the indexes. Return EINVAL if either
are out of r
On Fri, 25 Sep 2020 11:52:41 +0200
Petr Tesarik wrote:
> On Fri, 25 Sep 2020 11:44:09 +0200
> Heiner Kallweit wrote:
>
> > On 25.09.2020 10:54, Petr Tesarik wrote:
>[...]
> > > Does it make sense to bisect the change that broke the driver for me, or
> > > should I rather dispose of this wast
From: Mark Salyzyn
commit 37bd22420f856fcd976989f1d4f1f7ad28e1fcac upstream.
In pfkey_dump() dplen and splen can both be specified to access the
xfrm_address_t structure out of bounds in__xfrm_state_filter_match()
when it calls addr_match() with the indexes. Return EINVAL if either
are out of r
> On Fri, 25 Sep 2020 13:29:00 +0200
> Lorenzo Bianconi wrote:
>
> > >
> > > On Fri, 25 Sep 2020 12:01:32 +0200
> > > Lorenzo Bianconi wrote:
> > >
> > > > Try to recycle the xdp tx buffer into the in-irq page_pool cache if
> > > > mvneta_txq_bufs_free is executed in the NAPI context.
> > >
call vxlan_remcsum() before md filling in vxlan_rcv()
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index b9fefe27e3e89..47c762f7f5b11 100644
--- a/drivers/net/vxlan.c
+
This small patchet does some clean-up on vxlan.
Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by
Michal and David
I hope to have some feedback/ACK from vxlan developers.
Fabian Frederick (5):
vxlan: don't collect metadata if remote checksum is wrong
vxlan: add unli
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and
info was already tested. Emit warning in that function instead
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/ne
small optimization around checking as it's being done in all
receptions
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 47c762f7f5b11..cc904f003f158 100644
--- a/drivers/ne
rtnl_configure_link is always checked if < 0 for error code.
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 14f903d09c010..1e9ab1002281c 100644
--- a/drivers/net/vxlan.c
+
Since commit aab8cc3630e32
("vxlan: add support for underlay in non-default VRF")
vxlan_find_sock() also checks if socket is assigned to the right
level 3 master device when lower device is not in the default VRF.
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 5 +++--
1 file changed
On Fri, Sep 25, 2020 at 09:26:36AM +0100, Lorenz Bauer wrote:
> On Fri, 25 Sep 2020 at 01:04, Martin KaFai Lau wrote:
> >
> > There is a constant need to add more fields into the bpf_tcp_sock
> > for the bpf programs running at tc, sock_ops...etc.
> >
> > A current workaround could be to use bpf_p
1 - 100 of 350 matches
Mail list logo
