[PATCH AUTOSEL 5.6 21/62] ibmvnic: Skip fatal error reset after passive init

2020-05-14 Thread Sasha Levin
From: Juliet Kim [ Upstream commit f9c6cea0b38518741c8dcf26ac056d26ee2fd61d ] During MTU change, the following events may happen. Client-driven CRQ initialization fails due to partner’s CRQ closed, causing client to enqueue a reset task for FATAL_ERROR. Then passive (server-driven) CRQ initializ

[PATCH AUTOSEL 5.6 22/62] soc: qcom: ipa: IPA endpoints

2020-05-14 Thread Sasha Levin
From: Alex Elder [ Upstream commit 84f9bd12d46dbe8ac7d4b650a8fbb4c49657a38b ] This patch includes the code implementing an IPA endpoint. This is the primary abstraction implemented by the IPA. An endpoint is one end of a network connection between two entities physically connected to the IPA.

[PATCH AUTOSEL 5.6 13/62] vhost/vsock: fix packet delivery order to monitoring devices

2020-05-14 Thread Sasha Levin
From: Stefano Garzarella [ Upstream commit 107bc0766b9feb5113074c753735a3f115c2141f ] We want to deliver packets to monitoring devices before it is put in the virtqueue, to avoid that replies can appear in the packet capture before the transmitted packet. Signed-off-by: Stefano Garzarella Sign

[PATCH AUTOSEL 5.6 15/62] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

2020-05-14 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 10e3cc180e64385edc9890c6855acf5ed9ca1339 ] A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', called from 'sonic_probe1()'. This is correctly freed in the remove function, but not in the error handling path of the probe function

[PATCH AUTOSEL 5.6 18/62] net/ena: Fix build warning in ena_xdp_set()

2020-05-14 Thread Sasha Levin
From: Gavin Shan [ Upstream commit caec66198d137c26f0d234abc498866a58c64150 ] This fixes the following build warning in ena_xdp_set(), which is observed on aarch64 with 64KB page size. In file included from ./include/net/inet_sock.h:19, from ./include/net/ip.h:27, from drivers/ne

[PATCH AUTOSEL 5.6 02/62] net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()

2020-05-14 Thread Sasha Levin
From: Masahiro Yamada [ Upstream commit 1cd9b3abf5332102d4d967555e7ed861a75094bf ] In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR. The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR from being 'm' when NET_DEVLINK=y. With the planned Kconfig change that relaxes the 'i

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Jakub Kicinski
On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > One interesting implementation bit, that significantly simplifies (and thus > speeds up as well) implementation of both producers and consumers is how data > area is mapped twice contiguously back-to-back in the virtual memory. This > allo

Re: [Ocfs2-devel] remove kernel_setsockopt and kernel_getsockopt

2020-05-14 Thread Matthew Wilcox
On Thu, May 14, 2020 at 11:11:34AM +, David Laight wrote: > From: 'Christoph Hellwig' > > Sent: 14 May 2020 11:35 > > On Thu, May 14, 2020 at 10:26:41AM +, David Laight wrote: > > > From: Christoph Hellwig > > > > Only for those were we have users, and all those are covered. > > > > > > Wha

Re: [PATCH bpf] samples: bpf: fix build error

2020-05-14 Thread Alexei Starovoitov
On Mon, May 11, 2020 at 1:32 PM Yonghong Song wrote: > > > > On 5/11/20 4:32 AM, Matteo Croce wrote: > > GCC 10 is very strict about symbol clash, and lwt_len_hist_user contains > > a symbol which clashes with libbpf: > > > > /usr/bin/ld: samples/bpf/lwt_len_hist_user.o:(.bss+0x0): multiple > > d

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Igor Russkikh
> I'm not 100% happy that the debug data gets reported to the management > FW before the devlink health code is in place. For the Linux community, > I think, having standard Linux interfaces implemented first is the > priority. Hi Jakub, Thanks for the comment. I feel these two are a bit separa

Re: [PATCH] security: fix the default value of secid_to_secctx hook

2020-05-14 Thread James Morris
On Tue, 12 May 2020, Anders Roxell wrote: > security_secid_to_secctx is called by the bpf_lsm hook and a successful > return value (i.e 0) implies that the parameter will be consumed by the > LSM framework. The current behaviour return success when the pointer > isn't initialized when CONFIG_BPF_L

Re: [PATCH bpf] bpf: fix bug in mmap() implementation for BPF array map

2020-05-14 Thread Alexei Starovoitov
On Tue, May 12, 2020 at 8:21 PM Yonghong Song wrote: > > > > On 5/12/20 4:59 PM, Andrii Nakryiko wrote: > > mmap() subsystem allows user-space application to memory-map region with > > initial page offset. This wasn't taken into account in initial > > implementation > > of BPF array memory-mappin

[PATCH net-next v1] net: phy: tja11xx: execute cable test on link up

2020-05-14 Thread Oleksij Rempel
A typical 100Base-T1 link should be always connected. If the link is in a shot or open state, it is a failure. In most cases, we won't be able to automatically handle this issue, but we need to log it or notify user (if possible). With this patch, the cable will be tested on "ip l s dev .. up" att

Re: [PATCH] security: fix the default value of secid_to_secctx hook

2020-05-14 Thread James Morris
On Wed, 13 May 2020, Alexei Starovoitov wrote: > James, > > since you took the previous similar patch are you going to pick this > one up as well? > Or we can route it via bpf tree to Linus asap. Routing via your tree is fine. > > Thanks > > On Tue, May 12, 2020 at 10:46 AM Anders Roxell >

Re: [PATCH bpf-next] libbpf: Fix register naming in PT_REGS s390 macros

2020-05-14 Thread Alexei Starovoitov
On Wed, May 13, 2020 at 11:14 AM Andrii Nakryiko wrote: > > On Wed, May 13, 2020 at 8:45 AM Sumanth Korikkar > wrote: > > > > Fix register naming in PT_REGS s390 macros > > > > Fixes: b8ebce86ffe6 ("libbpf: Provide CO-RE variants of PT_REGS macros") > > Reviewed-by: Julian Wiedmann > > Signed-o

Re: [PATCH] drivers: ipa: use devm_kzalloc for simplicity

2020-05-14 Thread David Miller
From: Jakub Kicinski Date: Thu, 14 May 2020 10:15:16 -0700 > On Wed, 13 May 2020 20:55:20 -0700 Wang Wenhu wrote: >> Make a substitution of kzalloc with devm_kzalloc to simplify the >> ipa_probe() process. >> >> Signed-off-by: Wang Wenhu > > The code is perfectly fine as is. What problem are y

Re: [PATCH] security: fix the default value of secid_to_secctx hook

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 12:43 PM James Morris wrote: > > On Wed, 13 May 2020, Alexei Starovoitov wrote: > > > James, > > > > since you took the previous similar patch are you going to pick this > > one up as well? > > Or we can route it via bpf tree to Linus asap. > > Routing via your tree is fine

Re: [PATCH] net: stmmac: fix num_por initialization

2020-05-14 Thread David Miller
From: Vinod Koul Date: Thu, 14 May 2020 11:58:36 +0530 > Driver missed initializing num_por which is por values that driver > configures to hardware. In order to get this values, add a new structure > ethqos_emac_driver_data which holds por and num_por values and populate > that in driver probe.

Re: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Dan Murphy
Andrew On 5/14/20 1:39 PM, Andrew Lunn wrote: On Thu, May 14, 2020 at 12:30:54PM -0500, Dan Murphy wrote: Add a dt binding for the TI dp83822 ethernet phy device. CC: Rob Herring Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83822.yaml | 49 +++ 1 file c

Re: [PATCH RESEND net-next] selftests: fix flower parent qdisc

2020-05-14 Thread David Miller
From: Vlad Buslov Date: Thu, 14 May 2020 09:35:52 +0300 > Flower tests used to create ingress filter with specified parent qdisc > "parent :" but dump them on "ingress". With recent commit that fixed > tcm_parent handling in dump those are not considered same parent anymore, > which causes ip

Re: [PATCH] Fix suspicious RCU usage warning

2020-05-14 Thread David Miller
From: Madhuparna Bhowmik Date: Thu, 14 May 2020 12:34:09 +0530 > Sorry for this malformed patch, I have sent a patch with all these > corrections. It still needs more work, see Jakub's feedback. Thank you.

Re: [PATCH] net: phy: realtek: clear interrupt during init for rtl8211f

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 08:25, Jisheng Zhang wrote: > On Wed, 13 May 2020 20:45:13 +0200 Heiner Kallweit wrote: > >> >> On 13.05.2020 08:51, Jisheng Zhang wrote: >>> Hi, >>> >>> On Tue, 12 May 2020 20:43:40 +0200 Heiner Kallweit wrote: >>> On 12.05.2020 12:46, Jisheng Zhang wrote: > T

Re: [PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings

2020-05-14 Thread David Miller
From: Ayush Sawal Date: Thu, 14 May 2020 13:23:29 +0530 > @@ -256,7 +256,7 @@ static void get_aes_decrypt_key(unsigned char *dec_key, > return; > } > for (i = 0; i < nk; i++) > - w_ring[i] = be32_to_cpu(*(u32 *)&key[4 * i]); > + w_ring[i] = be32_t

Re: [PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Daniel Borkmann
On 5/14/20 6:58 PM, Christoph Hellwig wrote: On Thu, May 14, 2020 at 06:16:04PM +0200, Daniel Borkmann wrote: Small set of fixes in order to restrict BPF helpers for tracing which are broken on archs with overlapping address ranges as per discussion in [0]. I've targetted this for -bpf tree so t

Re: [PATCH v3 00/15] mediatek: add support for MediaTek Ethernet MAC

2020-05-14 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 14 May 2020 09:59:27 +0200 > Next we do some cleanup of the mediatek ethernet drivers directory and update > the devres documentation with existing networking devres helpers. I don't agree with the new devres stuff. You have to be very careful with the order

Re: remove kernel_setsockopt and kernel_getsockopt

2020-05-14 Thread David Miller
From: David Laight Date: Thu, 14 May 2020 08:29:30 + > You need to export functions that do most of the socket options > for all protocols. If all in-tree users of this stuff are converted, there is no argument for keeping these routines. You seemed to be concerned about out of tree stuff.

Re: [PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Christoph Hellwig
On Thu, May 14, 2020 at 09:54:06PM +0200, Daniel Borkmann wrote: > On 5/14/20 6:58 PM, Christoph Hellwig wrote: >> On Thu, May 14, 2020 at 06:16:04PM +0200, Daniel Borkmann wrote: >>> Small set of fixes in order to restrict BPF helpers for tracing which are >>> broken on archs with overlapping addr

Re: [PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 19:00, Jeremy Linton wrote: > The commit "disregard Clause 22 registers present bit..." clears > the low bit of the devices_in_package data which is being used > in get_phy_c45_ids() to determine if a phy/register is responding > correctly. That check is against 0x1FFF, but since

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: Igor Russkikh Date: Thu, 14 May 2020 12:57:16 +0300 > FastLinQ devices as a complex systems may observe various hardware > level error conditions, both severe and recoverable. > > Driver is able to detect and report this, but so far it only did > trace/dmesg based reporting. > > Here we i

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 22:40:12 +0300 Igor Russkikh wrote: > > I'm not 100% happy that the debug data gets reported to the management > > FW before the devlink health code is in place. For the Linux community, > > I think, having standard Linux interfaces implemented first is the > > priority. > >

Re: remove kernel_setsockopt and kernel_getsockopt

2020-05-14 Thread David Miller
From: David Laight Date: Thu, 14 May 2020 10:26:41 + > I doubt we are the one company with out-of-tree drivers > that use the kernel_socket interface. Not our problem.

Re: [PATCH net] pppoe: only process PADT targeted at local interfaces

2020-05-14 Thread David Miller
From: Guillaume Nault Date: Thu, 14 May 2020 12:15:39 +0200 > We don't want to disconnect a session because of a stray PADT arriving > while the interface is in promiscuous mode. > Furthermore, multicast and broadcast packets make no sense here, so > only PACKET_HOST is accepted. > > Reported-by

Re: [PATCH] drivers: ipa: fix typos for ipa_smp2p structure doc

2020-05-14 Thread David Miller
From: Wang Wenhu Date: Thu, 14 May 2020 04:02:22 -0700 > Remove the duplicate "mutex", and change "Motex" to "Mutex". Also I > recommend it's easier for understanding to make the "ready-interrupt" > a bundle for it is a parallel description as "shutdown" which is appended > after the slash. > >

Re: [PATCH bpf-next 0/6] BPF ring buffer

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 9:30 AM Jonathan Lemon wrote: > > On Wed, May 13, 2020 at 11:08:46PM -0700, Andrii Nakryiko wrote: > > On Wed, May 13, 2020 at 3:49 PM Jonathan Lemon > > wrote: > > > > > > On Wed, May 13, 2020 at 12:25:26PM -0700, Andrii Nakryiko wrote: > > > > Implement a new BPF ring b

Re: [EXT] Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread Igor Russkikh
On 14/05/2020 11:02 pm, Jakub Kicinski wrote: > That's fine, I'm just saying - I hope the devlink part doesn't take too > long to implement :) > > I'm only applying this series because I trust that you will actually do > the > devlink work, and you will have it done and submitted in a reasona

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: David Miller Date: Thu, 14 May 2020 13:01:59 -0700 (PDT) > From: Igor Russkikh > Date: Thu, 14 May 2020 12:57:16 +0300 > >> FastLinQ devices as a complex systems may observe various hardware >> level error conditions, both severe and recoverable. >> >> Driver is able to detect and report

Re: [PATCH net-next 1/4] net: sched: introduce terse dump flag

2020-05-14 Thread David Miller
From: Vlad Buslov Date: Thu, 14 May 2020 14:40:23 +0300 > +static const u32 tca_dump_flags_allowed = TCA_DUMP_FLAGS_TERSE; > + > +static const struct nla_policy tcf_tfilter_dump_policy[TCA_MAX + 1] = { > + [TCA_DUMP_FLAGS] = NLA_POLICY_BITFIELD32(tca_dump_flags_allowed), > +}; The compiler a

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 9:50 AM Jonathan Lemon wrote: > > On Wed, May 13, 2020 at 12:25:27PM -0700, Andrii Nakryiko wrote: > > +static struct bpf_ringbuf *bpf_ringbuf_restore_from_rec(void *meta_ptr) > > +{ > > + unsigned long addr = (unsigned long)meta_ptr; > > + unsigned long off = *(u32

Re: [PATCH net 1/1] MAINTAINERS: another add of Karsten Graul for S390 networking

2020-05-14 Thread David Miller
From: Ursula Braun Date: Thu, 14 May 2020 13:45:12 +0200 > Complete adding of Karsten as maintainer for all S390 networking > parts in the kernel. > > Cc: Julian Wiedmann > Acked-by: Julian Wiedmann > Signed-off-by: Ursula Braun Applied, thanks.

[PATCH] MAINTAINERS: Add Jakub to networking drivers.

2020-05-14 Thread David Miller
Signed-off-by: David S. Miller --- Honestly this is just a formality as NETWORKING general is a superset of this. MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 391e7eea6a3e..4b270dbdf09b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11718,6 +

Re: [PATCH net-next 1/3] mptcp: add new sock flag to deal with join subflows

2020-05-14 Thread Mat Martineau
Paolo - On Wed, 13 May 2020, Paolo Abeni wrote: MP_JOIN subflows must not land into the accept queue. Currently tcp_check_req() calls an mptcp specific helper to detect such scenario. Such helper leverages the subflow context to check for MP_JOIN subflows. We need to deal also with MP JOIN f

Re: [PATCH 0/6] Netfilter fixes for net

2020-05-14 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 14 May 2020 14:19:07 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Fix gcc-10 compilation warning in nf_conntrack, from Arnd Bergmann. > > 2) Add NF_FLOW_HW_PENDING to avoid races between stats and deletion >commands, from Paul Bl

Re: [PATCH net/next] r8152: Use MAC address from device tree if available

2020-05-14 Thread David Miller
From: Thierry Reding Date: Thu, 14 May 2020 14:38:48 +0200 > From: Thierry Reding > > If a MAC address was passed via the device tree node for the r8152 > device, use it and fall back to reading from EEPROM otherwise. This is > useful for devices where the r8152 EEPROM was not programmed with a

Re: [PATCH net-next 0/5] net: hns3: add some cleanups for -next

2020-05-14 Thread David Miller
From: Huazhong Tan Date: Thu, 14 May 2020 20:41:21 +0800 > This patchset adds some cleanups for the HNS3 ethernet driver. Series applied, thanks.

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 10:33 AM wrote: > > On 05/13, Andrii Nakryiko wrote: > > This commits adds a new MPSC ring buffer implementation into BPF > > ecosystem, > > which allows multiple CPUs to submit data to a single shared ring buffer. > > On > > the consumption side, only single consumer is as

Re: [PATCH v2 net-next 00/11] net: qed/qede: critical hw error handling

2020-05-14 Thread David Miller
From: David Miller Date: Thu, 14 May 2020 13:09:52 -0700 (PDT) > Actually, I had to revert, please fix these warnings (with gcc-10.1.1 on > Fedora)_: > > drivers/net/ethernet/qlogic/qed/qed_dev.c: In function > ‘qed_llh_add_mac_filter’: > ./include/linux/printk.h:303:2: warning: ‘abs_ppfid’ ma

Re: [PATCH bpf-next 0/6] BPF ring buffer

2020-05-14 Thread Jonathan Lemon
On Wed, May 13, 2020 at 11:08:46PM -0700, Andrii Nakryiko wrote: > On Wed, May 13, 2020 at 3:49 PM Jonathan Lemon > wrote: > > > > On Wed, May 13, 2020 at 12:25:26PM -0700, Andrii Nakryiko wrote: > > > Implement a new BPF ring buffer, as presented at BPF virtual conference > > > ([0]). > > > It

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Thomas Gleixner
Jakub Kicinski writes: > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: >> One interesting implementation bit, that significantly simplifies (and thus >> speeds up as well) implementation of both producers and consumers is how data >> area is mapped twice contiguously back-to-back in t

Re: [PATCH] net: phy: Fix c45 no phy detected logic

2020-05-14 Thread Jeremy Linton
Hi, On 5/14/20 2:59 PM, Heiner Kallweit wrote: On 14.05.2020 19:00, Jeremy Linton wrote: The commit "disregard Clause 22 registers present bit..." clears the low bit of the devices_in_package data which is being used in get_phy_c45_ids() to determine if a phy/register is responding correctly. T

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 12:06 PM Alexei Starovoitov wrote: > > On Wed, May 13, 2020 at 12:25:27PM -0700, Andrii Nakryiko wrote: > > + > > +/* Given pointer to ring buffer record metadata, restore pointer to struct > > + * bpf_ringbuf itself by using page offset stored at offset 4 > > + */ > > +sta

Re: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Andrew Lunn
> > Hi Dan > > > > You say 10/100 Mbps Ethernet PHY, but then list RGMII? > Copied from the data sheet. O.K. So maybe it can connect over RGMII, but then only run 100Mbps over it, rather than 1G. > The LED_1 pin can be strapped to be an input to the chip for signal loss > detection.  This is an

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Jonathan Lemon
On Wed, May 13, 2020 at 12:25:27PM -0700, Andrii Nakryiko wrote: > +static struct bpf_ringbuf *bpf_ringbuf_restore_from_rec(void *meta_ptr) > +{ > + unsigned long addr = (unsigned long)meta_ptr; > + unsigned long off = *(u32 *)(meta_ptr + 4) << PAGE_SHIFT; > + > + return (void*)((addr &

Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation for burst

2020-05-14 Thread Vladimir Oltean
Hi Colin, On Thu, 14 May 2020 at 21:34, Colin King wrote: > > From: Colin Ian King > > Currently burst is clamping on rate and not burst, the assignment > of burst from the clamping discards the previous assignment of burst. > This looks like a cut-n-paste error from the previous clamping > calc

Re: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Dan Murphy
Andrew On 5/14/20 3:50 PM, Andrew Lunn wrote: Hi Dan You say 10/100 Mbps Ethernet PHY, but then list RGMII? Copied from the data sheet. O.K. So maybe it can connect over RGMII, but then only run 100Mbps over it, rather than 1G. Yes.  This is not a 1Gbps PHY.  Max is 100Mbps. The LED_1 pin

Re: [PATCH net-next 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-05-14 Thread Andrew Lunn
> Why would we need 2?  The SFP core would need to know that the LOS is > connected to the PHY. That is possible today. Just don't list the GPIO when declaring the SFP. > The PHY is strapped to configure the LED_1 as a GPIO input.  I am > not seeing a register that we can force this configuration

Re: [PATCH bpf 3/3] bpf: restrict bpf_trace_printk()'s %s usage and add %psK, %psU specifier

2020-05-14 Thread Daniel Borkmann
On 5/14/20 8:10 PM, Yonghong Song wrote: On 5/14/20 9:16 AM, Daniel Borkmann wrote: Usage of plain %s conversion specifier in bpf_trace_printk() suffers from the very same issue as bpf_probe_read{,str}() helpers, that is, it is broken on archs with overlapping address ranges. While the helpers

Re: [PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Daniel Borkmann
On 5/14/20 9:58 PM, Christoph Hellwig wrote: On Thu, May 14, 2020 at 09:54:06PM +0200, Daniel Borkmann wrote: On 5/14/20 6:58 PM, Christoph Hellwig wrote: On Thu, May 14, 2020 at 06:16:04PM +0200, Daniel Borkmann wrote: Small set of fixes in order to restrict BPF helpers for tracing which are

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:53 PM wrote: > > On 05/14, Andrii Nakryiko wrote: > > On Thu, May 14, 2020 at 10:33 AM wrote: > > > > > > On 05/13, Andrii Nakryiko wrote: > > [...] > > > > > + * void bpf_ringbuf_submit(void *data) > > > > + * Description > > > > + * Submit reserved ring buf

Re: [PATCH] MAINTAINERS: Add Jakub to networking drivers.

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 01:14:03PM -0700, David Miller wrote: > > Signed-off-by: David S. Miller > --- > > Honestly this is just a formality as NETWORKING general is > a superset of this. > > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > inde

[net-next v2 0/9][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-14

2020-05-14 Thread Jeff Kirsher
This series contains updates to igc driver only. Sasha adds ECN support for TSO by adding the NETIF_F_TSO_ECN flag, which aligns with other Intel drivers. Also cleaned up defines that are not supported or used in the igc driver. Andre does most of the changes with updating the log messages for i

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > Jakub Kicinski writes: > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > >> One interesting implementation bit, that significantly simplifies (and thus > >> speeds up as well) implementation of both producers and consumers

[net-next v2 9/9] igc: Remove unneeded register

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Flow control status register not applicable for i225 parts so clean up the unneeded define. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_regs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_main.c we print log messages using both dev_* and netdev_* helpers, generating inconsistent output. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out of the log

[net-next v2 7/9] igc: Use netdev log helpers in igc_base.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes This patch coverts one pr_debug() call to hw_dbg() in order to keep log output aligned with the rest of the driver. hw_dbg() is actually a macro defined in igc_hw.h that expands to netdev_dbg(). It also takes this opportunity to remove the '\n' character at the end of messages

[net-next v2 5/9] igc: Use netdev log helpers in igc_ptp.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ptp.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out o

[net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Jeff Kirsher
From: Vitaly Lifshits Introduced igc_diag.c and igc_diag.h, these files have the diagnostics functionality of igc driver. For the time being these files are being used by ethtool self-test callbacks. Which mean that eeprom, registers and link self-tests for ethtool were implemented. Signed-off-b

[net-next v2 1/9] igc: Add ECN support for TSO

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Align with other Intel drivers and add ECN support for TSO. Add NETIF_F_TSO_ECN flag Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ne

[net-next v2 4/9] igc: Use netdev log helpers in igc_ethtool.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ethtool.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense t

[net-next v2 8/9] igc: Remove unneeded definition

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin PHY_FORCE_LIMIT definition not in use and could be removed i225 parts support auto negotiation mechanism Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) di

[net-next v2 6/9] igc: Use netdev log helpers in igc_dump.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_dump.c we print log messages using dev_* and pr_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making s

Re: [PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend on PTP_1588_CLOCK

2020-05-14 Thread Arnd Bergmann
On Thu, May 14, 2020 at 8:52 PM Sasha Levin wrote: > > From: Clay McClure > > [ Upstream commit b6d49cab44b567b3e0a5544b3d61e516a7355fad ] > > Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed > all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply > PTP_158

r8169: don't include linux/moduleparam.h

2020-05-14 Thread Heiner Kallweit
93882c6f210a ("r8169: switch from netif_xxx message functions to netdev_xxx") removed the last module parameter from the driver, therefore there's no need any longer to include linux/moduleparam.h. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 1 - 1 file changed

r8169: remove not needed checks in rtl8169_set_eee

2020-05-14 Thread Heiner Kallweit
After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee") we don't need the check for aneg being enabled any longer, and as discussed with Russell configuring the EEE advertisement should be supported even if we're in a half-duplex mode currently. Signed-off-by: Heiner Kallweit ---

Re: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c > b/drivers/net/ethernet/intel/igc/igc_diag.c > new file mode 100644 > index ..1c4536105e56 > --- /dev/null > +++ b/drivers/net/ethernet/intel/igc/igc_diag.c > @@ -0,0 +1,186

Re: [PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-05-14 Thread Dan Murphy
Andrew On 5/14/20 1:52 PM, Andrew Lunn wrote: +static int dp83822_config_init(struct phy_device *phydev) +{ + struct dp83822_private *dp83822 = phydev->priv; + int err = 0; + + if (dp83822->fx_enabled) { + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, +

Re: [PATCH 1/9] bpf: Add d_path helper

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:30 AM Jiri Olsa wrote: > > Adding d_path helper function that returns full path > for give 'struct path' object, which needs to be the > kernel BTF 'path' object. > > The helper calls directly d_path function. > > Updating also bpf.h tools uapi header and adding > 'path' t

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 23:31, Jeff Kirsher wrote: > From: Andre Guedes > > In igc_main.c we print log messages using both dev_* and netdev_* > helpers, generating inconsistent output. Since this is a network device > driver, we should preferably use netdev_* helpers because they append > the interface nam

Re: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread David Miller
From: Jakub Kicinski Date: Thu, 14 May 2020 14:52:19 -0700 > On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote: >> diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c >> b/drivers/net/ethernet/intel/igc/igc_diag.c >> new file mode 100644 >> index ..1c4536105e56 >> --- /dev/nul

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Paul E. McKenney
On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > Jakub Kicinski writes: > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > > >> One interesting implementation bit, that significantly simplifies (an

Re: [PATCH net] tcp: fix error recovery in tcp_zerocopy_receive()

2020-05-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 May 2020 13:58:13 -0700 > If user provides wrong virtual address in TCP_ZEROCOPY_RECEIVE > operation we want to return -EINVAL error. > > But depending on zc->recv_skip_hint content, we might return > -EIO error if the socket has SOCK_DONE set. > > Make sure to

[PATCH v17 05/23] net: Prepare UDS for security module stacking

2020-05-14 Thread Casey Schaufler
Change the data used in UDS SO_PEERSEC processing from a secid to a more general struct lsmblob. Update the security_socket_getpeersec_dgram() interface to use the lsmblob. There is a small amount of scaffolding code that will come out when the security_secid_to_secctx() code is brought in line wit

Re: [PATCH net-next 0/3] mptcp: fix MP_JOIN failure handling

2020-05-14 Thread David Miller
Paolo, please respond to the feedback you received for patch #1. Thank you.

Re: [PATCH 3/9] bpf: Add bpfwl tool to construct bpf whitelists

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:30 AM Jiri Olsa wrote: > > This tool takes vmlinux object and whitelist directory on input > and produces C source object with BPF whitelist data. > > The vmlinux object needs to have a BTF information compiled in. > > The whitelist directory is expected to contain files w

Re: [PATCH net-next] net: dsa: sja1105: disable rxvlan offload for the DSA master

2020-05-14 Thread David Miller
From: Vladimir Oltean Date: Wed, 13 May 2020 02:49:21 +0300 > From: Vladimir Oltean > > On sja1105 operating in best_effort_vlan_filtering mode (when the TPID > of the DSA tags is 0x8100), it can be seen that __netif_receive_skb_core > calls __vlan_hwaccel_clear_tag right before passing the skb

RE: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Kirsher, Jeffrey T
> -Original Message- > From: David Miller > Sent: Thursday, May 14, 2020 15:08 > To: k...@kernel.org > Cc: Kirsher, Jeffrey T ; Lifshits, Vitaly > ; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com; lkp ; dan.carpen...@oracle.com; > Brown, Aaron F > Subject: Re: [net-next

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Alan Maguire
On Wed, 13 May 2020, Andrii Nakryiko wrote: > On Wed, May 13, 2020 at 2:59 PM Alan Maguire wrote: > > > > > > - attach a kprobe program to record the data via bpf_ringbuf_reserve(), > > and store the reserved pointer value in a per-task keyed hashmap. > > Then record the values of interest in

[PATCH v17 14/23] LSM: Ensure the correct LSM context releaser

2020-05-14 Thread Casey Schaufler
Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

[PATCH v17 15/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-05-14 Thread Casey Schaufler
Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

[PATCH v17 17/23] LSM: security_secid_to_secctx in netlink netfilter

2020-05-14 Thread Casey Schaufler
Change netlink netfilter interfaces to use lsmcontext pointers, and remove scaffolding. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler cc: netdev@vger.kernel.org --- net/netfilter/nfnetlink_queue.c | 31 --

Re: [PATCH 4/9] bpf: Allow nested BTF object to be refferenced by BTF object + offset

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:31 AM Jiri Olsa wrote: > > Adding btf_struct_address function that takes 2 BTF objects > and offset as arguments and checks wether object A is nested > in object B on given offset. > > This function is be used when checking the helper function > PTR_TO_BTF_ID arguments. If

Re: [PATCH 0/8 net] the indirect flow_block offload, revisited

2020-05-14 Thread Pablo Neira Ayuso
On Thu, May 14, 2020 at 12:44:48PM +0100, Edward Cree wrote: > On 13/05/2020 17:41, Pablo Neira Ayuso wrote: > > Hi, > > > > This patchset fixes the indirect flow_block support for the tc CT action > > offload. Please, note that this batch is probably slightly large for the > > net tree, however, I

Re: [PATCH 6/9] bpf: Compile bpfwl tool at kernel compilation start

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:31 AM Jiri Olsa wrote: > > The bpfwl tool will be used during the vmlinux linking, > so it's necessary it's ready. > > Signed-off-by: Jiri Olsa > --- > Makefile | 21 + > tools/Makefile | 3 +++ > tools/bpf/Makefile | 5 - > 3 file

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Alan Maguire
On Wed, 13 May 2020, Yonghong Song wrote: > > > On 5/11/20 10:56 PM, Alan Maguire wrote: > > printk supports multiple pointer object type specifiers (printing > > netdev features etc). Extend this support using BTF to cover > > arbitrary types. "%pT" specifies the typed format, and the poin

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Andre Guedes
Hi Heiner, Quoting Heiner Kallweit (2020-05-14 15:07:42) > On 14.05.2020 23:31, Jeff Kirsher wrote: > > @@ -4877,8 +4870,7 @@ static int igc_probe(struct pci_dev *pdev, > > > > if (igc_get_flash_presence_i225(hw)) { > > if (hw->nvm.ops.validate(hw) < 0) { > > -

Re: [PATCH 7/9] bpf: Compile the BTF id whitelist data in vmlinux

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:05 AM Jiri Olsa wrote: > > On Wed, May 13, 2020 at 11:29:40AM -0700, Alexei Starovoitov wrote: > > SNIP > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > > index d09ab4afbda4..dee91c6bf450 100755 > > > --- a/scripts/link-vmlinux.sh > > > +++ b/scr

Re: [PATCH 8/9] selftests/bpf: Add test for d_path helper

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:32 AM Jiri Olsa wrote: > > Adding test for d_path helper which is pretty much > copied from Wenbo Zhang's test for bpf_get_fd_path, > which never made it in. > > I've failed so far to compile the test with > kernel header, so for now adding 'struct file' with f_path > mem

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > Jakub Kicinski writes: > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > > >> One interesting implementation bit, that significantly simplifies (an

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 3:56 PM Alexei Starovoitov wrote: > > On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > > > Jakub Kicinski writes: > > > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > >

Re: bpf selftest execution issues

2020-05-14 Thread Andrii Nakryiko
On Tue, May 12, 2020 at 7:46 AM Alan Maguire wrote: > > When running BPF tests I ran into some issues and couldn't get a clean > set of results on the bpf-next master branch. Just wanted to check if anyone > else is seeing any of these failures. > > 1. Timeouts. When running "make run_tests" in to

Re: [PATCH bpf-next] bpf, bpftool: Allow probing for CONFIG_HZ from kernel config

2020-05-14 Thread Andrii Nakryiko
On Wed, May 13, 2020 at 1:00 AM Daniel Borkmann wrote: > > In Cilium we've recently switched to make use of bpf_jiffies64() for > parts of our tc and XDP datapath since bpf_ktime_get_ns() is more > expensive and high-precision is not needed for our timeouts we have > anyway. Our agent has a probe

<    1   2   3   4   5   >